Received-SPF: pass (google.com: domain of linux-kernel+bounces-73339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Frank Li <Frank.Li@nxp.com>
To: lpieralisi@kernel.org
Cc: Frank.li@nxp.com,
	bhelgaas@google.com,
	cassel@kernel.org,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	festevam@gmail.com,
	helgaas@kernel.org,
	hongxing.zhu@nxp.com,
	imx@lists.linux.dev,
	kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	kw@linux.com,
	l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org,
	robh@kernel.org,
	s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: [PATCH v11 11/14] PCI: imx6: Clean up get addr_space code
Date: Tue, 20 Feb 2024 11:19:21 -0500
Message-Id: <20240220161924.3871774-12-Frank.Li@nxp.com>
In-Reply-To: <20240220161924.3871774-1-Frank.Li@nxp.com>
References: <20240220161924.3871774-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tSwQqC7dVQE7kYV4tzEHt4QM23TYCwGyZRLCE3EINUfgjiU3jiBwyRNukoRD?=
 =?us-ascii?Q?EpRKSCrVijzuETIbe8edd7YSCYmoKHnuwUCgnjHUcOdUIHPdWt9OAvgeJauM?=
 =?us-ascii?Q?Jx3WhEf7PqMGofY+SVz4YKXmvcHn6lWKzhL1BW7t+J1MOC0PRgimdUDC5eyE?=
 =?us-ascii?Q?WZqXtSVlUQRDAXVVSXRkQ0NX0FHXleK84RrxkrL5FVQd1XhfSWoMd4y6m790?=
 =?us-ascii?Q?LOrud43ZNOEVKABDC69DcAXSM61PD1yjN1xpUGGRgzPFhYGjHErpeY96KEJd?=
 =?us-ascii?Q?YQayuZbURTNUJu+X2D2F95+0xs+YUwZJF0xocEIvhNarM40ObnXCswt0EPGf?=
 =?us-ascii?Q?PxJAGGxb6Pd0AJtPSRB5fIsXuaINO+KwOSV/LqtejVqmIRQKhpV+g02XWnEM?=
 =?us-ascii?Q?eMV/LM8hlKKWGM+uooBuAgilHgUllgPaPv2jNihhhuPicfc4uo8667uXa9J0?=
 =?us-ascii?Q?jEKVPnx37F7i+gievKKTdJ87mWiqe/R9XUVYOvfHDIxpKNjdU+AJzmmMAAS9?=
 =?us-ascii?Q?oPv08+xN+8AF0+b+vDmcWoIyfxzPED5c0B0xc91m+8T7ogm+c5gyhPbG+8vL?=
 =?us-ascii?Q?AUIcjtlJCIAQm2QqQJgaLjyKCg9H9e+ma7TCvOO2qMOQBfkKNJDtpl5FpkRP?=
 =?us-ascii?Q?1hVVPFr2BkicsVwPPXXUJezLxon5bTvQfovD6jnWxLENgMuEsXgtF4k1Fdfa?=
 =?us-ascii?Q?zNcV/L4z0pnAPX5YOVUiuYWip3v/gvqt1t8UXXIjjgW0n/R3VVF3Rt5iG7Zn?=
 =?us-ascii?Q?3AOGEbtEkpPNB8ZF/yyQWGK+UfuCeln/BcPSZUOIcEkHlSiIgVxld8suYnYK?=
 =?us-ascii?Q?kB+2yqb5tE9taiHAjQgAQiv4z7MjDI486V3OsFAY2F7kgSCgMYOneg04AOfu?=
 =?us-ascii?Q?+TFU3AodFpzGbfJviW+2epA3+1fJdj6nipEYndiMDlA3csB/vTYGscw0NWa8?=
 =?us-ascii?Q?wpIA5JkhHP0LvRI1v0k1cnmTjTO3DZlRtGeqrCBNeWvXKY69QLDCLenjrgQ7?=
 =?us-ascii?Q?m2XTuswr83SY2WJojz0zDclruq3tRTWn++Ok8tnAfF9+fVPGVNJz5TW490NO?=
 =?us-ascii?Q?8rcmn+SjU9Ua9Sd6IMi/U7tkGlmBkRYo6JpSPFTRsVSU1vvgFhfvCSuwCNOu?=
 =?us-ascii?Q?pRgOwsbD8aIfP90czHScwN/8mMLmQzo0WoiM8miEHvBzbv33pOLlhy1BGFbF?=
 =?us-ascii?Q?4UYO+eayljO/ucMhZE7bdcv5/UnjxvO+f8gH5lR3l7YRTgg60wZahPK2W58U?=
 =?us-ascii?Q?73sVobwXlxMtfvyfraFyLoLj8MXDI1/xzO/2SbiLvFD8anGZj/m3a2XS3fK3?=
 =?us-ascii?Q?LsO7ctVyR5Qb0PH8W0l0OOoxdl6jtPJvCQf/B+TKYSxjU2t+Ebbv79MnvjrA?=
 =?us-ascii?Q?lxWtQbn29C8tZArDO39FXeTrJvi/z0WPZbNmeJ31iLAQNbpcFR7dJ4W3XI8g?=
 =?us-ascii?Q?B/v57jbyQK6BHllNUYv0mbevE520dVSOwV8TA7yfPayZf5y3ZMx99od/D6F5?=
 =?us-ascii?Q?3tKKDSeVpaQiC4CXG7wHJ0VLn25x22jonRdJWdTACMgd2WQ+ydHTTU0HTEtq?=
 =?us-ascii?Q?x22B+owRD2rULChxld7hWfmGY6KScTJm/mXOuLNy?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de002cf2-3ad0-42b7-b123-08dc322fe1fa
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 16:20:41.7375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sG/quSK4CnUZRUq34zy1RQ5cgeOqNr7vV4ig1MVJof92weIY+svNRaKkxLWXBTAyfhHuDSoSdG67C2az/x2w3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295

Since the dw_pcie_ep_init() function is already fetching the 'addr_space'
region, no need to do the same in this driver.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v7 to v8
    - update commit message
    - Add Manivannan Sadhasivam's review tag
    Change from v4 to v7
    - none
    Change from v1 to v3
    - new patches

 drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 582ba00d628a1..3009c3ffa1415 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1068,7 +1068,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 	int ret;
 	unsigned int pcie_dbi2_offset;
 	struct dw_pcie_ep *ep;
-	struct resource *res;
 	struct dw_pcie *pci = imx6_pcie->pci;
 	struct dw_pcie_rp *pp = &pci->pp;
 	struct device *dev = pci->dev;
@@ -1087,14 +1086,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 		pcie_dbi2_offset = SZ_4K;
 		break;
 	}
-	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
-	if (!res)
-		return -EINVAL;
 
-	ep->phys_base = res->start;
-	ep->addr_size = resource_size(res);
-	ep->page_size = SZ_64K;
+	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
 
 	ret = dw_pcie_ep_init(ep);
 	if (ret) {
-- 
2.34.1