Received-SPF: pass (google.com: domain of linux-kernel+bounces-73404-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 09:09:52 -0800
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Waiman Long <longman@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
	Jin Wang <jin1.wang@intel.com>
Subject: Re: [PATCH v3] clocksource: Scale the max retry number of watchdog
 read according to CPU numbers
Message-ID: <d0517bce-6284-43b8-bcf8-c56ac83fb31f@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240129134505.961208-1-feng.tang@intel.com>
 <87msrwadvu.ffs@tglx>
 <ZdNnjdNTjtvpbGH0@feng-clx.sh.intel.com>
 <388686b2-5305-43d1-8edf-19ba66d52727@redhat.com>
 <0b7833a4-75f3-43ba-9d87-6f83cf4faa5a@paulmck-laptop>
 <ZdTE2SzO1pZ0QjUn@feng-clx.sh.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdTE2SzO1pZ0QjUn@feng-clx.sh.intel.com>

On Tue, Feb 20, 2024 at 11:27:21PM +0800, Feng Tang wrote:
> On Tue, Feb 20, 2024 at 07:24:27AM -0800, Paul E. McKenney wrote:
> > On Mon, Feb 19, 2024 at 09:20:31PM -0500, Waiman Long wrote:
> > > 
> > > On 2/19/24 09:37, Feng Tang wrote:
> > > > Hi Thomas,
> > > > 
> > > > On Mon, Feb 19, 2024 at 12:32:05PM +0100, Thomas Gleixner wrote:
> > > > > On Mon, Jan 29 2024 at 21:45, Feng Tang wrote:
> > > > > > +static inline long clocksource_max_watchdog_read_retries(void)
> > > > > > +{
> > > > > > +	long max_retries = max_cswd_read_retries;
> > > > > > +
> > > > > > +	if (max_cswd_read_retries <= 0) {
> > > > > > +		/* santity check for user input value */
> > > > > > +		if (max_cswd_read_retries != -1)
> > > > > > +			pr_warn_once("max_cswd_read_retries was set with an invalid number: %ld\n",
> > > > > > +				max_cswd_read_retries);
> > > > > > +
> > > > > > +		max_retries = ilog2(num_online_cpus()) + 1;
> > > > > I'm getting tired of these knobs and the horrors behind them. Why not
> > > > > simply doing the obvious:
> > > > > 
> > > > >         retries = ilog2(num_online_cpus()) + 1;
> > > > > 
> > > > > and remove the knob alltogether?
> > > > Thanks for the suggestion! Yes, this makes sense to me. IIUC, the
> > > > 'max_cswd_read_retries' was introduced mainly to cover different
> > > > platforms' requirement, which could now be covered by the new
> > > > self-adaptive number.
> > > > 
> > > > If there is no concern from other developers, I will send a new
> > > > version in this direction.
> > > 
> > > I see no problem simplifying it.
> > 
> > My guess is that we will eventually end up with something like this:
> > 
> > 	retries = ilog2(num_online_cpus()) / 2 + 1;
> 
> Good point! Initially when writing the patch, I did try to search if
> there is a 'ilog4' api :) as the ilog2 of that 8-socket machine is
> about 10, which is more than enough.

I am also not averse to starting with the above, either.  ;-)

							Thanx, Paul

> Thanks,
> Feng
> 
> > 
> > but I am not at all opposed to starting without the division by 2.
> > 
> > 							Thanx, Paul