Received-SPF: pass (google.com: domain of linux-kernel+bounces-73442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <dd1c1536-f36b-4615-97b7-7f6ea4b5e5a9@enpas.org>
Date: Wed, 21 Feb 2024 02:20:02 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] HID: nintendo: Don't fail on setting baud rate
Content-Language: en-US
To: "Daniel J . Ogorchock" <djogorchock@gmail.com>,
 Jiri Kosina <jikos@kernel.org>,
 Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240115145000.12777-1-max@enpas.org>
From: Max Staudt <max@enpas.org>
In-Reply-To: <20240115145000.12777-1-max@enpas.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Ping :)

Do you think this patch could be upstreamed to widen the controller support?


Thank you for looking at this!

Max


On 1/15/24 23:50, Max Staudt wrote:
> Some third-party controllers can't change the baud rate.
> 
> We can still use the gamepad as-is, so let's do that.
> 
> Signed-off-by: Max Staudt <max@enpas.org>
> ---
>   drivers/hid/hid-nintendo.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index 997c3a1adaca..8cba0612c3ae 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -2164,8 +2164,11 @@ static int joycon_init(struct hid_device *hdev)
>   		/* set baudrate for improved latency */
>   		ret = joycon_send_usb(ctlr, JC_USB_CMD_BAUDRATE_3M, HZ);
>   		if (ret) {
> +			/*
> +			 * We can function with the default baudrate.
> +			 * Provide a warning, and continue on.
> +			 */
>   			hid_err(hdev, "Failed to set baudrate; ret=%d\n", ret);
> -			goto out_unlock;
>   		}
>   		/* handshake */
>   		ret = joycon_send_usb(ctlr, JC_USB_CMD_HANDSHAKE, HZ);