Received-SPF: pass (google.com: domain of linux-kernel+bounces-73474-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 19:54:29 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
	linus.walleij@linaro.org, semen.protsenko@linaro.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI
 support
Message-ID: <ZdTnVUlsME7gtvrf@smile.fi.intel.com>
References: <20240219191359.18367-1-vassilisamir@gmail.com>
 <ZdSyljwOyxIY7Gvb@smile.fi.intel.com>
 <20240220174624.GA27576@vamoiridPC>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240220174624.GA27576@vamoiridPC>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Feb 20, 2024 at 06:46:24PM +0100, Vasileios Amoiridis wrote:
> On Tue, Feb 20, 2024 at 04:09:26PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 19, 2024 at 08:13:59PM +0100, Vasileios Amoiridis wrote:

..

> > >  #include <linux/spi/spi.h>
> > >  #include <linux/err.h>
> > >  #include <linux/regmap.h>
> > > +#include <linux/bits.h>
> > 
> > I see that it's unsorted, but try to squeeze a new header to the better place
> > where more will be kept sorted. With given context, it should go before all
> > others, but it might be even better location.
> 
> So you would suggest a re-ordering of the headers with a reverse
> christmas-tree?

No. Alphabetically.

-- 
With Best Regards,
Andy Shevchenko