Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1890380rdb; Tue, 20 Feb 2024 09:56:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXE/6aAIFs9ncGLJIv5noAzpDaA8YQdqYugIk3aIS9/EAPwlCUxGCDF1cMxKO5t4hhzd+b5gue/1LsxahxgkhMdL4ioMW2QxtVVoHYtgg== X-Google-Smtp-Source: AGHT+IGkF4SPZ3dFAMb15CrEqoRZMDyyRMNewvlVJQYg4Umb0pBLggOYQzeVGTp/Lw/K/MCcyg43 X-Received: by 2002:a17:903:24f:b0:1db:3a0d:1cf9 with SMTP id j15-20020a170903024f00b001db3a0d1cf9mr16592856plh.48.1708451775869; Tue, 20 Feb 2024 09:56:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708451775; cv=pass; d=google.com; s=arc-20160816; b=LfzEiT5bY7Uvpv7CfgrSqFEPM3EqDJS+IaPuwvzYA+8J36ReEYvTGO42uSNtNhMJKl iMGu9stf04NGHA3rPrWN/bdWPWOp/rDTRMjvoBr5i/4JyaGD9PYe9rt72XIiwlQaVJxB 4Ivy8JYW9bcBLqxa7cyAb/M2X+R0/GUGFi4HVC7GxdZANjB40kfMA5Og2Vxb3KeYeR7V WpIBHWFYT2wUINkCzM8qE5ftxeP10HTfZEn8XuKaz6Fo4XAGJDaqU5LkBz7EnQf/oZF9 twk4WRZQmMm0kyUtnMS1/tzPUJ8la9fbKMdIYn9eV4Fj694QErzC42KA/PLhlP8v+rzb WF2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:dkim-signature; bh=cs7a6JxSri8UPMBfIFAC6zzBgd9E4B30piovcQly+DY=; fh=NOOSpW4ytIvTzC62+/oOMx1c+krM/jy7L0+XRJmGte0=; b=wSUIV41PjvXbIEBtwxb6+WsWLoxZX2kubZT5qtQwhfsG2j2jqupSaPHV7RR61POn9E XmSYwGtfOvgTVFcqUz82xr8/Jpy4N4QTvId4jFbsgYWpcOJN9cLCV0+DeGs5BYC387Ew FxQLrPNxiw47W8VaRYDWyxVG/ixT8+aBn8OowYkaPK3fjP7twmtC5B2yWexFPWEAUShu ZvbZzwkqlrfmH4AmYpVsXweeqkEESBSW5LF1zlfZRPZN+iMpoXQObF7MS33TfMMgTPn2 yCf8R+w6jLgJYBv+h/++te1wl2MiXSvDutWqRuoIa6+D31TGEBYOvF1hcspz3zk5Ddll qzlA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Ab81jJE7; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-73476-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73476-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p7-20020a170903248700b001d92086fe43si6495903plw.436.2024.02.20.09.56.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 09:56:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73476-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=Ab81jJE7; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-73476-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73476-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44637281F9B for ; Tue, 20 Feb 2024 17:56:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DCDC7867B; Tue, 20 Feb 2024 17:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ab81jJE7" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE8177637 for ; Tue, 20 Feb 2024 17:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708451751; cv=none; b=dZuxcf/H2B1JOpY040gs2IXCIoX2NTbohU65irPWOKuPUc1BkPb6akI2JqjHAvfoR55FbweIsLvNm1PbLvmUgzqGeK1zrubZrH+ogWXB71nvoPzGDqD3rRyUN/+9IwwiqHscdjtka293hR6FELOzwnYlIcZCEFgEf4HLwRlqi0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708451751; c=relaxed/simple; bh=hqb1KpK8idTkVHw05D9DaOecFdA77V8n0hYYGqZ4o2Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Content-Type; b=qsUQN1CTyB76sfwuVnsClpyfwuq3bxvBdZAu2LMlbLLv1lH8sO7+je3eXjw3R3syBl502OcfdeRJhThz+IHbaJMagjB58082FMOl8caPHyXQ+4v3CWSFGcg8pR0yBOckCJl+zGqTv8YSETXlJqyiQD5YWmI0CCL2pTl0fvJYPY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Ab81jJE7; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-55a179f5fa1so7735350a12.0 for ; Tue, 20 Feb 2024 09:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1708451747; x=1709056547; darn=vger.kernel.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=cs7a6JxSri8UPMBfIFAC6zzBgd9E4B30piovcQly+DY=; b=Ab81jJE7kpciDnJ5EwJA/C9473hy/PJMieFJXVoELmOQlHN1kdZlXBvBYeg2yMEo52 g+epCK1CX+nDxaDfjoUwaKrsYvPUvFx4APPM2hylpTX4ZmOcQrSh+a49/xP4JllLSA48 zGk7z6o9SYtKONS0sKuhAc8IB/5+tLtazoVno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708451747; x=1709056547; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cs7a6JxSri8UPMBfIFAC6zzBgd9E4B30piovcQly+DY=; b=GCr1CVmMJHom9HMv6T8qHSiU8lwfvYTyWfeQr0AtnY1hFohKCt9xeqDPHuS1jf6Wt0 XUlyGoZsfrungLExZRAlzj2itnXGgBOq4b4rqdmA4c8z2VxPHhcfw5LaCxNU8CLwme57 +41kOGEWj0S3iq8iimQnhwRph+nrmPoFCRY9QWQ2CYcib/57a5QQaRHfQUBkEHp61m9q rzfCQipIjgT84jtN1+1207+p8rDdGZC62SjdUWN7By4ezzJa5e6o9Aeim7qLHNBuGP6Y 1cUv8M/HnSKPwKRhaTM8kv7uhCIwtkdb4EkpRITm/2pY9qUwmcmisG24FadhV5qsXBM3 IYpg== X-Forwarded-Encrypted: i=1; AJvYcCVjp2bsQiqQ7gfQV+vkESlixFC/IPSckn/Y06DN1FCSTAltok4+U1RH2MjpkF1zlLohaxBs1QkgPpLT5y3ho81dK82B7ze8AVV1x+3D X-Gm-Message-State: AOJu0YyB0LvRbB7iU4KQ33M7RgNekaQM9FyBy3xdogAI83uSR+Ly2bcy i36pgIG6+YPi4/4QIBtfOwixDf9auCvjGdLdARp3XLY4zpnnIBXxExSwe8RBj91e4wM0/E7OeE5 pxauNuw== X-Received: by 2002:aa7:d595:0:b0:564:405c:dfa with SMTP id r21-20020aa7d595000000b00564405c0dfamr6347428edq.17.1708451747689; Tue, 20 Feb 2024 09:55:47 -0800 (PST) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com. [209.85.208.44]) by smtp.gmail.com with ESMTPSA id e14-20020a50fb8e000000b00564e1b7754asm227238edq.31.2024.02.20.09.55.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 09:55:46 -0800 (PST) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-563e6131140so5488458a12.2 for ; Tue, 20 Feb 2024 09:55:46 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWQzHGE2+RfAjdSCg6xvybw1yJ20WkLqMaeBz4FJXGZXRaYZEDD2ZLmyjOj0WZ9ZI4xC8jabf84+ZnTJabMVGC8XsIdmEEm8b6iGEn2 X-Received: by 2002:aa7:d393:0:b0:564:3d68:55f5 with SMTP id x19-20020aa7d393000000b005643d6855f5mr5518556edq.5.1708451746591; Tue, 20 Feb 2024 09:55:46 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130091300.2968534-1-tj@kernel.org> <20240130091300.2968534-6-tj@kernel.org> In-Reply-To: From: Linus Torvalds Date: Tue, 20 Feb 2024 09:55:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/8] usb: core: hcd: Convert from tasklet to BH workqueue To: Tejun Heo , torvalds@linux-foundation.org, mpatocka@redhat.com, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, msnitzer@redhat.com, ignat@cloudflare.com, damien.lemoal@wdc.com, bob.liu@oracle.com, houtao1@huawei.com, peterz@infradead.org, mingo@kernel.org, netdev@vger.kernel.org, allen.lkml@gmail.com, kernel-team@meta.com, Greg Kroah-Hartman , Alan Stern , linux-usb@vger.kernel.org, mchehab@kernel.org Content-Type: text/plain; charset="UTF-8" On Tue, 20 Feb 2024 at 09:25, Davidlohr Bueso wrote: > > In the past this tasklet removal was held up by Mauro's device not properly > streaming - hopefully this no longer the case. Cc'ing. > > https://lore.kernel.org/all/20180216170450.yl5owfphuvltstnt@breakpoint.cc/ Oh, lovely - an actual use-case where the old tasklet code has known requirements. Mauro - the BH workqueue should provide the same kind of latency as the tasklets, and it would be good to validate early that yes, this workqueue conversion works well in practice. Since you have an actual real-life test-case, could you give it a try? You can find the work in git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git refs/heads/for-6.9-bh-conversions although it's possible that Tejun has a newer version in some other branch. Tejun - maybe point Mauro at something he can try out if you have updated the conversion since? Linus