Received-SPF: pass (google.com: domain of linux-kernel+bounces-73659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <20c93f08-b583-4cb1-98a1-86dd4313e693@ti.com>
Date: Tue, 20 Feb 2024 14:14:44 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/7] mmc: sdhci_am654: Update comments in
 sdhci_am654_set_clock
Content-Language: en-US
To: Adrian Hunter <adrian.hunter@intel.com>
CC: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ulf Hansson
	<ulf.hansson@linaro.org>
References: <20240207011520.3128382-1-jm@ti.com>
 <20240207011520.3128382-6-jm@ti.com>
 <d1247dbd-0672-443b-9719-3d6d52833c37@intel.com>
From: Judith Mendez <jm@ti.com>
In-Reply-To: <d1247dbd-0672-443b-9719-3d6d52833c37@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Adrian,

On 2/16/24 11:11 AM, Adrian Hunter wrote:
> On 7/02/24 03:15, Judith Mendez wrote:
>> The sdhci_am654_set_clock function is also used to enable
>> delay chain, therefore fix comments to be more generic in
>> case we are not enabling DLL.
>>
>> Fixes: fe52e2fbc6ef ("mmc: sdhci_am654: Fix conditions for enabling dll")
> 
> Similar to patch 4, Fixes tag is probably not warranted.

Will fix for V3, thanks.

> 
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   drivers/mmc/host/sdhci_am654.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 35ba7d921690..3755a015f328 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -279,7 +279,7 @@ static void sdhci_am654_set_clock(struct sdhci_host *host, unsigned int clock)
>>   
>>   	sdhci_set_clock(host, clock);
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
>> @@ -322,7 +322,7 @@ static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
>>   	u32 itap_del_ena;
>>   	u32 mask, val;
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
> 

~ Judith