Received-SPF: pass (google.com: domain of linux-kernel+bounces-73685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 20 Feb 2024 14:34:53 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC: Oded Gabbay <ogabbay@kernel.org>, Thomas =?utf-8?Q?Hellstr=C3=B6m?=
	<thomas.hellstrom@linux.intel.com>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, <kernel-janitors@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/guc: Remove usage of the deprecated
 ida_simple_xx() API
Message-ID: <pshjojhgguhevgor6p724fs4pnw4a5nyclwfqnk4pfbommxyrh@jfha3y5whlei>
References: <d6a9ec9dc426fca372eaa1423a83632bd743c5d9.1705244938.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <d6a9ec9dc426fca372eaa1423a83632bd743c5d9.1705244938.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qi76smMJU+Rr2pwY00XU1CLZb4wrZC3r7MMfuayGL8EU9YIKNHyTe0WLHQFS?=
 =?us-ascii?Q?KgbWKQluIRcuqgVTv4G0bFbG1PXPKEgQN9tr/jT8aPn3+UHGu/tD3ckRZ/bk?=
 =?us-ascii?Q?MFqGaM4H+LcfVwVh2nAUK51TEetzSy/YBij2BoVL95JoDrb4bI4yMAMrJrNp?=
 =?us-ascii?Q?LCHbTePcu4136KNYLloEQaH5ZYmP4U4V9VFktLFU12ph67zla5GG+0LZi2Xw?=
 =?us-ascii?Q?rAv/WiqrYU/9Vb4roo/TayXJhAI/R5xAOVunrrVi+Xwqk6TJ878kasBZ/Vx0?=
 =?us-ascii?Q?XCcrydtLsDTlIgDK3gItqXGfH7E3SwgRBfMF7EC22sUdFVAovx4d8KlapNLf?=
 =?us-ascii?Q?SQAiTADN5JvWMk/nAGk2y1fEv7IyfcYtOcwVuLWKxPGDhDvmzrMmrnAI/SXG?=
 =?us-ascii?Q?RDq2/elmOavcG+CVHG1bAXJBgYNAdgnuoiGaswOouBOzxhyZU0J+7QPI88cU?=
 =?us-ascii?Q?0a2YPfb8PHo5EPLZrES3SnkhKwPi4v26X/Z8kwadxSi1CHuN1hMdaFA+hqdq?=
 =?us-ascii?Q?vLM0zzV0li6BGgx+NkRT+rmc3AxwQDZQIhec9rbyLmhiXHTsUvWiyXpSK3VU?=
 =?us-ascii?Q?xhorBN8liwb9neQtqot+XsaHrSnNfNxNR5lU/9WN2N1bVPuDDE7GeuPnHkvs?=
 =?us-ascii?Q?ZmQFghBdaER0Q4XaFyn7kmcmfG6gklc92GL5pHtsmGqX/qvBbGNua4BhagRv?=
 =?us-ascii?Q?8ry1+uRzTuzXbESMi2JqZRA5kECUZTyIwMKgei5xdtEFup8SfqDZeySUyTYA?=
 =?us-ascii?Q?ZDj0oOeNeBHa9y2gu/TVkcMQTx2XKBbPFpUzGIgmLgO9xq7FMS3RrQf168VG?=
 =?us-ascii?Q?o991R978ScKJrSWsUnBJLmRjfrn7Bw6jHIbBX71mNQYcixwBfpQMa1Ksoa/Y?=
 =?us-ascii?Q?UT3FRuGNzaC2Iy0xTCSJckDO0sY8svM5ir+3IeuBCNA9W6ZQa++3rUruOChS?=
 =?us-ascii?Q?7mGK+T0HWxLnf/mtqOos+/qoi31o2WAAhfDjuOdahQ0O4f324vJRmYdYPqlh?=
 =?us-ascii?Q?RgN+dY5orYFiq9cmH4VHS3k8LNn3LDGspJMnL2iQ7GtXjcH4Eovw8mixMJZF?=
 =?us-ascii?Q?viQv3zEJGn64ZmKuyjLsg7LfZCYtkYKaMEBKbAER+/DoSoM/DBQH33ligJ0T?=
 =?us-ascii?Q?cGBqk7oEpvj5GSpYXf8id/RsUYr7qMvSWNK2htybkzlDtIPToY4/rrB0iQMK?=
 =?us-ascii?Q?3/2G7C0W91PAH1SpjH/lax1iD3eA8dRw7Ikk7cY/81e6It8jIUYGeMFLEgid?=
 =?us-ascii?Q?uErpvcamW7gBlsxZPBaqzt/rnvGNd4IaJzsV7acF/pyh94d99yQXqsGaWvCT?=
 =?us-ascii?Q?JTHUi67GWWIt1IRABLyqrA5C34Go7dsj23Zl6OdV3hcPWpRBXlrzRu1gfVnL?=
 =?us-ascii?Q?5x6H4qFgPUxj547y58EtnzX+CQB0hKZd9P1OKNsBxlzeJ++BdjhAp8f2Fb+m?=
 =?us-ascii?Q?Hb1zPNaL2Wtctkp4S4LwdFy3lgSRvak8SzATrYgs4quNOsAhk+LJQrf6PiHW?=
 =?us-ascii?Q?0UGk3ArjS1hIybyS1l+xj40UF0wbD1U7dzYi26rs9OJxJQ+fKE9U0jW6ihNp?=
 =?us-ascii?Q?xuXHtfk93yQeg5XfiDjTSkJIFLaTxG4sFA4WEwl5h0orgrpVEUj6OmcioJmV?=
 =?us-ascii?Q?Pw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dda0033e-f229-4416-98c3-08dc32536d3a
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 20:35:07.7467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oEYNk8L8L5cg+b0M4NCSIlan1LaYG5U5GMlDtZ+pabo1NcxvJgLG+1KC9l3yk82+KmE73Y3AimPzFQTFjVWRhN6S9B6ehNLpYTOSfr58C2o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7739
X-OriginatorOrg: intel.com

On Sun, Jan 14, 2024 at 04:09:16PM +0100, Christophe JAILLET wrote:
>ida_alloc() and ida_free() should be preferred to the deprecated
>ida_simple_get() and ida_simple_remove().
>
>Note that the upper limit of ida_simple_get() is exclusive, but the one of
>ida_alloc_max() is inclusive. So a -1 has been added when needed.
>
>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_guc_submit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
>index 21ac68e3246f..11ffacd1dd58 100644
>--- a/drivers/gpu/drm/xe/xe_guc_submit.c
>+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
>@@ -311,7 +311,7 @@ static void __release_guc_id(struct xe_guc *guc, struct xe_exec_queue *q, u32 xa
> 				      q->guc->id - GUC_ID_START_MLRC,
> 				      order_base_2(q->width));
> 	else
>-		ida_simple_remove(&guc->submission_state.guc_ids, q->guc->id);
>+		ida_free(&guc->submission_state.guc_ids, q->guc->id);
> }
>
> static int alloc_guc_id(struct xe_guc *guc, struct xe_exec_queue *q)
>@@ -335,8 +335,8 @@ static int alloc_guc_id(struct xe_guc *guc, struct xe_exec_queue *q)
> 		ret = bitmap_find_free_region(bitmap, GUC_ID_NUMBER_MLRC,
> 					      order_base_2(q->width));
> 	} else {
>-		ret = ida_simple_get(&guc->submission_state.guc_ids, 0,
>-				     GUC_ID_NUMBER_SLRC, GFP_NOWAIT);
>+		ret = ida_alloc_max(&guc->submission_state.guc_ids,
>+				    GUC_ID_NUMBER_SLRC - 1, GFP_NOWAIT);
> 	}
> 	if (ret < 0)
> 		return ret;
>-- 
>2.43.0
>