Received-SPF: pass (google.com: domain of linux-kernel+bounces-73697-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a52637c3-e5b8-4ef8-b9de-8c7dd0868630@intel.com>
Date: Tue, 20 Feb 2024 12:51:38 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 3/5] selftests/resctrl: Split
 validate_resctrl_feature_request()
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
 <79e6f4b5bcaf36214289e56167fe1d5657cb4d24.1708072203.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <79e6f4b5bcaf36214289e56167fe1d5657cb4d24.1708072203.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1ZISm40TnppSlJPRE9Yekl1Y01Jbi93MkxSUlYrb3A5TVg2VzVVRk1QemdL?=
 =?utf-8?B?R3JyQTVRWS9Ddlh0NWNCT2tKanMyYStsZVU3T0Q2T0NOeEJsU3Y0ZFB0QzBB?=
 =?utf-8?B?K2VKemMrTVpnWTYvS0FqSnNKK1NOK0Rzbis3S3lubmN1V1R1dkhjZ1dUQk02?=
 =?utf-8?B?YWhPSjAvZXFET0ZtS3ZDSnhSUmR1K1RpeWluVy9ISmsxWGRSa1htS2hraGEz?=
 =?utf-8?B?b094WjhNQ2hqRzFubEVkQlNPY2VMMDEwbnhUUTlkNDZGTy9MK2xzbm54d1N2?=
 =?utf-8?B?MnFBbGhDN0crSXVZOW5LTWJnNzYxTzYrYWtIbHhPcXVYdDNyQ0ZvWnpIZnEw?=
 =?utf-8?B?elRUZXVVRnQrSm13QW96WEt3OXR1aDVncWZoaWNMdWxJT0lORStKMkpZQ1Ix?=
 =?utf-8?B?bE4wZUJ6QkpMM1lkSXd0OXpDZ2VjRERKdHN5UzE0Y0pydmNGa0JrZDRBQjBU?=
 =?utf-8?B?Sk9rcndqdGVuTmMzdkVxVHB3MzlkVEwybUs0RHdNTG8wREFsbWt0RWNMZE9P?=
 =?utf-8?B?MER5NXBwNHJ0WXpXcGhWdlMrY3gxTE9WaHNqN2tLeXRRa25aYmlTOE9VQkZi?=
 =?utf-8?B?eG9lZjVlWnhqVmU2cUZvbTgyZWNWaHdYRExkYi9kZlRLd1F3SHFTcFMyVnhC?=
 =?utf-8?B?Y29Kay9DclNYNEcxS2xidVhQaXV4WEtZK1NsZ0JwdkFXSlc4YitBeHFCa0pi?=
 =?utf-8?B?T1dRQjZhWDNIRWRzdkxBSTl6MzE2VmY3bmJrODJkTUZkTFZ1SWRRMmd2cmha?=
 =?utf-8?B?U3EveFBpT1ROUnVIOGpSaUxBWFZIU01NenJHTmwrWVoxdVlVV3VOWUQ1SEdx?=
 =?utf-8?B?ZVNzYXdTYVpPZjd0cXRuWFljdGxNcEtDN0cxRGxUbC84MnU0THFVanRMdlpv?=
 =?utf-8?B?WC9VUXF4QnpCUEFYdHZxUzVuUSs5K1dKRldwQ3BHek8vNTM1S2tWWVJKcHkx?=
 =?utf-8?B?S1QrWHFVY25TQ2tKdXpONCtkMHQvalZHSGxaWnhvSi9SMGNUc0tPSnJFVlYw?=
 =?utf-8?B?eVZHR3RQU3VTNEdESXAyWDNqVnh6Wmx2TVlpWEtWdVNZcXZOL01Ec284ZFZB?=
 =?utf-8?B?MXFNTCtVVW1wTmQxRCtuUGFWVFNlNGNLZHFSbW9TWWVpTjFPUlVDTXVOaHh3?=
 =?utf-8?B?RjNEQW1tVllTa0x5R3lpNDV1QlN4d1REbFlNQnJqRUVEWFZlU0hOWkE5eEty?=
 =?utf-8?B?N1ZWclpVNEpIVnl1cnFidW5VRG81R0JVOUNvdm1aaVR4eW0wQXZhaUUvOEJ1?=
 =?utf-8?B?MjVxaHhmYW1wd2t6RHZXdXFLSFh5Rk44a3AvWFMzYlRWNC8rdXg5N2x3c1pR?=
 =?utf-8?B?U0NLQ01LRWRaZGprRS9FUGNVUnE1Ym90dVkwRjd4dkl5ZVN1WE1PVnlZUUp1?=
 =?utf-8?B?MjdkRDVQVWVjNGF0ZXdHSFlSSENQYjVQUXAxbTVMUFVseHZKZkJVYURsaGRm?=
 =?utf-8?B?djFNcWlXdVJaSG1lU045NGVpOXM2K0dEVzlOYzA1UUNlZ3g0TXVQZGQ0M3V0?=
 =?utf-8?B?eHd4c1NmUXVGRDVqTCtodkdxUVFLOHJISWE2LysySmF1TXV6OUdxcHlDT2VM?=
 =?utf-8?B?S084TlduLy84cFcvS09vY0dPeFJwZGFKSDRWRE5HL1NPNEJaOVRqMEczVVZ4?=
 =?utf-8?B?Vk1pMm5XV2gvRUJwREEyWURJUkxtVmdpT3dhWWc5NldKYnlMQmRmblowNFd3?=
 =?utf-8?B?RlduckFSMDI0K0ZvOEFCcWVneENxcldjYjkrcS9uSlVvOXN1VUs0REFWNHVH?=
 =?utf-8?B?ZFVzb3dtdlB2ekc2M2R2YStaRkdHb0U4SWxOUVQ4L0ZDUmR3L1NQaFdxMzBG?=
 =?utf-8?B?Sm1KT3J1czFBMGVqNGdubGNZaXB1b2RVcFNYYW81R2xxbXRveWMrUGxCTlVa?=
 =?utf-8?B?d1Uwc3pEL3RrTmpLbm5ldjVEbjl4NmpVOG9ZYWg3SzU3L2UwdGFuNEYzRXNN?=
 =?utf-8?B?WXBXOTA3VGcvM2RHbjhFZ1JlOFg1L21KZXRLNlVRYnVTd045cFAvUzVqQWFU?=
 =?utf-8?B?NkM4TC80cENzNnMwRWVtZ1U4b2hRUm9wVGlXem1pOEJaczZhWE4xM3FxalNw?=
 =?utf-8?B?ZmNieEFmdmU0THd2cUVYcmI2YlFrUklDc0p1VE1mSFBVZTRrU3poRE1vZlFC?=
 =?utf-8?B?UnpZSjBmb2xCZk1sYk9aTWZjMVU5SlVaSHp3cDRFNVRyVHcwREg2dTZNQU9C?=
 =?utf-8?B?TUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f3e33431-d47a-4a06-ea6d-08dc3255bcf6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 20:51:40.4952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: axo4cMhpj3qtorSFKYj4rAeonyQMaa3Epq4jsHLzXbsEEsbyZvDW7Vpr84WlMV9ub0tfvfSCGxHR1deZ8PPvHX/vphsUYBPbvQZdgyDO5Sk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5115
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/16/2024 12:35 AM, Maciej Wieczor-Retman wrote:
> validate_resctrl_feature_request() is used to test both if a resource is
> present in the info directory, and if a passed monitoring feature is
> present in the mon_features file.
> 
> Refactor validate_resctrl_feature_request() into two smaller functions
> that each accomplish one check to give feature checking more
> granularity:
> - Resource directory presence in the /sys/fs/resctrl/info directory.
> - Feature name presence in the /sys/fs/resctrl/info/<RESOURCE>/mon_features
>   file.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette