Received-SPF: pass (google.com: domain of linux-kernel+bounces-73700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <542aa1a5-85e1-4b09-8bf7-7027e45108a1@intel.com>
Date: Tue, 20 Feb 2024 12:52:07 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 4/5] selftests/resctrl: Add resource_info_file_exists()
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
 <c32b59c8826216a0841d8499038fcc2e965927be.1708072203.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c32b59c8826216a0841d8499038fcc2e965927be.1708072203.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2hTUitOV1VBRTdrYkdZcmVaTWRYZ3Q1WnZzUkNXcHVBYzhGRVhtN29Xdlho?=
 =?utf-8?B?U0x6c1QzZEZDbHNOaWNKbW53aGp6UVFjdklqZnZJMG5udTlvOFp4aHN4bExN?=
 =?utf-8?B?MlhOUTVPVWkvcmVaU0hueHgxalJuN3c1dHZidkRHazJhb3F2OVVGb3daTjM4?=
 =?utf-8?B?Sk1veDJGYVJ6dW45aVdlZVh1Y2ZibE92aS9zZnlCSm5HYXBOdzZMcWE0bmJN?=
 =?utf-8?B?QjlWR0srYUx3MTUyNkZvamk0d3NwcDZ0RWtscGMwOS81RUR0RS9IN2JWY3Zo?=
 =?utf-8?B?VEx2elBWMmtwSytSMWV1eUlxaDRMbGVMME43TU9sQjNFdjZqZkx2OGZoSVh3?=
 =?utf-8?B?SllvbW1EbTRVT3lyZmdwWG5uWmRDaHI5UmRoOXBDR1RJU2dyTlBDYnhvNzRo?=
 =?utf-8?B?NkJrTWlUb0ZuRllxS28yVTJnTldwaXRWcnpqUkFQT1hHY2RzK1FTa2drNnMr?=
 =?utf-8?B?NVRmOWlnT3E5akRCdmVON2N1U0l1djduUlQwUmZjS3VyMVFRSkZxMkhpT0hh?=
 =?utf-8?B?RFc3c0ZwMEhDYUIyRnd1NDAvQkRtTkJZTnNkQjBOMjJTcmhHeWV2R3ZIK245?=
 =?utf-8?B?REsxcTBNeFJ1d3M4RmJleTdHWUlQTUJwdHZjQ0RvL0JjTW1vOXFaRXZKME9l?=
 =?utf-8?B?SkZTejdvMC8rRkV5aWYrcFBBZGpWUnRZOElOaXhRVFhmZ3c0aEM4NWVoS0Vt?=
 =?utf-8?B?MlV3R29Kb3J4bjF0dDNwODcyVEF4N0sxOUlsZ3Zkb2NGWHRwQWdWMktVb3JN?=
 =?utf-8?B?T1F3eXpMeWU1Zkl3QmFJcWd0OS93NUVGY3ZaNUFqcmZhd2xWUnNvN2VMa1lw?=
 =?utf-8?B?T2NSbEpMNTQwZHlPMHRmNnRkNmRObXR5MU5NMkRRL3B5bElUU3FwQmlnbmU4?=
 =?utf-8?B?Qi9PRjM5RUJucDIrdUlRbWN6bmpWUDlWa1o0UjdHN0Rzc2xSc3p3NlVXVGY4?=
 =?utf-8?B?Z3lwN0F1QmhVcXBkK3BXQVIxQktsZVdkYkFPeTFYbWhpQks0Tk1tVkxtZGR2?=
 =?utf-8?B?dzExNUtWQnRzM0pHcmdoajAxRzBiZG83ZEw2TUpyQlkvSEs4SXhudE1KaHdB?=
 =?utf-8?B?aFFNN01zNEF0Qm1pY3M5bm8yTHFjanhsRmQvTjVWR1ZPVUUzMmptQ1lyWWtn?=
 =?utf-8?B?RnFOakozaDlNZFk4MHBIaWRYd210MWhpT082M211aFdXNTByQWdMN3RTd0Fq?=
 =?utf-8?B?YlA4OXErSmlOS1UramhDaWFSWjh5UXlyRzJ4NDdqdjB2di9KS0E0OVIwQ0xK?=
 =?utf-8?B?ZldSOThkV0lwVklBTFBsWDhtRFU0Zk5zeW9PejdqTjFIM1drVUdzcmp4Ukp2?=
 =?utf-8?B?TXF5Qk1UbWFHYTc0UnorN08rSVhsT3RmdG5xTmM2M1JUbWRxc1JRb0Y3Vkpr?=
 =?utf-8?B?RDRPSjFuWEhUUzhvdzJHbWw5WGlMMjdHYmRWQmRDbXhJWitDaXh5UjhWMjE4?=
 =?utf-8?B?Y2ZCUmwrNHVJSWU0Q2xNbys2TmdZRWZxTjV6U09MeHRlbUt5QUhKV0dHUUQr?=
 =?utf-8?B?WFdsYWsxZE9VT1hRekpjc3V6NWl6TXNZc0xXTTF6OEVIaVlNTWtCaEI2ZEZS?=
 =?utf-8?B?WFV1Z05tM25SZ29RRTYwTXJ5SUQ2QWxMYytWTENHcXZIZmJtam1yUTdneldH?=
 =?utf-8?B?Ymg4N0VlL2xCbFJ1ZkZZUmtabGtWb0hXTlRtY0Nrdlh3ZnNBQytRVVhFYVVk?=
 =?utf-8?B?NWVIUk8zb2pibHltMm5jZm9Wa1BVcG1uaVEzeVRLdE1TbUNZU1VYcGQralYx?=
 =?utf-8?B?MVlvUDlFem5BWUJYeHB3eGNldzY3dWU0Zk1uc1g5SjdCbTl1WlV5YjRVaFgw?=
 =?utf-8?B?K2N3T3lRRjJTL0xxZ2k2OVpkQXk4bllqNzhmVE8rb1VqNmJCZmpYM1p0aTcr?=
 =?utf-8?B?Mm8vdHlleHNEK1Y1T3ZaYXRtdGJnYmhyZmJXbFZDWm00VzJwRmtNY0trR2Zt?=
 =?utf-8?B?NUdKVkw4R2dYN0FXaW1LMUphdmY5d1U3QzVTNURCU2IyR0JiL3lSYWIwVldQ?=
 =?utf-8?B?MDRhRjRQN2tRMHBNK2I5RDR5WThWNnpqRjZjdnZjTzdGNTVCWk9XVG84Ylh4?=
 =?utf-8?B?R3ROQ1FQMzkrWUwzd011UkVaMFlyd1R3Y0s4TUI0b1FRbmFrQ1A2d3p2d0cw?=
 =?utf-8?B?cElCc1UzeVBnWEQ2aWxPbTNvaTgrVmFzdGcwUVRkaXdtSThrVXVwMlZPSTFJ?=
 =?utf-8?B?aGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4c641df-1ef1-4b4a-fe81-08dc3255cd92
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 20:52:08.3531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rOs3ay0lceuvaOEz43XZDsaar7tkiQxZVL4XlVxDLraJ1P98zJxoePXUFbhveBe7LfPjDDy/zAPfD3sk4yltCVGn9SAK1pZ4N1iFCJZ0RE4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5115
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/16/2024 12:35 AM, Maciej Wieczor-Retman wrote:
> Feature checking done by resctrl_mon_feature_exists() covers features
> represented by the feature name presence inside the 'mon_features' file
> in /sys/fs/resctrl/info/L3_MON directory. There exists a different way
> to represent feature support and that is by the presence of 0 or 1 in a
> single file in the info/resource directory. In this case the filename
> represents what feature support is being indicated.
> 
> Add a generic function to check file presence in the
> /sys/fs/resctrl/info/<RESOURCE> directory.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinettte