Received-SPF: pass (google.com: domain of linux-kernel+bounces-73724-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 16:24:09 -0500
From: Frank Li <Frank.li@nxp.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Niklas Cassel <cassel@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	bhelgaas@google.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org,
	hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support
Message-ID: <ZdUYeYI4UJ4ApV2X@lizhi-Precision-Tower-5810>
References: <20240205173335.1120469-1-Frank.Li@nxp.com>
 <ZdNvsdao8jbB/52L@lizhi-Precision-Tower-5810>
 <20240219161208.GE3281@thinkpad>
 <ZdN/OyNpw0Xa7qXG@lizhi-Precision-Tower-5810>
 <ZdR2FRQ9Fe8hhK9I@x1-carbon>
 <ZdR6EUOv6hzLEmUa@lpieralisi>
 <ZdTRiB9JdQSvBwKn@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdTRiB9JdQSvBwKn@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Rrm2Tf/2QPqEptH14xNJMS/QxM081qUFRtkzg07dHuHW2LOpjZrnO0tbRWd6?=
 =?us-ascii?Q?6FzB49/U3ELHIV/UMtTZEQbJjuFnV8TxigUbtqV/km4rhMg6fX6dGFrhBBJ4?=
 =?us-ascii?Q?xBKCDwK0yLEqjYyyDOqHJQq14YmNykoSTtn/VJyM31mWaaTYffHkahtbw54L?=
 =?us-ascii?Q?/PgywBsO3IOwygoycumz5IpqCCJSQFCVFbGt+8B/TqjgSAXnI/bbfx8/VrB6?=
 =?us-ascii?Q?7tzM/id8NcWYXW0TzH90bLCb8D5OGXo+JuCLChWdMQ3b41oiWYAH0zWKW4kT?=
 =?us-ascii?Q?j4AbCysvd8ohpSZzlcWQ072bkbdXa0UAT/lary7RGVsL7KZGNU4iBxwtWUun?=
 =?us-ascii?Q?qDJUAHZiyo8rDbgfTPxQe/Go9ArY6TdE+A3jKth24AKoYTUjWHdgyfiTHwEl?=
 =?us-ascii?Q?npr7a3jzQ/0enkYQQvStiuzm/afTUxdiJpdNgNbuc3GrPzyUCAzhL6dKU+15?=
 =?us-ascii?Q?E8m2hTs+YVzs4j/qYIap8Hjy9mXPWiJtsCR9QY+YxtIkb9cM/ARkGIDHJepW?=
 =?us-ascii?Q?0kHHVmke+Y+Jaqh1VBC30gZUrPb1QzstZ+Ssc8cvWcNIqGSF5/lKlrVVLCAX?=
 =?us-ascii?Q?foyO5/fEz9jQUiHQM7AajgqglW1sTnfOeWvrqQUTC3OOd13+jIJJz1rgai5W?=
 =?us-ascii?Q?nB2oMV8X1ECA8o7rxUxFjdNnMJgWn0w6sV9w+EG+U0pmeSRY7h8LFrRsCP+S?=
 =?us-ascii?Q?FmHL/EIm1acRHt1+K3D6GKO7yyzQEYI/eURVonQ7v5l1NC/j5tQFYl1tBqWF?=
 =?us-ascii?Q?PQKEqGRLemeb2ikcIsNzXdMfHS8eDOIxJBbGH5K/snDN+JMNOQRIugcGEcNt?=
 =?us-ascii?Q?yNv/M3xOWd4SLt9Aqw1dGiybIaHubIqIITFWb+hbPnMHzRy7G+DiOvoDzo4y?=
 =?us-ascii?Q?1+L4hoQG1RI4eNin31SrWZqBLPhKrQVLxizyAFYRvHtFAX08ihSmI1r49N0O?=
 =?us-ascii?Q?BL0+Nj6FmU/arTLpEPfFq7gsXbcCX/Iu1sYekhJNp6dbkitubYwQ34NKUfz9?=
 =?us-ascii?Q?hERfhc1C0Z8frLXGxhMSBThS0lXrcdPv5xW/HYv6AE/Pr9Xz0nu6Khf8nE0e?=
 =?us-ascii?Q?Od8AFBYstujXNmu2QGKi+cAegx7c5h4HRVrC6ZUlFRS5SCdwsECE+A/ijPOL?=
 =?us-ascii?Q?8v9x0fku5++y63FFtpFO1ueM1H5rcFlCyWuJqPNq4NitTc6xtqB5acdkb0bV?=
 =?us-ascii?Q?h79XlasBNJed6TKyM/oAdHOAsrULNWxDJm67XDEKzu4GuMELryGgwZa6Wtfh?=
 =?us-ascii?Q?8/H7oiU/jWeTpMeGyqsyzIEMmiJlxsVnZ5/eCNxxH2ROJ9qQn6y2cXgViR+2?=
 =?us-ascii?Q?trela0sWvmHq5zLxqcWLCq/vwiJOXkJC81t/bSzVxEmo/jm70aZ+t9R5joIR?=
 =?us-ascii?Q?hEh13OG/iK8OunK0voyxQbdKBqroiNQFxYazClALmPpt5hefC61PJC8oQqi9?=
 =?us-ascii?Q?TzxKy1lT4He6OAn8HBeYLS4nvuYxUQEqeUCykbjqBjlY74KVk8AgUM6e2Nbm?=
 =?us-ascii?Q?r//ErMtjsLSr697tg3Hr5Pf9T9VTmPdLLbhfW9K+7/3uL7zQsJT9XHuwV8T6?=
 =?us-ascii?Q?ohD0ZKvcAVNzCKsb2ISvv3pbWR9aWs4Wg6XjnrNF?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 511637ae-8672-4c3a-219b-08dc325a4c7b
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 21:24:19.2925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +/5TQWZIi/f8X2A+JVPWh5yFYNYj1ia+EHGe5uuzyF+CAdWzFowlDWQb4lP7/XI3BSiricaiBzWisxaJHGmMLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7786

On Tue, Feb 20, 2024 at 11:21:28AM -0500, Frank Li wrote:
> On Tue, Feb 20, 2024 at 11:08:17AM +0100, Lorenzo Pieralisi wrote:
> > On Tue, Feb 20, 2024 at 10:51:17AM +0100, Niklas Cassel wrote:
> > > On Mon, Feb 19, 2024 at 11:18:03AM -0500, Frank Li wrote:
> > > > On Mon, Feb 19, 2024 at 09:42:08PM +0530, Manivannan Sadhasivam wrote:
> > > > > On Mon, Feb 19, 2024 at 10:11:45AM -0500, Frank Li wrote:
> > > > > > On Mon, Feb 05, 2024 at 12:33:21PM -0500, Frank Li wrote:
> > > > > > > first 6 patches use drvdata: flags to simplify some switch-case code.
> > > > > > > Improve maintaince and easy to read code.
> > > > > > > 
> > > > > > 
> > > > > > @Lorenzo Pieralisi:
> > > > > > 
> > > > > > 	Do you have chance to look other patches?
> > > > > > 	Mani's apply EP side change. 
> > > > > 
> > > > > Even though the controller is for the endpoint, it is still a controller
> > > > > driver. So all the patches should go through Lorenzo.
> > > > > 
> > > > > I only merge patches under drivers/pci/endpoint. Hope this clarifies.
> > > > 
> > > > Sorry. It confused everyone. My means was that Mani applied Niklas Cassel's
> > > > patches, which cause my 14th patch build failure.
> > > 
> > > Hello Frank,
> > > 
> > > Patch 14, which adds this:
> > > 
> > > +static const struct pci_epc_features imx95_pcie_epc_features = {
> > > +       .msi_capable = true,
> > > +       .bar_fixed_size[1] = SZ_64K,
> > > +       .align = SZ_4K,
> > > +};
> > > 
> > > 
> > > Should, after rebasing on Mani's pci/endpoint branch, instead look like this:
> > > 
> > > +static const struct pci_epc_features imx95_pcie_epc_features = {
> > > +       .msi_capable = true,
> > > +       .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_64K, },
> > > +       .align = SZ_4K,
> > > +};
> > > 
> > > 
> > > > 
> > > > I asked if I need update my 14th patch or applied 1-13 only. 
> > > 
> > > I see, you want the maintainers to apply 1-13, and simply drop patch 14
> > > instead of you sending out a rebased series.
> > > 
> > > I assume that the maintainers will be fine with your suggested approach.
> > 
> > If patch 14 has no dependencies on 1-13 yes; if it does we need to
> > coordinate the merge between branches in the PCI tree.
> 
> Keep it easy. I rebase to linux-pci/endpoint and v11 patch sent out.
> https://lore.kernel.org/imx/20240220161924.3871774-1-Frank.Li@nxp.com/T/#t

Bjorn just merge endpoint to next. v11 will work with linux-pci/next.

Frank

> 
> Frank
> 
> > 
> > Lorenzo