Received-SPF: pass (google.com: domain of linux-kernel+bounces-73767-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 21 Feb 2024 00:37:06 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: zachary.goldstein@concurrent-rt.com, Shawn Guo <shawnguo@kernel.org>,
	Madalin Bucur <madalin.bucur@nxp.com>, Li Yang <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] arm64: ls1046ardb: Replace XGMII with 10GBASE-R phy mode
Message-ID: <20240220223706.o7wc5r57omkmgtgh@skbuf>
References: <20240220145037.kf3avnykjif24kkr@skbuf>
 <191b4477-7b4b-47eb-bb3e-0e4d08b3b32e@seco.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <191b4477-7b4b-47eb-bb3e-0e4d08b3b32e@seco.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?us-ascii?Q?NNpbrND+dpEhINGVdaoDPnR534Frk9H3om0BYH99bZ2tuL7ByYs746UkOH96?=
 =?us-ascii?Q?jdDRFZ0h6oQPy7wvZxGWHthoqNe3rYirkbGwaHj0Eiy0bCmS/t9CZwcLDwCd?=
 =?us-ascii?Q?wQ2cHAOG4uOWrJKvYZLmQbJ3PbM8XQYer/3WSeWfei4X1oWnKP3uesE3pdEw?=
 =?us-ascii?Q?jmIquR11ukE3+oCuV8wf5+mdPZDSKDw4YB+wFRRN5t5vd6F7XTuylDsWK4tN?=
 =?us-ascii?Q?glr2J4CYRwQ0k+vZ3MqL6hyguOqltTKZFogJXzwA5u1uYEWSsaCfvQrbbLBJ?=
 =?us-ascii?Q?if1dNFVdk4UGvJKxKbwkL4fon/eNHt2+jDv9tGapSJjOGqAcYwQG/329F80V?=
 =?us-ascii?Q?a1YIB0BTx5fWBbdYzF/KpvBx9x3epTZsI8GfHCUU3QP32OT90FLv7ovkRCHb?=
 =?us-ascii?Q?veIPLSIfLWp0YSj4uDInexshxJ6y7exw1q+dhm28g+onjPyEAUzfaO6MGkB9?=
 =?us-ascii?Q?5YS+ZJzxEnLarNPxzAbKbBPOjgr26kM6V86ET/UrFx1BeLPj0QT2QlbE6C7N?=
 =?us-ascii?Q?kNkMaZC1Y2+4gq4Y1k90mDf9F5gE7+M/9U0OIybxAt3V7fLq5Iugi4YjMEu3?=
 =?us-ascii?Q?3Z0BYFO+fT4qDFs/v0/+LHVx3gTe2hrmscdurke8F0v4PHbesOrSz9yi6FqC?=
 =?us-ascii?Q?M8SG9rePowjobu1UrNBrSt3l2urFA3ci+e+vSimTGbNU2Dc3WETFrtdhz221?=
 =?us-ascii?Q?0Dpacog/OMyVQmKUToEypfUgFgxcafxzBDZIqPonWetd6juiFNJlXIsMA3vB?=
 =?us-ascii?Q?I6JPjxixLXc69uUQ/bpg8m0jzA2fIWZ/NvCnE6GufJvhxxgzAE2UpGk86LYE?=
 =?us-ascii?Q?MkEevX2GHBWQv5978/5eBOmiplti0y5Z5+JO5MUo79N1FEyrKpTtC4Rncpcd?=
 =?us-ascii?Q?WuqGT6bd671qdGJMJg5GMpSMj6/hTH7GdH07nXqntRs8OPq5u60PKodfJV8m?=
 =?us-ascii?Q?N7FPjhPxOxbUK0jgugo9iBYRlR8futyDbyItcBbW/8a7WExVJOgi5F0CB2xR?=
 =?us-ascii?Q?v16G5C8Yp4KEtxXKgPUvKIZ3+cSdsLznAvd65f8NOsupm1U54d4Pu+/48I6x?=
 =?us-ascii?Q?67DZH0ugCSfYRsyeuY0/sg1Zo23Xprltynkdwj/uws0lSsNLxRmS/wWz1NJi?=
 =?us-ascii?Q?BckPmLTP7q1soyaMjSSqKF3DTwadFYLx/blcsmGCRlnbPnEPJtWr18Z3v4Ht?=
 =?us-ascii?Q?Iv5fw9QnM/4oXhWRZSim3jhe77f0FVWDvZpCKdv4ssXkIRoShEm6md+hn31B?=
 =?us-ascii?Q?/vZpeCXq+LadvFTiTC7E3cbXhtgzUqW72CMpY3l0PqM6pZDL6OkwtKg9L6DU?=
 =?us-ascii?Q?Vm3cdKs2DC608M8QHfhuldJhPWbyGGpWfiTVPSiwsiHbjhboyf8CtPYT089I?=
 =?us-ascii?Q?uHBWV4XsTjEy4JTqT6JMLiz51TalyPfmroeRYmUXnO077etJJnj47a97wlNB?=
 =?us-ascii?Q?mzc6jcwi+n/9br3GUCFH36vDZRgHk5kaGqDRnN/fFcZ+l4TUeNo2gyRyDB3C?=
 =?us-ascii?Q?lG9WPzPHWii9/jbdLsKl6BJSen69Ssucj2725Q2M98z5HAVfOnCQqC9W7Vpv?=
 =?us-ascii?Q?6zjA8ULwq5Zqu/1NAZZJYPRE0lCTQbU+gvvyT/W9F48/gD+0jHezdeQQwsr9?=
 =?us-ascii?Q?ShoiUhSnexqO0+4fiXQsxZU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b11cccf0-252f-4c42-0a9e-08dc32647a4f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 22:37:11.1907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0YtLN8ZZToXAbbTZPpkVaq8VAFL3F2GQ8vzFqw5SSniqC0v0g1krOH/zHYPaLkPuQvtlIPAogJ8GdftK11o6cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9639

On Tue, Feb 20, 2024 at 02:12:52PM -0500, Sean Anderson wrote:
> On 2/20/24 09:50, Vladimir Oltean wrote:
> > Notice that unlike fm1-mac10 (node "ethernet@f2000"), there is no
> > pcs-handle-names property (fm1-mac10 has it defined in fsl-ls1046-post.dtsi,
> > whereas fm1-mac9 doesn't. Don't ask me why, I don't know....)
> 
> I think this is just because this ethernet is always XFI and never (Q)SGMII.

Is that so? With SerDes protocol 0x3333, won't the PCS that's connected
to fm1-mac9 use SGMII/1000BASE-X (thus not 10GBASE-R)?

And as for QSGMII, what's the relevance of that? You can't have one
device tree good for all SerDes protocols and RCW pinmuxing options.
Either there are 4 MACs aggregated onto a single lane, or there is one
MAC per lane, but I've never encountered any use case for alternating
between these 2 configurations at runtime, or with same device tree for
that matter, have you? QSGMII seems to have been the original motivation
for listing all possible PCSes of a MAC in pcs-handle-names, but again, why?

> Can you please submit this patch? I noticed this but never had the chance to go
> back and debug it.

https://lore.kernel.org/netdev/20240220223442.1275946-1-vladimir.oltean@nxp.com/