Received-SPF: pass (google.com: domain of linux-kernel+bounces-73768-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <20240213055554.1802415-6-ankur.a.arora@oracle.com> <87sf1o8oh2.ffs@tglx>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
        torvalds@linux-foundation.org, paulmck@kernel.org,
        akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
        mgorman@suse.de, jpoimboe@kernel.org, mark.rutland@arm.com,
        jgross@suse.com, andrew.cooper3@citrix.com, bristot@kernel.org,
        mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
        glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
        mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Ankur Arora
 <ankur.a.arora@oracle.com>
Subject: Re: [PATCH 05/30] sched: *_tsk_need_resched() now takes resched_t
 as param
In-reply-to: <87sf1o8oh2.ffs@tglx>
Date: Tue, 20 Feb 2024 14:37:01 -0800
Message-ID: <87msruiwz6.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?59YAoOGI2SaQrGiF2mDmUxHfOPaFFX9Eo4ogbjDnrssLHj65mWn9Zc9CukDu?=
 =?us-ascii?Q?EjItTdNNel4QSQl8DJcHyXCaXVH61LyycCkEImycdx45cNw8yknl0DiNqESu?=
 =?us-ascii?Q?GAnSGoWejSF0v7BfTIIilzGajDFKw8aAf4Xd8cLBGZ7cJLg+No5dRT6BCnBA?=
 =?us-ascii?Q?WDsZnJ52G/TXlvT3qeM/gKmKTfHlL86RdPtmPhLxC+NyarRxqQ6hLhumn/20?=
 =?us-ascii?Q?Hw4s0Amziy5G+08XvTSWYAo5WjMSBupJ4GjQS6g6Y1DPtMzdMMmUaTNy4gSj?=
 =?us-ascii?Q?UDTRsEYRmHEaXgWgThG7gb8adm0ewrkGApKb3LMyZXvv9K1ck7R3m4Jt9xLd?=
 =?us-ascii?Q?QT39sum60uVMQI44Zxbulcfv2HBe1ZTKK8+5r+v9nyMdXOoi8Nx3WeYAO1kK?=
 =?us-ascii?Q?Qfr9QuBCNggcO4t31GKWx35PUldNe6zC4d0Qy3ZV1QgS3lxp8jI1I7Ewg5kI?=
 =?us-ascii?Q?2LbbIJ/r7LPcu9YRZOxy92QcIxvSw9z1zufV9yzqSKLPUJChEHvqtGjym8Xf?=
 =?us-ascii?Q?JwPrx6gDqiuuRvkAkSqkGOFUPNNUTo5w9r0FAe6hJETHLE1wJx3KPvhhaZe3?=
 =?us-ascii?Q?89EU85JrR0PLBhQ2kbOqg14LghNRJhkbE24M6xzh7+tRg+kGemNDnuZRRzHV?=
 =?us-ascii?Q?SFBq6gB2zA/6DDpQEzkg5Vq9dN1ny/PFiO0BuwnZWcrZNQ8bpmJa3imIdK56?=
 =?us-ascii?Q?0hKa4NYwICssYi3iZfm0vYSj+J4peAd5aDrtVdaHTRtlpVe28j7TAmVNB5js?=
 =?us-ascii?Q?WY7tVjVnduJK0W72FTmA6CvVsIfm/vltXOxIfRWgi/+k0dL8WDPTk6EFs5Pj?=
 =?us-ascii?Q?Xu3VDI2FT1G2ZAncfQEbAVw77qqs8MIN6mOukb5inJjjAgJqX90yrfFl7pU0?=
 =?us-ascii?Q?fEUpdsjNt3/Lqro6CtEs4NjYYkMbdCfdlTI5482CU3u9sGGE+9oTesu8Un2t?=
 =?us-ascii?Q?RPM5NztFCdN1z7BX4bnq868RfJuBTivvj9ISzimCSzS9MospLNtLLufA3MJi?=
 =?us-ascii?Q?kY/GsA4ShgBl/h4eqm/gkDEsu4INcsSHRP/Qnzg8f3bn5vrfSJ4cMMWoCiY7?=
 =?us-ascii?Q?IIYcABTsvsy8la4M3qoux8mlAJPx45JpQVV8jaRlT8kxm54AASGfm7xpQVlP?=
 =?us-ascii?Q?Oqp7PLn7B1k1CYTImzaCekI9oz3sOXQIgXwf0LEtsTbBP+u4jrYEQFuwjVa3?=
 =?us-ascii?Q?mS0pnWe/ZBSVrilb8lXwWDvGZ53seG2RmV45jKUbZIE0YpoNZ8FGwrVe0Os5?=
 =?us-ascii?Q?NNKTeetu68G8x779btMmzVCkWCjDxBW3gYoS/tV2rYqW37OTyG6JAykQa25w?=
 =?us-ascii?Q?ejnzpK4FVoCFiO28GL/5lz9UThr1Tb4s6+4qt/1/QboNQOBT1M5ixLFveaMb?=
 =?us-ascii?Q?JaaZJ1PxXfR0a+E4BtuieagmP0wml/PdI67fhvZSXJPjIag25L1x0e7pYwRv?=
 =?us-ascii?Q?avVkkvK1ApYzNMxQQu7L9vvmFXxSBtoskWkWOBf3Nt7p9oUkvas05HO2fp/o?=
 =?us-ascii?Q?imtf1BUFYESWE9yodQph0LttmOAq9CiK3HfNl+82xHSi6TmRX0QEpAPjel71?=
 =?us-ascii?Q?mN95/UtyQp5hFG1OnOgoiIJixNChyjnCpEnPShPuAKi6OOUEeBka5tt43cYl?=
 =?us-ascii?Q?9Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	6IFWzv+3z0wvVWIrH7QVLJzo+JHQ5oif7M3yYciihw2ktpdI9uEmJ0yEiw6Z7Jbpdq8UtymBHOdUxSogxrqa2GjkYd+XywP1PTiJfoykeUX5mwMhMi5wtLMcPXOdougwRnTozoEnwwRwIRn7MtnnolrYSXaklsqIuSDzeMbymO7UPcdSuLnaKCwNHbuUJowmPmslosHipQow+MXdq9AyDFQhBXs/h8Y8BvU1ePPTvKcvNjwP9qZUNqP92w8Ds9o1UcfYLd3LEiDwTA9v7F2ePJyK2/M0nuNcTdUVSJFPHHdY/4W26yQC4BXD3d/EBB+R+EQtAB0AKldQsbQ+4jMyAlrcfqi91u0hKaYdvVNTbom6yHgob5zWyA85A1nJR88a8vBBaI4v4ngpnJhGjy1mAqUK+Sl300eRM//SeRLXc1jdAiiQ8bFpkXjfOnoLMCtMMGNZohFuHrQbvuFaQRJ0OTsq5sOT6cVDA1RIxOv21CMW2n4ECO5UjYzn2NUvndb/LN8u64PUWSEh2XlLb2RA6gWYMzouYvliQPIMrO79TMQK20yZ1/gXgig19IvJU7kSZHFMGL0zglyZshnyYjqnI6ItLbprc3fhjZq3V/s0QOw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af2218b9-a349-4208-1c44-08dc32646736
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 22:36:39.0492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IQThiBL+55LQXMutO/iDyMdC4ctae12S/Edcdb9KIwTb9nwno6d+2ELWNvqalhhZ02EsxgrEozEvjzgo0iHZOP5bGQv3OtEjh3i6Zq+wOlQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6256
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402200163
X-Proofpoint-GUID: SY7nP2woB9r7SdicG5HC7JC8ZkPNL3yC
X-Proofpoint-ORIG-GUID: SY7nP2woB9r7SdicG5HC7JC8ZkPNL3yC


Thomas Gleixner <tglx@linutronix.de> writes:

> On Mon, Feb 12 2024 at 21:55, Ankur Arora wrote:
>
> The subject line reads odd...
>
>> -static inline bool test_tsk_need_resched(struct task_struct *tsk)
>> +static inline bool test_tsk_need_resched(struct task_struct *tsk, resched_t rs)
>>  {
>> -	return unlikely(test_tsk_thread_flag(tsk,TIF_NEED_RESCHED));
>> +	if (IS_ENABLED(CONFIG_PREEMPT_AUTO) || rs == NR_now)
>> +		return unlikely(test_tsk_thread_flag(tsk, tif_resched(rs)));
>> +	else
>> +		return false;
>>  }
>
> Same like the others. This wants wrappers with now/lazy.

So, when working on the scheduler changes, I found the simplest
implementation was to define a function that takes into account
current preemption mode, checks for idle, tick etc and returns
the rescheduling policy, which __resched_curr() carries out.

So, it would be useful to just pass the resched_t as a parameter
instead of having now/lazy wrappers.

That said, as I mention in the other thread, the current primitives
are unnecessarily noisy because everyone needs to use it.

   -static inline bool test_tsk_need_resched(struct task_struct *tsk, resched_t rs)
   +static inline bool __test_tsk_need_resched(struct task_struct *tsk, resched_t rs)
   {
           if (IS_ENABLED(CONFIG_PREEMPT_AUTO) || rs == NR_now)
                   return unlikely(test_tsk_thread_flag(tsk, tif_resched(rs)));
   @@ -1980,6 +1985,11 @@ static inline bool test_tsk_need_resched(struct task_struct *tsk, resched_t rs)
                   return false;
   }

   +static inline bool test_tsk_need_resched(struct task_struct *tsk)
   +{
   +	return __test_tsk_need_resched(tsk, NR_now);
   +}
   +

How about something like this (and similar elsewhere)?

>>  /*
>> @@ -2104,7 +2121,8 @@ static __always_inline bool need_resched(void)
>>
>>  static __always_inline bool need_resched_lazy(void)
>>  {
>> -	return unlikely(tif_need_resched(NR_lazy));
>> +	return IS_ENABLED(CONFIG_PREEMPT_AUTO) &&
>> +		unlikely(tif_need_resched(NR_lazy));
>
> Shouldn't this be folded into the patch which adds need_resched_lazy()?

I think I had messed up a rebase. Will fix.

Thanks

--
ankur