Received-SPF: pass (google.com: domain of linux-kernel+bounces-73782-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <20240213055554.1802415-3-ankur.a.arora@oracle.com> <871q98a3h2.ffs@tglx>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
        torvalds@linux-foundation.org, paulmck@kernel.org,
        akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
        mgorman@suse.de, jpoimboe@kernel.org, mark.rutland@arm.com,
        jgross@suse.com, andrew.cooper3@citrix.com, bristot@kernel.org,
        mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
        glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
        mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Ankur Arora
 <ankur.a.arora@oracle.com>
Subject: Re: [PATCH 02/30] thread_info: selector for TIF_NEED_RESCHED[_LAZY]
In-reply-to: <871q98a3h2.ffs@tglx>
Date: Tue, 20 Feb 2024 14:50:18 -0800
Message-ID: <87ttm2hhsl.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?+ksjBZNSuBGH2Ks1t1FlZMiwW34UzTdES2ZXuKJJyPfMFNWIc+D+1oFArYLQ?=
 =?us-ascii?Q?5Q7cuzhu3SI26Nquk3CoUEH7lnEKOMaO8kseGGyYsqK+1z7dS8ZdyXP5wDpi?=
 =?us-ascii?Q?xOR65MoRw6D2BFEJ+JJZUS8KaUwErkMrMjslixEx1lwD4x+vdKpd1O7vkuWa?=
 =?us-ascii?Q?dHdFXxUVmZPESMfTqOfFs7+klTqwYYdwqp9Q1MZIL0RK/QESwsF6txFkp9D7?=
 =?us-ascii?Q?Krn05fBEwKygfPKiF+R9Spoj91XK3MN2rL4HYe1z1okv4OdJBsOkt3FR7TvG?=
 =?us-ascii?Q?WhvxYuXghLfcS5AaHMQLWeF+NjTphc8TTtMoGdeMcDvoHaIRvOskTrxjByRY?=
 =?us-ascii?Q?L0eHN2WR3BfRkxbtnNNjpmzm5P3akNm0SGi2I9Pxm9qLvSg2DikwU2pyEOYJ?=
 =?us-ascii?Q?nYz+ZVTsncyEDnyMpMSDJRweMB8VBwwFHckGwN6gn6S4jX+51PUHZwVG7wxL?=
 =?us-ascii?Q?SLkX+baB2I3gnJvdka7GybwbUNtlTU4+b6Ss8VbF0+cn9BwrytYBVuMuEpX9?=
 =?us-ascii?Q?2NLitcJ8gzTRFbzhFLLQKvuzVVwnPPwAxBJlLDCS3z8CBcExSXYpjf1zyRKg?=
 =?us-ascii?Q?U3EVu1jlfZ/2hWGLv1ZjybiXqIw+n+tKrEURqZg7kzI2lcnSIYysNfbxQy21?=
 =?us-ascii?Q?q9KI7ka1L+c4khs5CHU4vBdNzfFpQ3MkXk7dIGe17jm0T6Cwm1w9da4+G8lv?=
 =?us-ascii?Q?mEA7loK7uWu3Dj3yeQ5YPc0tyuxyYfMM6vRzvZFflaWcZFjc8hgmaD+csiiw?=
 =?us-ascii?Q?UUNFkkPUZJmM/PEabVrdHy+wMoba01a50AYbDeB7Q/5q2ETFDsJjbLiY8DiK?=
 =?us-ascii?Q?j0HwZ/Zl529P9WzNRTuiUnOaE7qjmUsVMiQTRkPQlWh0UluQzDKcC7EPvZMw?=
 =?us-ascii?Q?tSO6/6w9rODH6PKI56U0M8VI9fzD4YtePQrodjA6ZNW2OrwgV7C3TcXQXLSi?=
 =?us-ascii?Q?1cCpGcNmAuDX7qLdqQXFnloLTymb6AQBv5TYBihk52lp/wqc3NHus1eDvM6d?=
 =?us-ascii?Q?TYUNSnZ2IBT+P8DYNMSc/PbWT/0AGJDzetkAOoAnKmc4A3iC8MsgMZNJRcy3?=
 =?us-ascii?Q?yiDTdl1yLatvTOoWZMbQT73qdu7+n4Idr660aKgpVvw8MP5foJTAQsNKWzb4?=
 =?us-ascii?Q?x0S8GJh0zSFfXJlonJE+dpRT9G5rSyCFFEZQ+IJv5bvUNIwc/iBRqDlUuggd?=
 =?us-ascii?Q?mfrhVt9w7BH5jOPlF1Rne7/3bRnUE9P4A6oi1l/mIZHnsv4rNTCwJLrvOkmP?=
 =?us-ascii?Q?yEac78JVXON1fu/xS1o7Eh2qLgKA+ZgYFaFut3W4Op08EKrKYmaQeZ930Q00?=
 =?us-ascii?Q?P8mv4WHfC7dbrN/BMa+QIA6cPPYsN4iExhOb0kbVORyAWGMyyrnOdbmYb93v?=
 =?us-ascii?Q?6C3dYB1HJYRo3x96zSeBNvP1tOPK5VcEexC0pyU7t9IpC7RXFUu/ZyBj5JzM?=
 =?us-ascii?Q?o1keIElUgHzZxthr9kaPF3a6YqbpBVCDJ0lTn1AOEkju/bRzLwJQMhReh7i7?=
 =?us-ascii?Q?RR04Rb2UbD2ZROFyd5aD2v7ZSgLZ6hG1qn5tKnUVh+Tv7C3aqrQ6VEbQX1Hr?=
 =?us-ascii?Q?A4IUL+S/+DEY/2dyOFItNPDOXUHR4Wn35db+4hw8/ImeyMF3Vz9+xeZSgLjA?=
 =?us-ascii?Q?7Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	q7TZhqbAEKwFo7afeAet+W4JWFjbY/6pRgO0eUbXWrTFUeVzfB/FBL8QeXT9Qvr/ZRTkwp4R1Cr/zRqlEPsnue6o5QFm17HTkV8U7sdoysj1XsszdNPCOitnvehmlVakBJyFqDXEulxFFRPSnsOZ9wLlVb4VI0CN+IPfyqzDGCIopqfpZMQpHv0gzcqK5S7Jq7ocZBrC5EuQIR5NaWHVyGt5QWhhxg98qSLotsGWkEKfkRJaBdlVnCKa0zY8LmXQ4wWnYj7KfutlZmKFEoLgrtNi+vpd1YIz4wAhi7nDkG31AxoCCDhJht90YBe/1OkqXYabuu9rWgff8rkfrFcqpCunnSpZ/Ak4CC51jRAfVtIcEolHobzJCvrEJcI9ZjKa6WnQIpssvs9MtEm1Bt7p18vTLy/rYfCEgtZThrLmrasetcI0NaD64rdTRQrVZPNk7xMy3sHK3ADEKWZpnOszBmNmhypCl/eiLAl4LYoaZZ+Gyq/vl5HGT65ND77a7+qcXqeldmUf/oPHHgNODW841NMgBKko9jdVj1TA0lGCfjXF3Jr8daSekEXLW3ZIC/VUZUCuSbxaKKazR+tAYt+ey/c4x/CJDnCL+k2cS7w5gTI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a16fffa3-00f9-4bc0-07c8-08dc32664235
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 22:49:55.9565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B8tzPlNhjLETHAqhLmLh2LSA6kS532vbSUIgATOoCU6Nyn8gB0krIoUQOEt6cVOM52U0ORst8Yhk4u8GW6xlFrKsdzkWrRI+lawq0TtdjRE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6500
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 mlxlogscore=995
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402200163
X-Proofpoint-GUID: t554-GNGal6P1axvHupAfy6kOE6itktv
X-Proofpoint-ORIG-GUID: t554-GNGal6P1axvHupAfy6kOE6itktv


Thomas Gleixner <tglx@linutronix.de> writes:

> On Mon, Feb 12 2024 at 21:55, Ankur Arora wrote:
>>
>> +#define TIF_NEED_RESCHED_LAZY_OFFSET (TIF_NEED_RESCHED_LAZY - TIF_NEED_RESCHED)
>> +
>> +typedef enum {
>> +	NR_now = 0,
>> +	NR_lazy = 1,
>
> Just a nitpick. Please don't camel case the constant. Can you please
> write out NEED_RESCHED_* as NR is generally associated with number?

That's a good point. But,

__set_tsk_need_resched(NEED_RESCHED_LAZY/_NOW), or
__tif_need_resched(NEED_RESCHED_LAZY/_NOW) seems a little repetitive.
Plus, there's the risk of confusing it with the TIF_NEED_RESCHED_LAZY
flag.

How about, something like this?

 +typedef enum {
 +	RESCHED_NOW = 0,
 +	RESCHED_LAZY = 1,
 +} resched_t;

Still, not ideal. But I think it's an improvement over those two.


Thanks

--
ankur