Received-SPF: pass (google.com: domain of linux-kernel+bounces-73791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <657ade76-98c5-4f93-9716-b471b31d07e2@oracle.com>
Date: Tue, 20 Feb 2024 14:57:59 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] tpm: protect against locality counter underflow
To: Jarkko Sakkinen <jarkko@kernel.org>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        Alexander Steffen <Alexander.Steffen@infineon.com>,
        "Daniel P. Smith" <dpsmith@apertussolutions.com>,
        Jason Gunthorpe <jgg@ziepe.ca>, Sasha Levin <sashal@kernel.org>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kanth Ghatraju <kanth.ghatraju@oracle.com>,
        Peter Huewe <peterhuewe@gmx.de>
References: <20240131170824.6183-1-dpsmith@apertussolutions.com>
 <20240131170824.6183-2-dpsmith@apertussolutions.com>
 <CYU3CFW08DAA.29DJY7SJYPJJZ@suppilovahvero>
 <2ba9a96e-f93b-48e2-9ca0-48318af7f9b1@kunbus.com>
 <ae3fecc4-7b76-4607-8749-045e17941923@infineon.com>
 <91f600ef-867b-4523-89be-1c0ba34f8a4c@kunbus.com>
 <CZA9CM3PDILC.82JMLUWMB6B7@seitikki>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <CZA9CM3PDILC.82JMLUWMB6B7@seitikki>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aXl5QTVQU0N1OXJIMHpRU2x3eUlHOS9uQTNMaklxSFpvY0tJMnJLWis2Uld1?=
 =?utf-8?B?RHFka0lkbU1BdC83QTRrTXVld1FkVXV3V2JrcjJUNnJwT2VuS3lTY0pUNTdM?=
 =?utf-8?B?aFlubjR0RlIrczJ1VEd6VUlKWEVmdDdURWkvaDNvSmU1UzNSeEt1dzF5d2gx?=
 =?utf-8?B?YnY3K0d6NXE2QjB6NEhlWGJ3ZjFqOHJDWGZZVlhVb04vOUZpSVY1cWFVcHhD?=
 =?utf-8?B?TnFhTGNjQ2RlM1Y5VFZtaTJhenFDSE5GUDg2bmNWNm92V2NtMFFIMjZhV0lr?=
 =?utf-8?B?R0FhVy92b2lEUXZVK0ZuM3VOZjRkSytZeEVOMlJNQnhFS2NOdXI2b292Y3VY?=
 =?utf-8?B?WThDWVFEOUNDYk5uV050d2hvaFZzN2F4WmlxODYyRllveDltZElmbkx5a2JY?=
 =?utf-8?B?OURzNjljTENOZHl1aHRLZUVrL1JvdnpNNS9LQUMyMkh1b3BkMzZDWjRWTWhW?=
 =?utf-8?B?R1IvWjRtdVAyTEZrMzhpS0I3cVY1RjVJZWxtSXU1VHpaVFgxVFd0Ui9vNk9Y?=
 =?utf-8?B?cWlJTGVpemVlOXVjY2RaSUhZS2xHQS9nL05SS1d3ZHVHZGRXSHFXdjh4bVJi?=
 =?utf-8?B?d3phemx5b2lPdUU4RFNMRldJNEhDM0krK2NKU2lHUXdSVVNvRzJCQVNtWkdw?=
 =?utf-8?B?WFpnYjhpcys4ZnltTWNaK29JYUhzQVJ0TWJad3l2U0ZTc0IrR2FmTVdkKzlL?=
 =?utf-8?B?Y0tpSk56dlMxSWxDU3p6VDZSdDYvWGoyYkRHR09iRHBrRkZYMk1USENXUkpU?=
 =?utf-8?B?WDJUU0hRVjdJRUNaRXVLYkJnaVR1eG1RMUFZMXRhRWs3MG9wUVVaZUhsYlZh?=
 =?utf-8?B?UFE1Y3FmcWtLVG93T09DTlI5cWZPdUFQTnpURkpLVVRBd2lzVVg4MG16MFlp?=
 =?utf-8?B?OEc1NEpkeUZhNko2Y2ZEbklWOElHY0g2bFpEb0VrSlFsRGRXdEg3UzZPMkpV?=
 =?utf-8?B?bEh3ektDaVliZkRRQmtVTEkyc05TUlZmeW83SW0yYVdZTyt4RjVYYlpEWDNF?=
 =?utf-8?B?Z2dHVmsrVmpuZnl1U0FUV01PeXd3V0ltdWJpaDJWbzE0SDl6dUgwL0gwQnZq?=
 =?utf-8?B?NlBwVzc4a1ZDREJ3YW5zRW5VUFJsUWRWWUFhOFF5b2kxaVcvMDVPK1dnR1lq?=
 =?utf-8?B?cnVpRnFMaUpmQnF1NGlxOUpWTERxVzhkVDBEUUp6aERYYlY1RXEwRGxkQVAy?=
 =?utf-8?B?YnNuTEJpa210SFpyRVJtOThrQnc2NEpHeGdZYjBPMk53c3Jzcnl3TFZydFFX?=
 =?utf-8?B?dml2QWFtemZ5VmlvdWdEdC9GZzlCRXJaOU4zbVRxZTltSEFkUmg0eHhoOFlz?=
 =?utf-8?B?VGNZeEtRT2E1THlWSUl0bjF1Z3cxTmZFYi9kY3JoSEFSbVkvZHM4QkhMY1oy?=
 =?utf-8?B?RWpGaTlnK3VkQ0pUQUVEcVpTMlk5OUx2ak5aK2ZNYWI5MkQ4d1F3cExRSE9T?=
 =?utf-8?B?WlBqTTVYVGl1RjBKZFptcTJwb0JZbnc4dkNtYXhpVGxuTTFKUEdveWNLZU1O?=
 =?utf-8?B?Tk5yUHAxRWVTeEYxZC9lODVHcjl3amNpTEZpeTIzYmErU0ppOWdtZHBRQ1Qx?=
 =?utf-8?B?R3BrcE5EUnNyN3BhR1NERDY5REYvTkFTWkdKK3luRW9hbG1qaUxhMmxpeXBk?=
 =?utf-8?B?OUgzQ0J0dktzZFRSbERxNGQ2N1FkeEttTjB4RHZqNURuNHRCRTlDZnJGYnlQ?=
 =?utf-8?B?N3JLY3VuSE1na0xRbE5wTngwSFU4Slg1cVFUZHFHSVV1aWhzalhTZUdQR3Q4?=
 =?utf-8?B?YmUwTCtGcXFjcjN4V3FMR3JsM0ZFWUMyQ2ZrTHgvTmpuamN2Z3dKYmNFYTFM?=
 =?utf-8?B?RHpaN1oweFlybWh4WVl6Y1VtUzk5ZWxFZ1c3dThlTk11VERRTktMVDA1dm5q?=
 =?utf-8?B?d2lBOFZlNFRLbVJVTkFRV1BJc1V6RjJyUHh5ZEU2akVwdDdHbTRMWXpKTFdj?=
 =?utf-8?B?RmxMcUJJMWJXd1ZQY2VHYW0yRHp3d21SYlRDdXcwMFFncUVaSHUyOVFhRzlO?=
 =?utf-8?B?OUVHNmozV3RQMTlWazc1K2ZTeXBQWHdmd0FHZGRWZ0J6V1ZLdE05VFlrek1i?=
 =?utf-8?B?SllnVW9Sdys2YUx1RFMzQVY1cURESkNlWnUxNjJRVWw1aDQvNDFqSVI0RnRF?=
 =?utf-8?B?QnBQL29xQklwTllOKzRPT1NrYjdhOTNldVgwZ1UzMDdGZ0pqTlNTK0lmZXlR?=
 =?utf-8?B?M2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	qNLDkB3ebB1/rI4PMWz8orX72TYXQoxwL88M9uWFNW3iKQfc9a4Ja0mjjdDmGr+hzG9qtlW1xnd+6Fnxdk0pCsWePE6NbhJHpUFAdGD9nI9tUQ1p/Ox9wgZHgTUJKYj+mBquiBqmILNpxcB8dB+A+iFKvAOWmkphTkqFYnCe+JBRPJOQmEQWYE7YAVSb7bT912m9HhpAss8SzEetAuOvh475Z827zCf0vXiFbpcv2eAC5AGHfUb1GYMalECxUC7lkadM11D1yfO+ElDYp6cBIymooZ1V57l7mEps8f5IlqLkR0U37NyhMJuti7+k8/Pua+rmFA25QznAD/h3HlHBUE1Ws7yFWRvrCJyGTu2cHTi316FZAq2Ps5/7vx17cPyFko07WqFRfsrOodVgzEo7EkPLC2vj4F4Qy09GkWFuhAupQ+jbNgpVAmpfdQjXLzvLwXKySXbsCVni+1ddMirqaWdwoJryxLTm/3PvBaph3wkbT91HB+tsZi0BAqifOo1OzAXKg9zqhr080iKwhpsK3DJTw3WV6UyrZGzJ6glLFPWEfUdW1fI8O4VF8x25xy5f2iEo8fZlD9/xfV4v7gwfMLtSYFN2kkevqIaw2u19gTY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 264e1b28-2192-4e6d-49b2-08dc32676446
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 22:58:02.6636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YfFTPOOLTKBilppjOrVE9NXVstVBbdpSy5kP+hfwPlYhJYE/5gt4SmZ2iBnTASRotjosrbYlmS3SPAobClvN6i+e3sS0/Ne+85qBlIRfSR8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4364
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0
 mlxlogscore=890 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402200164
X-Proofpoint-GUID: hCxxQJNxNPUv714ZDlYlm7TdQ7LwIWFg
X-Proofpoint-ORIG-GUID: hCxxQJNxNPUv714ZDlYlm7TdQ7LwIWFg

On 2/20/24 2:26 PM, Jarkko Sakkinen wrote:
> On Tue Feb 20, 2024 at 8:54 PM UTC, Lino Sanfilippo wrote:
>> for (i = 0; i <= MAX_LOCALITY; i++)
>> 	__tpm_tis_relinquish_locality(priv, i);
> 
> I'm pretty unfamiliar with Intel TXT so asking a dummy question:
> if Intel TXT uses locality 2 I suppose we should not try to
> relinquish it, or?

The TPM has five localities (0 - 4). Localities 1 - 4 are for DRTM 
support. For TXT, locality 4 is hard wired to the CPU - nothing else can 
touch it. Locality 3 is only ever accessible when the CPU is executing 
an AC (Authenticated Code) module. That leaves 1 and 2 for the DRTM 
software environment to use. If the DRTM software opens 1 or 2, it 
should close them before exiting the DRTM.

> 
> AFAIK, we don't have a symbol called MAX_LOCALITY.

Daniel added it in the patch set.

Thanks
Ross

> 
> BR, Jarkko