Received-SPF: pass (google.com: domain of linux-kernel+bounces-73810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.82 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.82; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <bce5cff4-c1a5-4d71-b6cd-a89c55a628ba@seco.com>
Date: Tue, 20 Feb 2024 18:17:02 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: ls1046ardb: Replace XGMII with 10GBASE-R phy mode
Content-Language: en-US
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: zachary.goldstein@concurrent-rt.com, Shawn Guo <shawnguo@kernel.org>,
 Madalin Bucur <madalin.bucur@nxp.com>, Li Yang <leoyang.li@nxp.com>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org
References: <20240220145037.kf3avnykjif24kkr@skbuf>
 <191b4477-7b4b-47eb-bb3e-0e4d08b3b32e@seco.com>
 <20240220223706.o7wc5r57omkmgtgh@skbuf>
 <e39c811e-ad9d-4e90-8710-629b822944e0@seco.com>
 <20240220230656.cefvrh6avji2elrd@skbuf>
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20240220230656.cefvrh6avji2elrd@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 hTnI0TsgT1h2u+ONx/DovGfM1kduG9bbc6EM4QlO0fxgy9oi7QvJH6G1z3wbMjwbiJjIdXSnv0Ot3ssQG0MNn7phNbSl5pP24y6HzFIdg59SymyEYdYBSfAH8H74AzHoD15obpdiPIAJ/w75eTWS7ArUYPPuKsl9dOJHShumXdk1Xy6qXNOR6jZ+sEqdGew/OPhoVI5lUF6M8Q1JccfFbiqYkxMiF1FuAd5NTm9onJFwOmZwpOTAy0Ae8bqVKaRcGTcY4UMczDSCCZRR5deo2apbpj+pd5Fl/q6ZRZULeB1qkQsG4S1QGQJ7QeYPgBvq0uMRT76XJPFOHJjwevWdM2Ae6k1mVrJEmaX++ayMSCJ0WwYoCAuQBXWZOGv8mfnH8W47ORjcE9wdU7mdCwtKs32Hno+ov98qo3jPR3S3HWWpPZ5/k+w6crJmyDyXmN5DPWHW+snOrWQxpW8w8845dC0XAfZjFTEMNu7rX2Av0nzXjfUlvm/SJtvnQcpuJwWHEmmwQfHVvPmzw4C/MF/gqIFWrKaxA/vSB/8RCwpWBjG5Ef0j+xrFxFFIcPTcoAHRMjUw5qI/EM7jwd79XRLLo+f5SUVea1xa/fsXi8oV3yV0wCH128pfiD3dYsyKq8ZP
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR03MB10567
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM2PEPF0001C717.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a53f7387-582e-47be-6cc5-08dc326a0deb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	flf3nXYRbX9JaYgzyBKXD+2p5JYINok2c4WXh73bUGqaICz5HxQONZvC/T8r8OnnWul0Fe/bW/kzswJ+KRvLKVqzYfoCGLkCUycjGEiWVPMX1GBLhLuKvZ/35H/hMLlGED7jHlCpHvGvY44ERhWZwr+JZkjLhfHNHuON9730CDiwn0RNg4kDNbrLyeOqnDyAdH5yd4/89racBucGPIqKijk+UO1g6Z8ws8Ee1BlmPdd9KMFG9MMmiZMUxhAuSkv+pTAnWyr88vRcVWti92yaCBqkZgO+0v+srO9ir6X8J8EELZ61k9yzqmrcxYq4dR6QujWneX2STbDfpXt3aBzJGAlkvt5vYrN3YWQq0vmOEC3R/19Xq5CROWcrhDMOFE/im/nNiU0mM9AdXUH+hLN1jQW6EX+xWjExpJ634zyrup3qmeKeVkRiCZ/OMABRGdC/39vKZ+jPeEq7JoW0iNc2Ggd0jxYUYUAIJXIeYzJ4mgWQw508gCl654orHlNU6PwrYbB3wKhyfov90fCTf4nc0kKyIxXHjqhG0V+zSzTRq2HDBcT5vDt+ZP4Yw6Fiw0AdZWvFwUgnN6/ohZpnl0DFKxieUk6Bb9eDGdfikWPw/SqyxMYHaOOlvtlSbZ0md5vhYtucFtPfIZOhUMm1uX2PB4RZIQEMH0P3nI4mC8VsPog=
X-Forefront-Antispam-Report:
	CIP:20.160.56.82;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(36860700004)(46966006)(40470700004);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 23:17:14.2005
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 89554108-ccef-4284-38b3-08dc326a12c3
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.82];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM2PEPF0001C717.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6267

On 2/20/24 18:06, Vladimir Oltean wrote:
> On Tue, Feb 20, 2024 at 05:52:36PM -0500, Sean Anderson wrote:
>> With SGMII and XFI, the PCS sits on the MAC's MDIO bus. So for SGMII and
>> XFI if we don't have any labels we can just assume the PCS handle is for
>> the right PCS. But for QSGMII the PCSs sit on another MAC's MDIO bus. So
>> we need to tell the MAC where to find the PCS. This means we need to
>> supply multiple PCSs to the MAC
>
> So how did the other Layerscape devices with the same SerDes, PCS and
> mEMAC manage to get by and support QSGMII without listing all possible
> PCSes in pcs-handle-names? :-/ DPAA2 has the exact same situation with
> the QSGMII PCS situated on the internal bus of another DPMAC.

I'm not familiar with them.

With DPAA we used to just try to configure the QSGMII PCSs on every
MAC's MDIO bus. This worked out since if you enabled all the MACs, the
right one would eventually configure the PCSs. But it also meant you
couldn't determine the link status (since you didn't know where your PCS
was).

> It is unnecessary and buggy complexity, and it will only have to become
> worse when I add support for C73 backplane autoneg in lynx-pcs and the
> fman_memac driver, because I will need yet another PCS handle, this time
> not even one that represents a phy-mode in particular, but a PCS handle
> for C73 (with C73, the autoneg process determines the dynamic phy-mode).

There are multiple physical PCSs there must also be multiple PCS
devices. Otherwise your software and hardware will get out of sync.

If you don't want the complexity, then don't design hardware with multiple
PCSs connected to the same MAC.

--Sean

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>