Received-SPF: pass (google.com: domain of linux-kernel+bounces-73824-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9da1855b-eca2-4c11-a69d-e01494c985d1@kunbus.com>
Date: Wed, 21 Feb 2024 00:26:08 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] tpm: protect against locality counter underflow
Content-Language: en-US
To: Jarkko Sakkinen <jarkko@kernel.org>,
 Alexander Steffen <Alexander.Steffen@infineon.com>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 Jason Gunthorpe <jgg@ziepe.ca>, Sasha Levin <sashal@kernel.org>,
 linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ross Philipson <ross.philipson@oracle.com>,
 Kanth Ghatraju <kanth.ghatraju@oracle.com>, Peter Huewe <peterhuewe@gmx.de>
References: <20240131170824.6183-1-dpsmith@apertussolutions.com>
 <20240131170824.6183-2-dpsmith@apertussolutions.com>
 <CYU3CFW08DAA.29DJY7SJYPJJZ@suppilovahvero>
 <2ba9a96e-f93b-48e2-9ca0-48318af7f9b1@kunbus.com>
 <ae3fecc4-7b76-4607-8749-045e17941923@infineon.com>
 <91f600ef-867b-4523-89be-1c0ba34f8a4c@kunbus.com>
 <CZA9CM3PDILC.82JMLUWMB6B7@seitikki> <CZA9GMC718HA.1JFHTTWV563IE@seitikki>
From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
In-Reply-To: <CZA9GMC718HA.1JFHTTWV563IE@seitikki>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXE3MWc3b1p1dVNGRXRSMWEvNUFaM1NaZStjaDNmUUkyazZvNVhsOEJrVW9F?=
 =?utf-8?B?T3BwcE1EbEFlSFlTZ3JxL3A1SmRUYWxZNlJxNDMrcDZpc1cwZE1pT0I2VHdI?=
 =?utf-8?B?cGJhSUh2VThFOXJaV0M5MmNIVWhZR2VVRWY1MVViaHRsUWJiNUJqMkdpakNy?=
 =?utf-8?B?WlM4N2Z6Znc0S1BjZUxuMXVDZjVaa0xMdVhqNVcwYkVPd3V4ZHRCSWxpWVBJ?=
 =?utf-8?B?aXVJSW5Mc3VRS3k4OWNWS1BQWXEwWHloZkE3R3NQYk1UOWNBWVBBOHk5UEVQ?=
 =?utf-8?B?UWlnaTRqWi82b21lQkJ2Z2lVc3M5L0dsS3kvYmlTZUNzTXgyNGRBQmxPVVRH?=
 =?utf-8?B?Mk5FeUpCRHJyNU5uT1AyRXRMcGkvcC9PRVZpbFZQWEoxcVVCY0xzRk92VkJj?=
 =?utf-8?B?a09Fa0dneUpkMFZTVmhhYWV4TUYwSjBNdnlvaGgxaDdwSHRENHBtNSt0aUlU?=
 =?utf-8?B?elhBWjN5U3pMd04wRzZOc1NwcjJFcm1qNHpObDB3T05jZmo5L29Ddnp3eWhR?=
 =?utf-8?B?WTVST0pJVTJpRTNYa003bXFpVlN0YkVyeU1jb3gyL1lwSm16ckNhV0hlMmN3?=
 =?utf-8?B?amh5U2NlbXNMREIzZ2U3N25jeG1qNWpoMGVHbFZ4U0FWRzNZUlRXS05qVEkx?=
 =?utf-8?B?R1h3NXVHUGVXa3dHODRxSEdaaUFwVnBMaVV0dDd2VndsWnFHWE5EYTl3d2Zs?=
 =?utf-8?B?TlZhM1VGdjhtU0Zac3BWcWt4TThmNENGMXN1LzNLdnRZUjgwSndtbERDOTVI?=
 =?utf-8?B?RkNJU2dsME4rSDJEdk9UR3RvZStEeVZ6VEZXbXQ5aURvdUJJc2w5VkEwR3pZ?=
 =?utf-8?B?Tm1ZbkZJMmxvdTU0L3NSUmU3ZUgyY3J6end0WjhWOW1QZWpBYmtjaTYvY1p4?=
 =?utf-8?B?SHliWnJvc3pHVDhtYnFHMEkrTDRlKy80Wk4xMkZMbVVLSmRSbU0yU29UYS9T?=
 =?utf-8?B?MXNnbk1UT1Q4cDhZQUpwbUpRS3NmSEdJRnNBaWNrRWNKUENKbm5FZ3Z0bGlP?=
 =?utf-8?B?V2plTWxJd1hKQ2FGYUpIZXpmQVBIWUhLbGVXSkd3MDlOQWcwUlhITkloOTRu?=
 =?utf-8?B?NHBtczd2anpVRGlKc0MwOUZRWDVmMXZjWmxNZy9PVFFDUTl6WEhlUUtVblY3?=
 =?utf-8?B?ZXMrZEpTeUk2LzdkSWxSR1NCT2Qyd0FiNlFOSWFyVU1oUmhmd0JjaTJHVm4r?=
 =?utf-8?B?STRsRFAvWkhSZlJOZGtndG90K204aFNjVmcwanpWZzRrZkJIc09wMmtDTGxO?=
 =?utf-8?B?R0ZZSTlGZjNGMXcvSk1pY1NYMjRTNlJjbGFLS2dPUFU2YnJJUlpzUDF2MDBi?=
 =?utf-8?B?T0NlaEgxcUQ5alhaTUpTWVNCRFVFaVY0dFJlZXBhVUU0ZEoyczlRNFJqQkVS?=
 =?utf-8?B?UHI4dDBTbERQUGlpQmpmVlhmMGlHQlZCc3B5QkR1VzZsODdJVmh3VHpoMHlp?=
 =?utf-8?B?Q0F3Tml5dStiNlZFci9Na1E5YkpDYytLRlIwMkxXRXdBOWJ1dmZWTnV6ZUJE?=
 =?utf-8?B?aUt4RGFzUCt0azA2MnNDR3QvYzhGbW42VnczSy9HNFA2SlhyV1pWbm53bks3?=
 =?utf-8?B?Ukx4S01xWWliZ21PSGdFMWQ5ZnVZYWlMQmtZdXlmL2RLVnFSd3ZWREIzM1hG?=
 =?utf-8?B?MURTYlVneHZrQU1xaFgweG1wVXFUTnIxQXhUdENPZkxSdktaUmZUNEUwS3lq?=
 =?utf-8?B?TW95ZWNpWS80c3BNbFA0WmxpQU81M2d2cjFNa0xhcFU0cjdnVG1zRmRxdGhy?=
 =?utf-8?B?bGRseUtJWk5EK1ErNS84bG9mZWkzOTZOcTJvZVdQR20wNHpBVWpCUEFNOGdH?=
 =?utf-8?B?L2R5Y0tmaFRzV0VicEdXSXBCWDhQTlFxbjR1Q1JxME5ka3o2eTI0T3UxSFRN?=
 =?utf-8?B?UEN4THZGSTNMYlhQbENEVmlQWXNicjVFN3JRaDVlTHJwekZibnRTaWhZRVYv?=
 =?utf-8?B?VzRyU1Ywb2U2Zk9yVHlQM0M2UmNEOURjRDlFMUdXaStVZ3NGVWNXUXdUSDVw?=
 =?utf-8?B?MytqMmNKeXZqSk04R0Q0ZWZoZUI0VkwxbUNUNDdyb0hnYWlmUU8rSU9Rdk5q?=
 =?utf-8?B?WGhZOGZZQTJnd1ZkRFNvaTBXYXhUMWNtbngwN1dkM3ZIbzM1NHRXeVczUW5y?=
 =?utf-8?B?ZlZiQUpBV0ZoNDViMEVNWUtTMDlVbzcwVUZ0S1lNY0x2b3U5d01ndkF1Q2ox?=
 =?utf-8?B?MVNqRU1BVEFCYzM4QURqd3NOdWVnTG1GaFFCV3o0L0JCdm02L3gveGlUMndu?=
 =?utf-8?B?aUF2d1RWbXprbEhMajR4SWJBREF3PT0=?=
X-OriginatorOrg: kunbus.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ca50ca8-2a6a-4487-981e-08dc326b5255
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 23:26:10.6333
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X1gXgltUkOKhtY5XWK9bJ4FmKyW8DblLXVifJPyC7zw/m9xH2mcLah/xnfdjgkYq1haeNPiG23bnwB8HYitg0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0880


On 20.02.24 23:31, Jarkko Sakkinen wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
> 
> 
> On Tue Feb 20, 2024 at 10:26 PM UTC, Jarkko Sakkinen wrote:
>> On Tue Feb 20, 2024 at 8:54 PM UTC, Lino Sanfilippo wrote:
>>> for (i = 0; i <= MAX_LOCALITY; i++)
>>>     __tpm_tis_relinquish_locality(priv, i);
>>
>> I'm pretty unfamiliar with Intel TXT so asking a dummy question:
>> if Intel TXT uses locality 2 I suppose we should not try to
>> relinquish it, or?
>>
>> AFAIK, we don't have a symbol called MAX_LOCALITY.
> 
> OK it was called TPM_MAX_LOCALITY :-) I had the patch set applied
> in one branch but looked up with wrong symbol name.
> 

Sorry for the confusion. The code was just meant to sketch a solution, it was 
written out of my head and I just remembered that Daniels patch set introduced
some define for the max number of the localities. I did not look up the correct
name though.