Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2053901rdb; Tue, 20 Feb 2024 16:03:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUYlA1ZRfm6/vCFzlw/nHP9e6xENC5XKVvkCSR3BTh2Mw9gE+MjsYtOvJJ/4NRZFNJtRvFHk4valew6IdYBv8m1bR/XsklqlIoSwFPWJA== X-Google-Smtp-Source: AGHT+IFTsmgWC1sPhlN1JoPqQxyFWGiKA+dWHgZ78Est6GiEnyve15qVFEgsSWTDGbqWJBAXut6b X-Received: by 2002:a17:906:488c:b0:a3f:7bc:7278 with SMTP id v12-20020a170906488c00b00a3f07bc7278mr2416311ejq.31.1708473825019; Tue, 20 Feb 2024 16:03:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708473825; cv=pass; d=google.com; s=arc-20160816; b=ouYJv4zB8bFnxr41MWAS0FlkzbfrKeel4FdZ8Q8Soj9InV6qzwiKycQqrHNPFUYQQS DeBpH2EVzFFgYSI36GY/LBwP7tDXODTXkHAjeuXUdY9P7aHGWxIZfiO9p941pcxO+mIN ni/Ag54HjZUv9e1PyyZDw/mbWsuQE3r1YIhiYAruYxkv/Ondl4tcu5BOPslC9qceBl5v pV785slgjB+cCfSrc0rLWWI+rbw1GQPNLPU4vaOJq1DEbCk91jonA4BV+wg9fY949Yld 02hU1uEjhTey4It/pA007nYpd5wyE0MLabPaRRpNmokDi3sy8qEe2gsLcK1S0nyXMWuf bYgw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=+6/j+aIjOd2uqqWqo5eaQg9dld1kFmS/dGusi7m7xT4=; fh=1litueK9OQPOTKO0ghLKzVJxbli9mtXVWnl2qHnoGcE=; b=ImO6VJxv1E5Te/wrClRS6klNaokfM6sgX+1ZFlglNSUKI+BzyP15CHh7XvGxVSIXyd rBqlsaXhGFcDR+KP8pkdlnnA9+H6shOJNpwD2Xuvd8nW+JNtBnb6L97XUY5u6LLRb/do nOcw5mdDKofq1FHXmM2so6021+ZX2u9/yG0XFY10Lfo2q2NGrgLquSPt8cLD5FHU0OjR 4l0LHZV6Tcdk0tnel9UB20w/Xvc6ZvDOclBzk8//dI8+REBeGLX9GaZLCEmSj6YEh6Me 9DJi8oix5yydRjqFTmqumEypmIUGYYnJ6+RvQQNl+1yacUxKrbYLJTdaatr2BHfk7Gje GVcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=sL4ypquH; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-73848-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73848-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kb5-20020a1709070f8500b00a3d1ea972f0si3888973ejc.562.2024.02.20.16.03.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 16:03:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73848-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=sL4ypquH; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-73848-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73848-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 991B11F21C2D for ; Wed, 21 Feb 2024 00:03:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 15BDA17CF; Wed, 21 Feb 2024 00:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="sL4ypquH" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63A52368; Wed, 21 Feb 2024 00:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708473817; cv=none; b=N1bsp45cQPfN9xneprMQdki8LrfIWYstMXALJf02RTJ7jziNr7eiCbg5eoDBwJNMBxJv2izXiBRWO80Lwg86/PRxwMkiDpGzyWZtnbsvBiTA19vSMzSGjXcaydGqEwhMBqG3/5CF3ERcavA289XNGmiMvkY11QsGa7eJH1m6PHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708473817; c=relaxed/simple; bh=6lvUn+C/j0fNP/8+yUQCN4/RJ9aVo+rUL+TbSe1ZyHY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=md8nTyoUxMo9G+uawYsr5boqXpJIhKYRmCBxe1ni1rtyJQW9+C2WncuTVQ29xLYU1fgkz5ZcFRMWKeZtPS3sTNJnRBngPmF/zXncrQpPi5a1ZZVaiJ51NziurUumjm65fbEJo0nQWDQvqY2hVXJ3lktjAkvovdTDav0NsupXmBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=sL4ypquH; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1708473395; bh=6lvUn+C/j0fNP/8+yUQCN4/RJ9aVo+rUL+TbSe1ZyHY=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=sL4ypquHKN/JkzV80/vKNTwPeMicgmxFiuC1sY0sip6Qs4CUb0J2v3ur2tEs2MPRK AgjUlfMS3z48Msi8go3PHSbx5RPCX1GLI5eipvOahjGa6PCYrOkygFiKOSI+Xt/HXo zvfEa7F8C/uux9OZEuOTHQIpQ82iCrYOAX1Z3Jrk= Date: Wed, 21 Feb 2024 00:56:34 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Paul Elder Cc: Umang Jain , Adam Ford , Laurent Pinchart , linux-kernel@vger.kernel.org, Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , "open list:ROCKCHIP ISP V1 DRIVER" , "open list:ROCKCHIP ISP V1 DRIVER" , "moderated list:ARM/Rockchip SoC support" Subject: Re: [PATCH] media: rkisp1: Allow higher input resolution Message-ID: Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Paul Elder , Umang Jain , Adam Ford , Laurent Pinchart , linux-kernel@vger.kernel.org, Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , "open list:ROCKCHIP ISP V1 DRIVER" , "open list:ROCKCHIP ISP V1 DRIVER" , "moderated list:ARM/Rockchip SoC support" X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20240217185202.1754750-1-megi@xff.cz> <20240218205908.GA12766@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Feb 19, 2024 at 07:11:20PM +0900, Paul Elder wrote: > On Mon, Feb 19, 2024 at 02:33:21PM +0530, Umang Jain wrote: > > Hi All, > > > > On 19/02/24 7:39 am, Adam Ford wrote: > > > On Sun, Feb 18, 2024 at 3:02 PM Ondřej Jirman wrote: > > > > On Sun, Feb 18, 2024 at 10:59:08PM +0200, Laurent Pinchart wrote: > > > > > Hi Ondrej, > > > > > > > > > > (CC'ing Paul and Umang) > > > > > > > > > > Thank you for the patch. > > > > > > > > > > On Sat, Feb 17, 2024 at 07:51:58PM +0100, Ondřej Jirman wrote: > > > > > > From: Ondrej Jirman > > > > > > > > > > > > In BSP driver, it is allowed, and it works in practice. Tested on > > > > > > Pinephone Pro/RK3399 with IMX258 at full res. > > > > > Paul, Umang, do I recall correctly that you have a similar change ? > > > > > Could you review and test this (especially on the i.MX8MP) ? > > > > It's also a limit from the datasheet, so the change should not be that > > > > controversial: > > > > > > > > https://megous.com/dl/tmp/d2b333043ecebaf3.png > > > > > > > > (so that it doesn't sound like I just copied the BSP values) > > > > > > > From what I see in the i.MX8M Plus reference manual, it has a max > > > resolution of 4096x3072, so it might be necessary to move this off > > > > This is what I (and I assume Paul too) have been working with on i.MX8M > > Plus. So it's the known and tested value of max ISP input from out side. > > > from a #define into a structure that varies by product family. > > Yes, this is what needs to be done. Here's what I have in my notes: > > - The RK3399 TRM says 4416x3312 max input and output on main path, with > 1920x1080 max output on self path. > - The PX30 datasheet [1] says 3264x2448 max input and output on main > path, with 1920x1080 max output on self path. > - The RK3288 documentation [2] (under "Camera Interface and Image > Processor") says 4416x3312 max input and output on main path, with > 1920x1080 max output on self path. > - The i.MX8MP reference manual (the open one) [3] (in table 13-1) says > 4096x3072 max resolution in single ISP mode Yeah, RKISP1_RSZ_SP_SRC_MAX_HEIGHT in the driver also seems weird in this respect: #define RKISP1_RSZ_SP_SRC_MAX_WIDTH 1920 #define RKISP1_RSZ_SP_SRC_MAX_HEIGHT 1920 regards, o. > The i.MX8M Plus seems to indeed be limited to 4096x3072, but the TPG is > capable of generating 4416x3312, and the ISP works fine in bypass (and > therefore raw) mode, so technically it has different maximum sizes > depending on the format which makes this more exciting. > > In any case, the PX30 (assuming the datasheet is correct) only supports > up to 3264x2448, so the existing #define is incorrect anyway. > > I don't have a PX30 nor an RK3288 so I can't test those, and I haven't > set up my OV64A40 yet which (I've heard) can be used to test even bigger > resolutions. > > > Paul > > [1] https://opensource.rock-chips.com/images/8/87/Rockchip_PX30_Datasheet_V1.4-20191227.pdf > [2] https://opensource.rock-chips.com/images/4/49/Rockchip_RK3288_Datasheet_V2.7-20191227.pdf > [3] (requires login) https://www.nxp.com/products/processors-and-microcontrollers/arm-processors/i-mx-applications-processors/i-mx-8-applications-processors/i-mx-8m-plus-arm-cortex-a53-machine-learning-vision-multimedia-and-industrial-iot:IMX8MPLUS > > > > > > Yeah! > > > > > > adam > > > > regards, > > > > o. > > > > > > > > > > Signed-off-by: Ondrej Jirman > > > > > > --- > > > > > > drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > > > > > index 4b6b28c05b89..74098ddbeeb3 100644 > > > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h > > > > > > @@ -33,8 +33,8 @@ struct dentry; > > > > > > #define RKISP1_ISP_SD_SINK BIT(1) > > > > > > > > > > > > /* min and max values for the widths and heights of the entities */ > > > > > > -#define RKISP1_ISP_MAX_WIDTH 4032 > > > > > > -#define RKISP1_ISP_MAX_HEIGHT 3024 > > > > > > +#define RKISP1_ISP_MAX_WIDTH 4416 > > > > > > +#define RKISP1_ISP_MAX_HEIGHT 3312 > > > > > > #define RKISP1_ISP_MIN_WIDTH 32 > > > > > > #define RKISP1_ISP_MIN_HEIGHT 32 > > > > > > > > > > > -- > > > > > Regards, > > > > > > > > > > Laurent Pinchart > >