Received-SPF: pass (google.com: domain of linux-kernel+bounces-73931-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240217074046.4100789-1-changbin.du@huawei.com>
 <20240217074046.4100789-3-changbin.du@huawei.com> <9699d30b-f6cb-44d5-ae58-0bdefe3f24eb@intel.com>
In-Reply-To: <9699d30b-f6cb-44d5-ae58-0bdefe3f24eb@intel.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 20 Feb 2024 18:04:36 -0800
Message-ID: <CAM9d7cjZO+URmNE0SQBrFR5-rsLobNpYdiT4s=5svCUwoYbRVQ@mail.gmail.com>
Subject: Re: [PATCH v8 2/5] perf: util: use capstone disasm engine to show
 assembly instructions
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Changbin Du <changbin.du@huawei.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Ian Rogers <irogers@google.com>, linux-kernel@vger.kernel.org, 
	linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>, 
	Thomas Richter <tmricht@linux.ibm.com>, changbin.du@gmail.com, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Adrian and Changbin,

On Sun, Feb 18, 2024 at 10:33=E2=80=AFPM Adrian Hunter <adrian.hunter@intel=
com> wrote:
>
> On 17/02/24 09:40, Changbin Du wrote:
> > Currently, the instructions of samples are shown as raw hex strings
> > which are hard to read. x86 has a special option '--xed' to disassemble
> > the hex string via intel XED tool.
> >
> > Here we use capstone as our disassembler engine to give more friendly
> > instructions. We select libcapstone because capstone can provide more
> > insn details. Perf will fallback to raw instructions if libcapstone is
> > not available.
> >
> > The advantages compared to XED tool:
> >  * Support arm, arm64, x86-32, x86_64 (more could be supported),
> >    xed only for x86_64.
> >  * Immediate address operands are shown as symbol+offs.
> >
> > Signed-off-by: Changbin Du <changbin.du@huawei.com>
>
> This is the only patch of V8 that made it to my inbox, Namhyung
> also mentioned problems receiving V7, but the patches are on lore.
>
> For whole patch set:
>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

I found it in my spam box, maybe there was a change in the spam
filtering logic.

Thanks,
Namhyung