Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2113458rdb; Tue, 20 Feb 2024 18:43:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX0XzeXVcby5cn3lpzKFtnTd8gcG3yAMdwUoNWLO2PGV2V19yHGW2ZHsdC2jRlVTmemqxZKnjE5m/A6OKDUb4l2JMhUlml15qYuJZOrzw== X-Google-Smtp-Source: AGHT+IErtEVRLSkRbVpVlMtIgaffvuyOAJJknQojmaori9xH1/toG67kXSp/PgRDcQQAChteJ65S X-Received: by 2002:a05:6a00:2f81:b0:6e4:688e:2072 with SMTP id fm1-20020a056a002f8100b006e4688e2072mr5489660pfb.34.1708483385846; Tue, 20 Feb 2024 18:43:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708483385; cv=pass; d=google.com; s=arc-20160816; b=0c9p1nEST7OpK+dFGQQ9Meb3aKL4hluTRhRS7PB/oJI4dL3pg/dBmWRRtu3fVfTMcD TcUJiy3EbjPNt3ze6Vt3DR6vICrj86Fg1VcAczyDjGqBK0n0J/lS4wougRW33n03GFIN qgeTwwUyz7HLXelvoHLY6iokqPYwq4U62d4LI0ixkV5Ctkgb2paIICHr9pynK0zmV4cY MxZRydIX+XsIiFuarX06HFBXBm8kWGCNbe3dXaLeq9Wr6iclkgC+/hwKhVM+4ECOpQ2P 8duFqk7+jnieDwxomWr2nJfrFPz++QRDjos29WKklsMiGdL2O6PLyk82SrPlD7+YRj92 +waQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=W8lEpDwN25kJocQ0ZnkfcJKWbT07COY6Pw2SWJ/RJ54=; fh=rdvD35q0Ha5XlXapQJ4VwzwRQwckYjg3lOfWiHCdy2c=; b=T3yJODv0qyTjTQkfqoT3ceJiYRx3Ne32vKaEUlSDB740cyfLdyn3AURjuBxbYQ+3fr AQ+Vuq+tW4l6KWEQmX++Qsxrng5c+KJlV9XfLP0nIV+oeKNCvcJ0H5By2n+XWRKY8+fX c+FR5jnS4pjlcwJ3StSnO3gBiY+5N7izpYP1oWtkjqtNdwPLhDuxSqZd/IUpbconcLo6 ndhao7NUZ9EH4q8dSZIyE2mCnhPesNpvFQFrIKjYvEEISeVdgJJxA3o1k8cg400EYDFA HTHY39udWA8SXFfFFfBR1DFwLTp1+ZdobsvIuBy2ohO54vpfG6bgoC9rXXMeNAgxujE9 mhTw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aixZDuUu; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-73965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73965-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id a26-20020a637f1a000000b005dcbb75b1fdsi7193178pgd.218.2024.02.20.18.43.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 18:43:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-73965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aixZDuUu; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-73965-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-73965-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7583FB241B1 for ; Wed, 21 Feb 2024 02:40:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86C0C28370; Wed, 21 Feb 2024 02:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aixZDuUu" Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47ABB2E632 for ; Wed, 21 Feb 2024 02:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708483158; cv=none; b=skIbzILk34U+G2SZqPkcBc/EjhbQxOGk/BtplUTaihaGuyXOxQEPSScVwNDRi89ep8KGqcb1+/8UL+0ULIHDhuZffL+JAwFegl/GzoS9KvK55GoRlXLBJBmvYn/ynpY9w5j9EjYitg90Lp2IIvy0YFH0SnmVd2O/mxuViHKP3q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708483158; c=relaxed/simple; bh=1qWObMFBRyR70js8RTU5T14VhYADPv0/ruiD3TiWGj8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qjHIblVYvslpBDXK6H7LvDQibKFlOiQBDFGXPjS65rxTsYQppgAo26hD3owrvfZzvjTqsIB9DX+J1nf+Eef3/MP9LP7F78bhazChW0eEc0wPxkFnDXeMDIp3eBJHUAAqKDLmkvOn9Jpz4xee63FhpgIOfujrLhuMN00DQMEk+Hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aixZDuUu; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so5111459a12.1 for ; Tue, 20 Feb 2024 18:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708483156; x=1709087956; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W8lEpDwN25kJocQ0ZnkfcJKWbT07COY6Pw2SWJ/RJ54=; b=aixZDuUulWsCEUpf6XR+Zt0wU37Ss7HbM9dEzgcwId4SjH9fM1VvCrD0NENbI9x3nj D2YbE+3ByEIGdZ9RDPTYmltMtLT2Njd/Ua/TW9EkwRq/11U0CTtGleq+QPoz3g6bWeqV S1qtIArckv/m9x/HwkClDfhH4bkmxRVd17Mk49ksNj8By0RXBlRrqu+DRaUWcImwg4qO GI+gkwGcAd6aoo0h8KtaZA6v02qhPJGVBluqhNjfqGAB09ELvx4v08gxyfmEpC4zhlea tMB+0INrnrVV3XcXbevNvxBBYNgDK5dSuD6PBMgoTMPZc1N9hbfRC2YJQy6xqRWsTFQK Raww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708483156; x=1709087956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W8lEpDwN25kJocQ0ZnkfcJKWbT07COY6Pw2SWJ/RJ54=; b=PzFGC81uvZqmHaNymtsIHg5xETS8FGjEFNqI/hnRiNLj8S7TyQTwVYMgGrHJPlU5XG G0eYSkCdZEXN7fKR7vg01+4jkvjAcX03MoC3HSUA0M1diaadqJ7E8AeqoQsI2+8E7u/x eTAgKYZcmSNvNbhKZg8J2grpVoUaY1228avzdoaXY8HR1Vtvb3r1Gq3Lof3onZ2Rom2h uap7XV6ASZajB2HlYDc4BU7OLuoIkN377kh5Vq9/eXitnz5oTb2FwVDOL+8xdMxsoXXt ywTTJXneFgUQadIWjE6ja5hXa3MUs4GWLwkYFPbsxB7kPKFEivAax0jM9S9lKRTKzHdr ZtiA== X-Forwarded-Encrypted: i=1; AJvYcCXucC7n3H9OM7YkFTcaO36kLLOWOYudmcyIz0rvscjp8QoVhf/z7s9LJJ7SZehqtRAwQGS7FAgUQWVVysLGsuDMq0jyzxVhfyrefPdV X-Gm-Message-State: AOJu0YyrDQhMGTfL8j5HjK4n3nHMUhz4haaVkZSRZ/brq/h3nM+xZ8/3 gD4juN4TMrE2pocGepZ1jCtIUbDo5SoAf5lxsarAvOqU1UMq9JdR6nkLL0aEovsGK3tuhld+a+O nIDeoHVL2+p1v5eh4I64omoDpGyU= X-Received: by 2002:a17:90a:fe07:b0:299:69bf:1ddd with SMTP id ck7-20020a17090afe0700b0029969bf1dddmr7461993pjb.49.1708483156450; Tue, 20 Feb 2024 18:39:16 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216180559.208276-1-tj@kernel.org> In-Reply-To: From: Lai Jiangshan Date: Wed, 21 Feb 2024 10:39:05 +0800 Message-ID: Subject: Re: [PATCHSET wq/for-6.9,6.10] workqueue: Implement disable/enable_work() To: Tejun Heo Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, allen.lkml@gmail.com, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 21, 2024 at 4:26=E2=80=AFAM Tejun Heo wrote: > > On Fri, Feb 16, 2024 at 08:04:41AM -1000, Tejun Heo wrote: > > 0001-workqueue-Cosmetic-changes.patch > > 0002-workqueue-Use-rcu_read_lock_any_held-instead-of-rcu_.patch > > 0003-workqueue-Rename-__cancel_work_timer-to-__cancel_tim.patch > > 0004-workqueue-Reorganize-flush-and-cancel-_sync-function.patch > > 0005-workqueue-Use-variable-name-irq_flags-for-saving-loc.patch > > 0006-workqueue-Introduce-work_cancel_flags.patch > > 0007-workqueue-Clean-up-enum-work_bits-and-related-consta.patch > > 0008-workqueue-Factor-out-work_grab_pending-from-__cancel.patch > > 0009-workqueue-Remove-clear_work_data.patch > > 0010-workqueue-Make-flags-handling-consistent-across-set_.patch > > 0011-workqueue-Preserve-OFFQ-bits-in-cancel-_sync-paths.patch > > 0012-workqueue-Implement-disable-enable-for-delayed-work-.patch > > 0013-workqueue-Remove-WORK_OFFQ_CANCELING.patch > > 0014-workqueue-Remember-whether-a-work-item-was-on-a-BH-w.patch > > 0015-workqueue-Update-how-start_flush_work-is-called.patch > > 0016-workqueue-Allow-cancel_work_sync-and-disable_work-fr.patch > > 0017-r8152-Convert-from-tasklet-to-BH-workqueue.patch > > > > 0001-0010 are cleanup and prep patches with the only functional change = being > > the use of rcu_read_lock_any_held() instead of rcu_read_lock() in 0002.= I'll > > apply them to wq/for-6.9 unless there are objections. I thought about m= aking > > these a separate patch series but the cleanups make more sense as a par= t of > > this series. > > Lai, would you mind reviewing patches 0001-00010? If you're okay, I'll ap= ply > them to wq/for-6.9 and then post the v2 patchset with the rest of the > patches updated to reflect your reviews. > Hello, Tejun For 0001-00010: Reviewed-by: Lai Jiangshan Thanks Lai