Received-SPF: pass (google.com: domain of linux-kernel+bounces-73973-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <8afe7956-8f29-49e8-a59f-7e6b4136fa1d@kernel.org>
Date: Tue, 20 Feb 2024 19:44:24 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: copy routing table more efficiently in
 rt_dst_clone
Content-Language: en-US
To: Oliver Crumrine <ozlinuxc@gmail.com>, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <xlabdyc4izitfdfpuoy2p2hi3abiq4mrrgizdqz45k7xeftbsg@ee6jgncdaqg7>
From: David Ahern <dsahern@kernel.org>
In-Reply-To: <xlabdyc4izitfdfpuoy2p2hi3abiq4mrrgizdqz45k7xeftbsg@ee6jgncdaqg7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/18/24 6:35 AM, Oliver Crumrine wrote:
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 16615d107cf0..ebb17c3a0dec 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1664,22 +1664,8 @@ struct rtable *rt_dst_clone(struct net_device *dev, struct rtable *rt)
>  			   rt->dst.flags);
>  
>  	if (new_rt) {
> +		*new_rt = *rt;

rtable is a container of dst_entry, so this is copying those fields as well.

pw-bot: reject