Received-SPF: pass (google.com: domain of linux-kernel+bounces-74055-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 20 Feb 2024 20:59:12 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>
CC: <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Dan Carpenter <dan.carpenter@linaro.org>,
	"Ira Weiny" <ira.weiny@intel.com>
Subject: RE: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held
Message-ID: <65d5832090c5b_1ada2029473@iweiny-mobl.notmuch>
References: <20240206-cxl-cper-smatch-v2-1-84ed07563c31@intel.com>
 <65d111eb87115_6c745294ac@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65d111eb87115_6c745294ac@dwillia2-xfh.jf.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gF1wqVGwJkHO8gDVZUUkASkHy5lrgLbF73G24QzZrgI2nO/xOljaHLWKh+qu?=
 =?us-ascii?Q?O+vuQ4HM1INyV7f2e5FVZ/On+M8/wMrHfMxWMo/ymKU7958XfXbLGv9mN4AE?=
 =?us-ascii?Q?KpP+FsOimFOlYCCPEHBgGGOazGCrGrn8r8xZTZpxAAuqcEzFb+yVw6U06AJe?=
 =?us-ascii?Q?CZ+CnA5aEYVbMJA1ubfchj/zgtzdAYL3+pgG/k03nd1J9by9iEe/FjsUg80n?=
 =?us-ascii?Q?3DJe+HLuXV4k/UbWuvc7YgH91v1iFwcAcEbhRsRUO1DsNa0veEtqOII7qgTj?=
 =?us-ascii?Q?T34n8/W984nn88/f9VRzbGXao6p8t9c54e0vrO4mPRQBLbDjuxmpACBgilHw?=
 =?us-ascii?Q?Eu6HqvkGDFnvDctXQzxuP5bm+S60+a7ussM/AO3eQ24MAStyDBm5Bw2B2T+5?=
 =?us-ascii?Q?469GhiFOFbKX9T73dnM2nNlK3nzqOIyeTOhwi/47FgOnmmVXO3RhxcVAfzU/?=
 =?us-ascii?Q?AHSW5GfpNHCc3oGXNJem4rMHbu4BQpO0bBpojsAFMY52/Kf2+IheSE7dwkNa?=
 =?us-ascii?Q?wNCUDY8Ds+5nokOLI4po+qPPiliWG1WTfUQdkKuuhFX2qbvSvpPcl37suxQj?=
 =?us-ascii?Q?UV7w+88jSR+Pb75L+/YSZs1CFu/daAa22VEP5T5xdx19nNFRybYvO+wuiVEO?=
 =?us-ascii?Q?obX88jkbOasvWiotpdeGe9ZrroSRhCUfKnL+kwmKzYVatil1Hd3yd4J+Rm58?=
 =?us-ascii?Q?m1fcG5laApfqY+ToKXD5ZvB70g2vdkKIrXIvPCsxgeXgIACUF1sfZxPfYVOy?=
 =?us-ascii?Q?ti0yx4foCA3wCmill/cfppeE75QDARt+K2oa+RAVB9Q8UM/V+G4BTSMLjqQp?=
 =?us-ascii?Q?RfQezHqZt1V1bUDDREL2xbF7zU9TN30ozNh5IlFMeekpYTr5ypsTCcdbAjBZ?=
 =?us-ascii?Q?ZkU6XzBJ9DP2XrCLryVxKTyUwk11zlQSfjE9Qfzfu3idJADg4A+QewRIp7p2?=
 =?us-ascii?Q?5oluCtCRgo8dGWuvjr7cXTDv+U2fJqL7GG6m87RCwyqwf1mPfLgWuRc3ern8?=
 =?us-ascii?Q?KSPTGjVDB5xi2hidZ01HhRc70O20DGS0XC5od7zyt85Qu01zS6lfSZkwq1gh?=
 =?us-ascii?Q?BB+HbGRT/0t69qHFwdmvQ09iEcHzXxiWZJmVdsJSPnYbkrSPsK1gAPzsREfS?=
 =?us-ascii?Q?HsFFQ6c1uVXzqvajJtkUXkyU2YJ14R7/hnm318yRURVPZEBZjNcHWog/5OAm?=
 =?us-ascii?Q?tzDSIlo9uf4Uxys3fcmqGamDPyv4Z1bwAhJXHNDlnIX7HMrwkGu0mN21thJJ?=
 =?us-ascii?Q?4o76oDFZPLn/U3AKxs6+/g6RUAIr/w0MYyDVQPA6AUhlfS3wpluKymeyvSfj?=
 =?us-ascii?Q?TIdgjoMzFIBd7TfwesWYpe+LfYMn8l94HEauDOyay7irKJUHdh+UEcu9DMyL?=
 =?us-ascii?Q?h0LddTW2CsGKihy+iKwrpC04LFFMC9JNeaaSkM1iSUaSQSweCvK3sTU4IjlA?=
 =?us-ascii?Q?hT+8DpzsW3094sHTy/AC9toSJ4ggkUXKy7SMmBS2VYOXdYkj22wunss4/7Y9?=
 =?us-ascii?Q?qgrD5zl1D1wbtIvNzfTQEXuMzjgOOqn+/5VE68+vUiK6laysneCT9ejMPqAk?=
 =?us-ascii?Q?5drvWRuqakIQxQjvEhfJgWYn57Qt4+WaLbj/e8e8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f88575a-cb34-4124-5edf-08dc3299db00
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 04:59:16.6888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NhwV5QPN09+wk1d2ofBNG7gP36cnnOtFSvMLPWk2rGCUY1Wg/McrrXaKBMbxl3ICIwXO8bLqlr0CzBU1Au6AMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8541
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Ira Weiny wrote:

[snip]

> >  
> > -	guard(rwsem_read)(&cxl_cper_rw_sem);
> > -	if (cper_callback)
> > -		cper_callback(event_type, rec);
> 
> Given a work function can be set atomically there is no need to create /
> manage a registration lock. Set a 'struct work' instance to a CXL
> provided routine on cxl_pci module load and restore it to a nop function
> + cancel_work_sync() on cxl_pci module exit.

Ok I'll look into this.

> 
> > +	wi = kmalloc(sizeof(*wi), GFP_ATOMIC);
> 
> The system is already under distress trying to report an error it should
> not dip into emergency memory reserves to report errors. Use a kfifo()
> similar to how memory_failure_queue() avoids memory allocation in the
> error reporting path.

I have a question on ghes_proc() [ghes_do_proc()].  Can they be called by
2 threads at the same time?  It seems like there could be multiple
platform devices which end up queueing into the single kfifo.  So either
there needs to be a kfifo per device or synchronization with multiple
writers.

Ira