Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2160038rdb; Tue, 20 Feb 2024 21:14:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXOMfmzMZsvXFmR9+bgbtyvFVbvKXtKvUE9fVj0n4KziVxVYJT9MOldGydT9Udd08Od7hsepTM7wsjhYM38TWUpEa4k7ZcqFClp8WPlsA== X-Google-Smtp-Source: AGHT+IFTe1ifUiBeWm4VPAqfRlxI74cVc8WfhWSEoUx6SnqOP76IhTF4pG8xqGeyW0NwGSWziFWd X-Received: by 2002:a05:6808:1145:b0:3c1:361e:63b7 with SMTP id u5-20020a056808114500b003c1361e63b7mr20750781oiu.42.1708492446440; Tue, 20 Feb 2024 21:14:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708492446; cv=pass; d=google.com; s=arc-20160816; b=Y8gG1vwML0uMyijK8jqM+JvVu7X0covowYo4ZXXZwS4OiyboeTSxzLFRg8EZnvy1ui 9lMG0Pzc3kUOBjRgxIyp9IgVx98Je4XN7LRhy02bxghtL/ipv82MGKvjA/pI2j8i9Q7t dyH5xsI2NW5/UZX4aakJEmnSCENed0ibdmrBA/IPzHn2zmorbyfAP0I3CTUdEHZqD662 SoJuRj9bDLCyT0I5ZAXIsMjENVfpAQv8AeGHxNIbbfKopsj/wPAZTrV3mpT1fvwCM6kv PmRId+cgHUfQ3hmK0BfncESqrYvsolvQ27Mr/z2SMBX9QGGd5us9L0iEkiNHhmgBphF/ aMIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=4IHEn5Ij4Q9WdVqylbSxFXrKbvlcQbpoMESZ3TkdOkM=; fh=4uWx7tnGuMhOY47Yu3BpbDGeacwRMb1HTIpLlj4EkGI=; b=MDEl+02zCsWL0/qLVFE+0Mz2MeAxP6+a9nuHp4/47IdIPOaIx3K6F6XRfuBV7bsvMH /HXvDbigaAwRwhoj//Se3fNA0c8rjp04ovKvv+2/NLb1e6JQjL2pDqaiQ8h8ord1ZHJz pdEisiS7OLLxDkSESBKSW58d/FCvhpqHkJsTI51BAKmRi8TeLpmGr94kTF7NXYNu/cMV BlNr8g+b3gFN9W1Zik2fk9XBAI/DFy5f8AxKCPY22oDHKercnALXiTzP4wJALICwcxQ6 /lAnEiG+ig5RSuM5Am3HK1/iC7r7dlARIKWGgJHhr1qHq/vozlucH0NsnOttRx2dKVWv WbHg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=p2Tp0qAl; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-74061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74061-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id t19-20020a639553000000b005aaab9e7bcfsi7521356pgn.388.2024.02.20.21.14.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 21:14:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=p2Tp0qAl; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-74061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74061-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 35F35B223A3 for ; Wed, 21 Feb 2024 05:14:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 50D6539AF3; Wed, 21 Feb 2024 05:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p2Tp0qAl" Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EC439ACB for ; Wed, 21 Feb 2024 05:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708492431; cv=none; b=F/l/KcanYltzJxys1k4LCWluoKWwN5SmZ1YWoNE4KOaBElIO55ApYYmB+NymKMGYrB7sNRY/k/hAXHYcTaxb3/6hvYTJjV3dz3mqUbenLZ/OvieRJZy5dWWVo1DIa8G/GkCxxFKlErNozjgJcQhA9HItcPqov945kGDvJ1PGhv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708492431; c=relaxed/simple; bh=1o8mF6TRpVX6l9xjqvqTLqPBoqzums2OqnRKA/cxxfc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QEWw34Z5WZHgQntTGQiKELLa4f1k9aQoAgP73evDaoRuZoxCGL3b7ayXKkrzVYlZOX15bahdmQBca7AR/Ycp51+o9OqioUoZfSQurC4UJiWoZ+6Ak5g+DdYcZyUPt3366Ppn/mkdUFX4LfuiHRkn9FFXuvxtq2vqTtB+Md+HNus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p2Tp0qAl; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Tue, 20 Feb 2024 21:13:40 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708492427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4IHEn5Ij4Q9WdVqylbSxFXrKbvlcQbpoMESZ3TkdOkM=; b=p2Tp0qAl4s6myT2noK2Pjcb5d/Bf5IlTRxVsGnbWmTZQZlEHCddU3koMN42Ryb59ij+2vS gn/4ZaX8jdrcdgzgtUMoOsYrnDL1KNto9sjPCCbrp9wFPYxthMiiR6LerqgYe+oYYMaVJi 73uDVHonoC89JFCN54IgIAUdElYXOVI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Zenghui Yu Cc: Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, Marc Zyngier , James Morse , Suzuki K Poulose , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/10] KVM: arm64: vgic: Store LPIs in an xarray Message-ID: References: <20240216184153.2714504-1-oliver.upton@linux.dev> <20240216184153.2714504-2-oliver.upton@linux.dev> <8c3e4679-08e7-c2bd-2fa4-c6851d080208@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c3e4679-08e7-c2bd-2fa4-c6851d080208@huawei.com> X-Migadu-Flow: FLOW_OUT On Wed, Feb 21, 2024 at 01:11:02PM +0800, Zenghui Yu wrote: > No, you're right. My intention was to fix it in patch #10. And as > you've both pointed out, using xa_erase_irq() can hardly be the correct > fix. My mistake :-( . Still -- thank you for pointing out the very obvious bug at the end of the series :) -- Thanks, Oliver