Received-SPF: pass (google.com: domain of linux-kernel+bounces-74073-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 23:29:54 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Jani Nikula <jani.nikula@linux.intel.com>, Arnd Bergmann
	<arnd@kernel.org>, Oded Gabbay <ogabbay@kernel.org>, Thomas
 =?utf-8?Q?Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com>, "Maarten
 Lankhorst" <maarten.lankhorst@linux.intel.com>, Maxime Ripard
	<mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Dave Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi
	<rodrigo.vivi@intel.com>, Matt Roper <matthew.d.roper@intel.com>, "Matthew
 Brost" <matthew.brost@intel.com>, Riana Tauro <riana.tauro@intel.com>,
	"Daniele Ceraolo Spurio" <daniele.ceraolospurio@intel.com>,
	<intel-xe@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, Stephen Rothwell <sfr@rothwell.id.au>
Subject: Re: Re: [PATCH] drm/xe: skip building debugfs code for
 CONFIG_DEBUG_FS=n
Message-ID: <ngu6vq5izal6suyr57p4vlxnrn4kxyii4ewdktxvw7k3uezlcz@6oevav3wpcjh>
References: <20240213134817.3347574-1-arnd@kernel.org>
 <877cj88lck.fsf@intel.com>
 <17209419-093b-4674-8b43-06c92312ef61@app.fastmail.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <17209419-093b-4674-8b43-06c92312ef61@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dYM+ilssFElxHFJz/EUjheRCnhvIBdtpOQJFlutj/DAK9D9BRLpIV4IXBO4g?=
 =?us-ascii?Q?dRkSOVfzFdSgoniYANhBCywVsgtmaQORPFuYfTZP/bZ6Q9dgsZl97kT3KEPo?=
 =?us-ascii?Q?XRgAbOjsnZmFH+NV/066waTF/CvT23Hnu80S4+I995BImOnVb5ZanFnsPYlO?=
 =?us-ascii?Q?oYNbOjPxu3TBLAvrKXBM8JEl2+XCNpeMp1HvwQTYkQ7d16fIIxmi6HknJutN?=
 =?us-ascii?Q?iemS5lp0WFnmv/0esxdWsgCImrO+9FgSU5G9d6NtjEivgH8zOeEArtvsiP/S?=
 =?us-ascii?Q?jo8hO3dj7wLit8g6jAKYoh7CNEyIbP7cT5+7aSqoiPutNgnxG+nqqtxocREN?=
 =?us-ascii?Q?bUkqiHVefFMkAQPiR2NZBOP2qzgITxEXji437X+hrhCCoPoQ2wyPBbhsFMgy?=
 =?us-ascii?Q?zAqdI5jc/VsfdRVdBUsJyPHCbwAZ5RPUixnoHu19xiLJFsqQ6wn46DKmNIny?=
 =?us-ascii?Q?3HaG0tMF4T3A/PZRP2Z6Tc3YOEaTMUGZCMWyh6MDo1vIxjjozk2rrylbptks?=
 =?us-ascii?Q?cJTiSS0JcsEN24BHfw6z11VGigz8ud3N0eRqgjX/1WjTITfqVWPCnOTwePWu?=
 =?us-ascii?Q?0yduZzlL5dTOhyBinXp1G6hXVyBvTPREf9a8e9cPlQ3STZnu3bGHP0XwRgFE?=
 =?us-ascii?Q?qT4ENGVvCZ8fLaZU9q1G0nDjB4LTziloMKaSEdA+2N3iLevR25oGVC7lA77e?=
 =?us-ascii?Q?skqg4d1oSRATCqTerHUO35u6IAKb1zX86Rib5j3Xusm1wShgZh11UOX7Dkbp?=
 =?us-ascii?Q?CvCErZLzLnQyIsoFRUT1gzmmTrQ0NW0P0u81KNvwRSHNZXy+ZTbtQcnnAx/N?=
 =?us-ascii?Q?27f5xK28FQ9ERd+Gt7/n07VK9O0GqfHsZe0/lV+9xBSsquMSi3OZFr/Hmz+i?=
 =?us-ascii?Q?8YXXoK2YqNcG5PGn4uj+q825vEr2U8nrH1pjV9agM0HURRHrQUmh7nE/Djij?=
 =?us-ascii?Q?Y1yQ3xoqfWrDBosVzvnV8rL4puxAkANy+G8ko5l3kCFLPXNuqBe4OiVAb2M/?=
 =?us-ascii?Q?SsDjFKW2iP0KpX1fHTpmvxG1JcQNjh105tzZiu1S4y56FXL6/qH/c4S/Sz12?=
 =?us-ascii?Q?q99616CB5YxzcyDVtC4uH+AkdcID4rTZNs+a2+9qWVe72fsIz4jrXj8e9Nxz?=
 =?us-ascii?Q?7uAhmMlAOZx0X6XpjsM0gPHWKwZMQgqF0zAyV0wg54sGWrX4J/aLQ+VE/3GL?=
 =?us-ascii?Q?WGdZCDP2dljzLZ+Cu5TDTeJTn/+IxjQ3zqBmFGQNXCMVkb1vI3NXdcpePtOY?=
 =?us-ascii?Q?fUB01bAOc5XNo4SXZXsaVujzwX+wAFSGElYc4oxWoCmDxIf8rtok/DoQRKSH?=
 =?us-ascii?Q?hVG/YIAJ17VI96rr0JsrsvhXGuONFi49VCkPt0WqDZo7cZ5G7ucTwfw/EdXe?=
 =?us-ascii?Q?O99gv3/VsEGWm/DsSSioq/6Mu6acge2dpMB0vNo8Vhh4mO/qYvKAf0Z7vPo0?=
 =?us-ascii?Q?LlEK9vULuDlR+xi6hDq06vdAlG2wP6GC5uA/CtY6BSg0Tz1GGh3Zk0BQ5q9R?=
 =?us-ascii?Q?nPNsfnFNyWGrNTSpnGXHr3W1cMc5xyaL5VTHg5SKq61ma1JBi9XQ3wTz6Ets?=
 =?us-ascii?Q?5APGH2JjedtfYYBKMTEVYk6UqT1t0HrKjNyGjh8KJr9PtYa4bCYcWwFh5M52?=
 =?us-ascii?Q?iw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de1e3478-cc4c-4107-8a7a-08dc329e24df
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 05:29:58.6202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 06DlL/u3Gr9QI136sy5+C+D3XxMn6yO+irj4YhgdoL+7FIcoSVgfERlzuf10AdJkivixjySzLYpAfQMiJeY8Fps4RlJab1X08Rc6ZXTrmYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7318
X-OriginatorOrg: intel.com

+Stephen

On Tue, Feb 13, 2024 at 03:58:54PM +0100, Arnd Bergmann wrote:
>On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote:
>> On Tue, 13 Feb 2024, Arnd Bergmann <arnd@kernel.org> wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Some of the debugfs functions are stubbed out in these configurations,
>>> so trying to build the .c file with the definition fails:
>>>
>>> In file included from include/uapi/linux/posix_types.h:5,
>>>                  from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27:
>>> drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level:
>>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
>>>     8 | #define NULL ((void *)0)
>>>       |                ^~~~
>>> drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources'
>>>   549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc,
>>>       |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Stop trying to build them by making the Makefile entries conditional,
>>> same as for the i915 driver.
>>
>> Already fixed by commit 439987f6f471 ("drm/xe: don't build debugfs files
>> when CONFIG_DEBUG_FS=n") in drm-xe-next.
>>
>> Maybe that needs to be picked up for -fixes?
>
>I made sure that this still happens in linux-next today, but
>it does not seem to contain 439987f6f471.

Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e
it seems we still don't have drm-xe-next branch in linux-next.

Stephen, could you please add it? Or do I have to do something on my end
before that?  This is the branch:

https://gitlab.freedesktop.org/drm/xe/kernel drm-xe-next

thanks
Lucas De Marchi


>
>     Arnd