Received-SPF: pass (google.com: domain of linux-kernel+bounces-74092-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 20 Feb 2024 21:41:24 -0800
From: Eric Biggers <ebiggers@kernel.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Zhaoyang Huang <huangzhaoyang@gmail.com>, steve.kang@unisoc.com
Subject: Re: [Resend PATCHv9 1/1] block: introduce content activity based
 ioprio
Message-ID: <20240221054124.GA14358@sol.localdomain>
References: <20240221052624.573287-1-zhaoyang.huang@unisoc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240221052624.573287-1-zhaoyang.huang@unisoc.com>

On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote:
> +/*
> + * bio_set_active_ioprio_folio is helper function to count the bio's
> + * content's activities which measured by MGLRU.
> + * The file system should call this function after bio_add_page/folio for
> + * the buffered read/write/sync.
> + */
> +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)

How did you test this?  Nothing calls this function, so this patch can't
actually be doing anything.  Are you planning to update any filesystems to use
this?

- Eric