Received-SPF: pass (google.com: domain of linux-kernel+bounces-74114-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240221052624.573287-1-zhaoyang.huang@unisoc.com> <20240221054124.GA14358@sol.localdomain>
In-Reply-To: <20240221054124.GA14358@sol.localdomain>
From: Zhaoyang Huang <huangzhaoyang@gmail.com>
Date: Wed, 21 Feb 2024 13:50:55 +0800
Message-ID: <CAGWkznHTY-ROF-D2w8BjGabfzw1yAqoGsHz321BUKrRBcWuqaw@mail.gmail.com>
Subject: Re: [Resend PATCHv9 1/1] block: introduce content activity based ioprio
To: Eric Biggers <ebiggers@kernel.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>, Jens Axboe <axboe@kernel.dk>, 
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, 
	steve.kang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 1:41=E2=80=AFPM Eric Biggers <ebiggers@kernel.org> =
wrote:
>
> On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote:
> > +/*
> > + * bio_set_active_ioprio_folio is helper function to count the bio's
> > + * content's activities which measured by MGLRU.
> > + * The file system should call this function after bio_add_page/folio =
for
> > + * the buffered read/write/sync.
> > + */
> > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
>
> How did you test this?  Nothing calls this function, so this patch can't
> actually be doing anything.  Are you planning to update any filesystems t=
o use
> this?
Thanks for asking. I verified this patch in an Android based 6GB RAM
system by modifying EROFS/F2FS/EXT4's aops API which I didn't
upstreaming yet. I would like to recommend this to the desired fs if
this is accepted.
>
> - Eric