Received-SPF: pass (google.com: domain of linux-kernel+bounces-74117-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 21:52:56 -0800
From: Eric Biggers <ebiggers@kernel.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
	Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, steve.kang@unisoc.com
Subject: Re: [Resend PATCHv9 1/1] block: introduce content activity based
 ioprio
Message-ID: <20240221055256.GB14358@sol.localdomain>
References: <20240221052624.573287-1-zhaoyang.huang@unisoc.com>
 <20240221054124.GA14358@sol.localdomain>
 <CAGWkznHTY-ROF-D2w8BjGabfzw1yAqoGsHz321BUKrRBcWuqaw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAGWkznHTY-ROF-D2w8BjGabfzw1yAqoGsHz321BUKrRBcWuqaw@mail.gmail.com>

On Wed, Feb 21, 2024 at 01:50:55PM +0800, Zhaoyang Huang wrote:
> On Wed, Feb 21, 2024 at 1:41 PM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Wed, Feb 21, 2024 at 01:26:24PM +0800, zhaoyang.huang wrote:
> > > +/*
> > > + * bio_set_active_ioprio_folio is helper function to count the bio's
> > > + * content's activities which measured by MGLRU.
> > > + * The file system should call this function after bio_add_page/folio for
> > > + * the buffered read/write/sync.
> > > + */
> > > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> > > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
> >
> > How did you test this?  Nothing calls this function, so this patch can't
> > actually be doing anything.  Are you planning to update any filesystems to use
> > this?
> Thanks for asking. I verified this patch in an Android based 6GB RAM
> system by modifying EROFS/F2FS/EXT4's aops API which I didn't
> upstreaming yet. I would like to recommend this to the desired fs if
> this is accepted.

This patch needs to come with a user.  Unused code can't be accepted.

- Eric