Received-SPF: pass (google.com: domain of linux-kernel+bounces-74131-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <133770ce-98b0-4e36-b21e-1468c45fad0e@amd.com>
Date: Wed, 21 Feb 2024 11:44:16 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct
 acp_quirk_entry
Content-Language: en-US
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 Liam Girdwood <lgirdwood@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
 Bard Liao <yung-chuan.liao@linux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
 Daniel Baluta <daniel.baluta@nxp.com>,
 Kai Vehmanen <kai.vehmanen@linux.intel.com>, Mark Brown
 <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>
Cc: sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20240220201623.438944-1-cristian.ciocaltea@collabora.com>
 <20240220201623.438944-2-cristian.ciocaltea@collabora.com>
From: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
In-Reply-To: <20240220201623.438944-2-cristian.ciocaltea@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDRsbkc1cGNkMXRlVjZ4UzB0eHB0N3lWMk1qaVVCMWNQSW9hQyt1aWtGajlR?=
 =?utf-8?B?STR3ZUFHdzljS2pzZHRTK1E1WkVKOGhKZWxuNVZWZGJKR2RZNUg4VlNtUVJx?=
 =?utf-8?B?eXB0TUM2RzN3TkRlNEYwbVFYZWNjbFhFSUpibStSMGhvSFNoeWpnWnNqd0lE?=
 =?utf-8?B?Ri9JbkM0SS8wcTdCb0RnaE1odUZBOFVXRjZqbGIrZG5LM2FYTXc0UjExWXlU?=
 =?utf-8?B?cXNGWWFmRnAxNjhOaENxYXkzaHM4dTh0SXp5Z0lyUXE2QktsRnoxYng4RXFC?=
 =?utf-8?B?R1ZJQm91S1JrbVZ4eHJnV0trREpMbmZBc1NEaDdLWG1hQTUzNGVnak1yeDBQ?=
 =?utf-8?B?M2QvOXpqd1luN1VZRUZMaE45TENwdCtOOXdWb3h3Y0hvTHFCVVN5VGtWaVA2?=
 =?utf-8?B?bC9oKytMeUFZN3lHN1VKdERudXh0Z1J2UWtaeXBxV1dhMnJlTjI4aWp0TDhw?=
 =?utf-8?B?ZEtHMWtjQkxnMVh1dWNyM2ViRHhja0IyTVJVaDRiQ2crQ2Z2R1oxRHU4RElv?=
 =?utf-8?B?KzJaMkYzMXQ5MCt2N09YYkhRSFVkOWM3UTFHUDNFbkRkcDlVU0xWdHpjWEJ2?=
 =?utf-8?B?V1B2ZjZtT2hTUlVxV09BTS84RU9Qcy9ycnVQQi9QaFJSV3BkUVFxM1hmTWEx?=
 =?utf-8?B?OXZ6ay9lc3hYYmdjejZDSTF1MjdmVEUwQzk4VlFyYWYvVW9BVHFYU3R4U215?=
 =?utf-8?B?M0Z4U3lVdmxSaHpXOHBWd0lwQURDWklpVXpkaEIrWGVEU1BuandlWXVpY2dH?=
 =?utf-8?B?dUxjeEdMblV5UGh6RHBrMy9XbE5yZkVYcEhoZndXd21OMkdnUkJjdmxZcnVt?=
 =?utf-8?B?YVFHRW95KzJHNHF6T3pYclc0aGZhRzIvZTgrakdrUmlBQm0yZ2J3T0YzRGpu?=
 =?utf-8?B?eSt4YWtFT3VySjdRd2JDdW0rKzdEZ1UxVnBLUFV3TEpJL3psbDQ1Ykxyam1R?=
 =?utf-8?B?YkVmQ1pJNlFRUUNFTGZYdXd6VmFuUDNJdTVaU3lnb2w5dzFkdGVCaHlzbzlY?=
 =?utf-8?B?OUcvbHB5Mkh3R1Y3LytlekRNT2NvOGM3VzY3TGt3MnlQdkpldGN0em9Qc0Va?=
 =?utf-8?B?bW5FVU1oQW5OT2RzdGJ4azROU0FpS00vQzUvRVRzUW9QS3BUWGd2NHlvYXN5?=
 =?utf-8?B?VDB0ZVljRHdxNmRzSTlza1RhbkdyNWNGVDlScm1sbUFGRi8rTlZkZ25IK3dF?=
 =?utf-8?B?UVg3V2QzLzJIcW1ITjhza1FDcHVEYlhYVFNDdzBZQWtqbGtneE42c3dOd1JC?=
 =?utf-8?B?QXFkKzBXZjYwLzhkVkdTOEhmdXlvekFXZUVLN2dZbWpxcFdPV0xSTHpUbmdH?=
 =?utf-8?B?WWt2MEVTZ09QbHhzYm9lTjF6VEM5QWhsYWRIY0NxK3J2NUE2V25xMHJVOVFw?=
 =?utf-8?B?aE9ic3NTSlBGTkczK1pSK2ludXNXQS9pRjNIOHJCYVpDL3Y3ZEd3TEI4cGxi?=
 =?utf-8?B?eExDZGEzZjBCK09aR25zK29ZSmRqOGxsWmYvS3dzTUVuZ2g1L1p5d0J4NmUz?=
 =?utf-8?B?aW9PRnYvQ2J1SCtaTTNTYUIza3ppQkZrU3RtdmZscHZVSGF4ZGF4MUlnNVls?=
 =?utf-8?B?SkthRDJrckVvRllCVnM3NEdLdHpOK2d5Yk5vSXhQVERlSjRPYlg0SWRmcCtv?=
 =?utf-8?B?MlhhOXdMSGZVWkxtdE5CU3Z2ODJYU3dCUlBIREQxdHN4RXF3bjVCNlVqRDRt?=
 =?utf-8?B?Z3k5dldqQ094eU4wM1pFeDYrdS9vdjBMeVhlT1NsQlBHQlhINk1CMU5kY2p3?=
 =?utf-8?B?SU1wYzJPSldMcVhSOFptb1o0bDZWLzFEYUNibzlEUWw1cFJTeWtaY2srVysw?=
 =?utf-8?B?UDM3ZFJWZ0laOWJDTmxuUjVYUzllMjN4elZoVUNkZGRFaEdCYWpWL2liVG16?=
 =?utf-8?B?RDFrSG5SUC9raUdzeUNhMExQQURsWVVCT3RYMWVFT2M0MjQ0QWk3bTg3L0dJ?=
 =?utf-8?B?MW5ldzIwTE9NbzFZQTZMZWp5bFRENlJqa1hQYUpsb3MvOXNweGlmZDFwY2RB?=
 =?utf-8?B?Ly9kWm5BaVhteUMvOXdZSCtZZmlwMEdDOEVqU1R6cjZLSFVBZ01OM1g3MUU2?=
 =?utf-8?B?NUVvbmYrcVlSWSs1emVKdk96bTdFWGtwTGxmY2h2SlQ1WVB4V2V3a3c0eUl0?=
 =?utf-8?Q?ROvX6BwjuX75vLs4K4ijXQhje?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38968bb2-8800-4086-467d-08dc32a45ae1
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5951.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 06:14:26.3872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VD4+KDouV5J8HGM3SC/NKEsM9JMkXVwR7WlopYeTxgH4uX5DWbdFP6k/cuLGCVQnsvkbl15IgA93UsFr5cvw1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5918


On 2/21/24 01:46, Cristian Ciocaltea wrote:
> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
> signed firmware support in the driver via the acp_sof_quirk_table.
>
> In preparation to support additional use cases of the quirk table (i.e.
> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
> and update all references to it accordingly.
>
> No functional changes intended.

If there are no new flags currently being used in this patch, and also
no functional changes added, in this case this patch is really required?

Also please use scripts/get_maintainer.pl in CC while sending patches, 
then only
maintainers get notified your changes.

>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>   sound/soc/sof/amd/acp-loader.c |  2 +-
>   sound/soc/sof/amd/acp.c        | 47 ++++++++++++++++++----------------
>   sound/soc/sof/amd/acp.h        |  6 ++++-
>   sound/soc/sof/amd/vangogh.c    |  9 +++++--
>   4 files changed, 38 insertions(+), 26 deletions(-)
>
> diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c
> index d2d21478399e..aad904839b81 100644
> --- a/sound/soc/sof/amd/acp-loader.c
> +++ b/sound/soc/sof/amd/acp-loader.c
> @@ -173,7 +173,7 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev)
>   
>   	adata = sdev->pdata->hw_pdata;
>   
> -	if (adata->signed_fw_image)
> +	if (adata->quirks && adata->quirks->signed_fw_image)
>   		size_fw = adata->fw_bin_size - ACP_FIRMWARE_SIGNATURE;
>   	else
>   		size_fw = adata->fw_bin_size;
> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
> index 9b3c26210db3..9d9197fa83ed 100644
> --- a/sound/soc/sof/amd/acp.c
> +++ b/sound/soc/sof/amd/acp.c
> @@ -20,12 +20,14 @@
>   #include "acp.h"
>   #include "acp-dsp-offset.h"
>   
> -#define SECURED_FIRMWARE 1
> -
>   static bool enable_fw_debug;
>   module_param(enable_fw_debug, bool, 0444);
>   MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>   
> +static struct acp_quirk_entry quirk_valve_galileo = {
> +	.signed_fw_image = true,
> +};
> +
>   const struct dmi_system_id acp_sof_quirk_table[] = {
>   	{
>   		/* Steam Deck OLED device */
> @@ -33,7 +35,7 @@ const struct dmi_system_id acp_sof_quirk_table[] = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
>   		},
> -		.driver_data = (void *)SECURED_FIRMWARE,
> +		.driver_data = &quirk_valve_galileo,
>   	},
>   	{}
>   };
> @@ -254,7 +256,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
>   		}
>   	}
>   
> -	if (adata->signed_fw_image)
> +	if (adata->quirks && adata->quirks->signed_fw_image)
>   		snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
>   
>   	snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
> @@ -738,26 +740,27 @@ int amd_sof_acp_probe(struct snd_sof_dev *sdev)
>   	sdev->debug_box.offset = sdev->host_box.offset + sdev->host_box.size;
>   	sdev->debug_box.size = BOX_SIZE_1024;
>   
> -	adata->signed_fw_image = false;
>   	dmi_id = dmi_first_match(acp_sof_quirk_table);
> -	if (dmi_id && dmi_id->driver_data) {
> -		adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> -						    "sof-%s-code.bin",
> -						    chip->name);
> -		if (!adata->fw_code_bin) {
> -			ret = -ENOMEM;
> -			goto free_ipc_irq;
> +	if (dmi_id) {
> +		adata->quirks = dmi_id->driver_data;
> +
> +		if (adata->quirks->signed_fw_image) {
> +			adata->fw_code_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> +							    "sof-%s-code.bin",
> +							    chip->name);
> +			if (!adata->fw_code_bin) {
> +				ret = -ENOMEM;
> +				goto free_ipc_irq;
> +			}
> +
> +			adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> +							    "sof-%s-data.bin",
> +							    chip->name);
> +			if (!adata->fw_data_bin) {
> +				ret = -ENOMEM;
> +				goto free_ipc_irq;
> +			}
>   		}
> -
> -		adata->fw_data_bin = devm_kasprintf(sdev->dev, GFP_KERNEL,
> -						    "sof-%s-data.bin",
> -						    chip->name);
> -		if (!adata->fw_data_bin) {
> -			ret = -ENOMEM;
> -			goto free_ipc_irq;
> -		}
> -
> -		adata->signed_fw_image = dmi_id->driver_data;
>   	}
>   
>   	adata->enable_fw_debug = enable_fw_debug;
> diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h
> index 947068da39b5..b648ed194b9f 100644
> --- a/sound/soc/sof/amd/acp.h
> +++ b/sound/soc/sof/amd/acp.h
> @@ -207,6 +207,10 @@ struct sof_amd_acp_desc {
>   	u64 sdw_acpi_dev_addr;
>   };
>   
> +struct acp_quirk_entry {
> +	bool signed_fw_image;
> +};
> +
>   /* Common device data struct for ACP devices */
>   struct acp_dev_data {
>   	struct snd_sof_dev  *dev;
> @@ -236,7 +240,7 @@ struct acp_dev_data {
>   	u8 *data_buf;
>   	dma_addr_t sram_dma_addr;
>   	u8 *sram_data_buf;
> -	bool signed_fw_image;
> +	struct acp_quirk_entry *quirks;
>   	struct dma_descriptor dscr_info[ACP_MAX_DESC];
>   	struct acp_dsp_stream stream_buf[ACP_MAX_STREAM];
>   	struct acp_dsp_stream *dtrace_stream;
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index de15d21aa6d9..bc6ffdb5471a 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -143,6 +143,7 @@ EXPORT_SYMBOL_NS(sof_vangogh_ops, SND_SOC_SOF_AMD_COMMON);
>   int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
>   {
>   	const struct dmi_system_id *dmi_id;
> +	struct acp_quirk_entry *quirks;
>   
>   	/* common defaults */
>   	memcpy(&sof_vangogh_ops, &sof_acp_common_ops, sizeof(struct snd_sof_dsp_ops));
> @@ -151,8 +152,12 @@ int sof_vangogh_ops_init(struct snd_sof_dev *sdev)
>   	sof_vangogh_ops.num_drv = ARRAY_SIZE(vangogh_sof_dai);
>   
>   	dmi_id = dmi_first_match(acp_sof_quirk_table);
> -	if (dmi_id && dmi_id->driver_data)
> -		sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> +	if (dmi_id) {
> +		quirks = dmi_id->driver_data;
> +
> +		if (quirks->signed_fw_image)
> +			sof_vangogh_ops.load_firmware = acp_sof_load_signed_firmware;
> +	}
>   
>   	return 0;
>   }