Received-SPF: pass (google.com: domain of linux-kernel+bounces-74275-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Zhang, Tina" <tina.zhang@intel.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, jean-philippe <jean-philippe@linaro.org>,
	Jason Gunthorpe <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iommu: Fix iommu_sva_bind_device to the same domain
Thread-Topic: [PATCH] iommu: Fix iommu_sva_bind_device to the same domain
Thread-Index: AQHaZI3Wtb0WdVGjR0SZSXyMH/XcCLEUanmw
Date: Wed, 21 Feb 2024 07:59:06 +0000
Message-ID: <MW5PR11MB5881E20A89840306C977F3FA89572@MW5PR11MB5881.namprd11.prod.outlook.com>
References: <20240221061832.430-1-zhangfei.gao@linaro.org>
In-Reply-To: <20240221061832.430-1-zhangfei.gao@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Oh1lwck0TdLgHj5+f13gbPcruBEgflIMZ3Z1kTTn7Cew4cs+9OJiTJGybNvN?=
 =?us-ascii?Q?2pQEqmufCmRB7COOD7j2UpvpAxSxnephCqc5ZnaJdepib0VzoL1+Dq6spWL8?=
 =?us-ascii?Q?JrjIK/CTpApi/P5s7NqAh+YmnEI6x/C4eC+G7qb95PaGhpNjosvQRD5shnB0?=
 =?us-ascii?Q?ampBPlKh0NEXi2F6ipVxhFFfXVGloXSTYvg4vfC6ayAJ7JDW0yp7yDmziVZK?=
 =?us-ascii?Q?8l+LALvbO7n6Am6d/H5j1j7z+w6ost9oDxr7mIApBWJzgQTtS8LBGKVEiuNi?=
 =?us-ascii?Q?CmwakIAZnnXkbKinhUzaB0wTYZVH58+SxGl1585fI5wJd7lALem0OCjxFCdT?=
 =?us-ascii?Q?5W2uvQENUCPHEeZM8I+IHL+g5YqRRXg49agLbBQCQMCG6D9tgqeypSSKbKT4?=
 =?us-ascii?Q?FplR2RtdnzEb4FXoZhS0N6G8VuRHxYL9JbNfeyeg6WX2CdnQj92DLrQB9gwE?=
 =?us-ascii?Q?kr4Ge4goK2aoi9wb0Gg2WvqqKrUPid8Woxqp3TAoboUVqtMyKHcMiwQ8BXZT?=
 =?us-ascii?Q?qr8p/Z4GtugwZ30tk2w+SQLq1S3Te0rDrCa62RdXJ0o/Trg4kXEs7LbNdqOi?=
 =?us-ascii?Q?KqnQwUxI5ijqMlIlbsCR+shiM5MOSjoOvUgTdqPC3YxUZWzQ4s5hqoxm6xkt?=
 =?us-ascii?Q?PVt5wqfv+rSmxjWLAfl3nQmf1wj1VSlres0X2aTTwcHUZ5Llm6oIW4ppUpeL?=
 =?us-ascii?Q?vk6PMOQqYZbGheMS9tmZMyRiaq0710up843dbbGdEV9BtwPjwbzwogQy260I?=
 =?us-ascii?Q?gj8lDftU1ww3aFWVnuB8KPXY0+K0xWo4wfavLKAqorXAIctNPHRWOCAbxXVY?=
 =?us-ascii?Q?tsTEq/rM7rjXWABNhPybbA5Jx/1W++S38kUZX9mPq2O/7um+Zw8t6umLZNB5?=
 =?us-ascii?Q?ElPMoZ0Gbrpw2TnrDIbpDKeMDcxm9Xx9mL1q7fgcxFcGxTXOt+QYyL4GefuN?=
 =?us-ascii?Q?JvyNC4nViQO2P0aR36glPwPAXZXnJcLqJ02ZL+FxAkoBEEP2aS5kX+H5G6NK?=
 =?us-ascii?Q?nqd9aq47iKKdfhi8DCZBnPJT4onlscMx8NLbjCv//SU9okHv2lIFYpZdO1Qg?=
 =?us-ascii?Q?CfcvjdyeCgSMcj6verNV3vJR9IIE9jzLcB2SdC83e7WnAdlbeDpT/i618adh?=
 =?us-ascii?Q?YH7OnIqh6GJ50y9k+8sxhs0ywZhB7ft6ZfKrw6PCDfl62VKV7068wyaGdwLW?=
 =?us-ascii?Q?tGb32SiMgMYxDalScaJf/D3Scfstxqu7KQLjDVQzI8uNjWK/Y00mi8v1KLBX?=
 =?us-ascii?Q?K6TM6K32V/23LblNPmrwNpAbXB1L00roNi4IeRmnH0e0uDJSJ1MS0dY7LeVT?=
 =?us-ascii?Q?mnFMeBll9ZKSCrh3xp3xfWOskxQx6HeyuAOFRkpB+IP7oM4TypTfPzvrqKQj?=
 =?us-ascii?Q?2wy4gaY4XCwifw5f9rQ8xc/xCVGcoIDSfMfVx7VpA6CPke7ZvWHLC0y0m+Zc?=
 =?us-ascii?Q?XGhdePK2rj2BudHVvbSZwS7dJL5t5LiU0GYpexOwyIR+fx4hvHtKcg/RTVGi?=
 =?us-ascii?Q?jAK24f0ZGnd92FtiyTs0OsjxSeZQJyB4Vn8m9sSDwgJO8LQYwopHkGzoOJ96?=
 =?us-ascii?Q?QCZNKMd9ACuRg793gk0m/GfwsqisYvcV7e3Nra0T?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a70eb863-f1c0-49fb-a0d6-08dc32b2fa93
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 07:59:06.8945
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 65zDTLnPWPFAk8gKm9strl3AX1AZ8hEzg6V5qI3UYNhO05eDCAzYF6TZaN2RFEbuBz5GTVxxd+W6IlAORNYoYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6471
X-OriginatorOrg: intel.com

Hi,

> -----Original Message-----
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
> Sent: Wednesday, February 21, 2024 2:19 PM
> To: Joerg Roedel <joro@8bytes.org>; Will Deacon <will@kernel.org>; jean-
> philippe <jean-philippe@linaro.org>; Jason Gunthorpe <jgg@nvidia.com>;
> baolu.lu@linux.intel.com; Zhang, Tina <tina.zhang@intel.com>
> Cc: iommu@lists.linux.dev; linux-kernel@vger.kernel.org; Zhangfei Gao
> <zhangfei.gao@linaro.org>
> Subject: [PATCH] iommu: Fix iommu_sva_bind_device to the same domain
>=20
> The accelerator dev can provide multi-queue and bind to the same domain i=
n
> multi-thread for better performance, and domain refcount takes care of it=
.
>=20
> 'commit 092edaddb660 ("iommu: Support mm PASID 1:n with sva domains")'
> removes the possibility, so fix it
>=20
> Fixs: '092edaddb660 ("iommu: Support mm PASID 1:n with sva domains")'
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>  drivers/iommu/iommu-sva.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c index
> c3fc9201d0be..a95c8f3a5407 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -91,7 +91,7 @@ struct iommu_sva *iommu_sva_bind_device(struct
> device *dev, struct mm_struct *mm
>  	/* Search for an existing domain. */
>  	list_for_each_entry(domain, &mm->iommu_mm->sva_domains, next)
> {
>  		ret =3D iommu_attach_device_pasid(domain, dev, iommu_mm-
> >pasid);
> -		if (!ret) {
> +		if (!ret || ret =3D=3D -EBUSY) {
If rebinding is allowed, how could IOMMU core know if this invocation is in=
tended (like the multi-thread case mentioned in the commit message) or is m=
istakenly invoked?

Thanks,
-Tina

>  			domain->users++;
>  			goto out;
>  		}
> @@ -141,8 +141,8 @@ void iommu_sva_unbind_device(struct iommu_sva
> *handle)
>  	struct device *dev =3D handle->dev;
>=20
>  	mutex_lock(&iommu_sva_lock);
> -	iommu_detach_device_pasid(domain, dev, iommu_mm->pasid);
>  	if (--domain->users =3D=3D 0) {
> +		iommu_detach_device_pasid(domain, dev, iommu_mm-
> >pasid);
>  		list_del(&domain->next);
>  		iommu_domain_free(domain);
>  	}
> --
> 2.34.1