Received-SPF: pass (google.com: domain of linux-kernel+bounces-74294-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <10ad8f935e598244d4cb68aa20130952a26ba2ef.camel@ew.tq-group.com>
Subject: Re: [PATCH 6.1 000/197] 6.1.79-rc1 review
From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Daniel =?ISO-8859-1?Q?D=EDaz?= <daniel.diaz@linaro.org>, Greg
	Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org
Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org, 
 torvalds@linux-foundation.org, akpm@linux-foundation.org,
 linux@roeck-us.net,  shuah@kernel.org, patches@kernelci.org,
 lkft-triage@lists.linaro.org,  pavel@denx.de, jonathanh@nvidia.com,
 f.fainelli@gmail.com,  sudipm.mukherjee@gmail.com, srw@sladewatkins.net,
 rwarsow@gmx.de, conor@kernel.org,  allen.lkml@gmail.com, Christophe Leroy
 <christophe.leroy@csgroup.eu>, Michael Ellerman <mpe@ellerman.id.au>
Date: Wed, 21 Feb 2024 09:16:32 +0100
In-Reply-To: <7e1faa29-a154-41fc-aebc-38d5f355ea90@linaro.org>
References: <20240220204841.073267068@linuxfoundation.org>
	 <c873370c-c12f-4f03-a722-1ae59743089b@linaro.org>
	 <7e1faa29-a154-41fc-aebc-38d5f355ea90@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-02-20 at 19:40 -0600, Daniel D=C3=ADaz wrote:
> ********************
> Achtung externe E-Mail: =C3=96ffnen Sie Anh=C3=A4nge und Links nur, wenn =
Sie wissen, dass diese aus einer sicheren Quelle stammen und sicher sind. L=
eiten Sie die E-Mail im Zweifelsfall zur Pr=C3=BCfung an den IT-Helpdesk we=
iter.
> Attention external email: Open attachments and links only if you know tha=
t they are from a secure source and are safe. In doubt forward the email to=
 the IT-Helpdesk to check it.
> ********************
>=20
> Hello!
>=20
> On 20/02/24 7:04 p.=C2=A0m., Daniel D=C3=ADaz wrote:
> > On 20/02/24 2:49 p.=C2=A0m., Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.1.79 release.
> > > There are 197 patches in this series, all will be posted as a respons=
e
> > > to this one.=C2=A0 If anyone has any issues with these being applied,=
 please
> > > let me know.
> > >=20
> > > Responses should be made by Thu, 22 Feb 2024 20:48:08 +0000.
> > > Anything received after that time might be too late.
> > >=20
> > > The whole patch series can be found in one patch at:
> > > =C2=A0=C2=A0=C2=A0=C2=A0https://www.kernel.org/pub/linux/kernel/v6.x/=
stable-review/patch-6.1.79-rc1.gz
> > > or in the git tree and branch at:
> > > =C2=A0=C2=A0=C2=A0=C2=A0git://git.kernel.org/pub/scm/linux/kernel/git=
/stable/linux-stable-rc.git linux-6.1.y
> > > and the diffstat can be found below.
> > >=20
> > > thanks,
> > >=20
> > > greg k-h
> >=20
> > We see a regression with PowerPC:
> >=20
> > -----8<-----
> >  =C2=A0 /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S: Assembler me=
ssages:
> >  =C2=A0 /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S:124: Error: u=
nrecognized opcode: `sym_func_start_local(setup_g2_le_hid2)'
> >  =C2=A0 /builds/linux/arch/powerpc/kernel/cpu_setup_6xx.S:131: Error: u=
nrecognized opcode: `sym_func_end(setup_g2_le_hid2)'
> >  =C2=A0 make[4]: *** [/builds/linux/scripts/Makefile.build:382: arch/po=
werpc/kernel/cpu_setup_6xx.o] Error 1
> > ----->8-----
> >=20
> > This is seen only on PowerPC with GCC 8, GCC 13, Clang 17, Clang nightl=
y, on:
> > * allnoconfig
> > * tinyconfig
> > * mpc83xx_defconfig
> > * ppc6xx_defconfig
> > (at least)
> >=20
> > Reproducer:
> >=20
> >  =C2=A0 tuxmake \
> >  =C2=A0=C2=A0=C2=A0 --runtime podman \
> >  =C2=A0=C2=A0=C2=A0 --target-arch powerpc \
> >  =C2=A0=C2=A0=C2=A0 --toolchain gcc-8 \
> >  =C2=A0=C2=A0=C2=A0 --kconfig tinyconfig
> >=20
>=20
> Bisection points to:
>=20
>    commit a65d7a833f486d0c162fdc854d2d5dd2e66ddd95
>    Author: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
>    Date:   Wed Jan 24 11:38:38 2024 +0100
>=20
>        powerpc/6xx: set High BAT Enable flag on G2_LE cores
>       =20
>        [ Upstream commit a038a3ff8c6582404834852c043dadc73a5b68b4 ]
>=20
>=20
> Reverting that commit makes the build pass again.

It seems that backporting the mentioned commit verbatim would also require
2da37761671b5bdedbe04e6469cfa57cd6b6ae45 ("powerpc/32: Fix objtool unannota=
ted intra-function call
warnings") to make SYM_FUNC_START_LOCAL/SYM_FUNC_END available. Please drop=
 this patch from 6.1 and
older for now.

Adding Christophe and Michael to cc. Is backporting the additional patch an=
 option (and if so, for
which kernel versions?), or should I send a new patch that does not use
SYM_FUNC_START_LOCAL/SYM_FUNC_END for stable?

Thanks,
Matthias


>=20
> Greetings!
>=20
> Daniel D=C3=ADaz
> daniel.diaz@linaro.org
>=20