Received-SPF: pass (google.com: domain of linux-kernel+bounces-74303-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Praveen Kannoju <praveen.kannoju@oracle.com>
To: Hangbin Liu <liuhangbin@gmail.com>
CC: "j.vosburgh@gmail.com" <j.vosburgh@gmail.com>,
        "andy@greyhouse.net"
	<andy@greyhouse.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajesh
 Sivaramasubramaniom <rajesh.sivaramasubramaniom@oracle.com>,
        Rama
 Nichanamatlu <rama.nichanamatlu@oracle.com>,
        Manjunath Patil
	<manjunath.b.patil@oracle.com>
Subject: RE: [PATCH net-next v5] bonding: rate-limit bonding driver inspect
 messages
Thread-Topic: [PATCH net-next v5] bonding: rate-limit bonding driver inspect
 messages
Thread-Index: AQHaZIQBPXoFQXpUBEa77pYvezjdNbEUbF2AgAAJ5QA=
Date: Wed, 21 Feb 2024 08:27:46 +0000
Message-ID: 
 <SA1PR10MB64451708B325FDE134EE11978C572@SA1PR10MB6445.namprd10.prod.outlook.com>
References: <20240221050809.4372-1-praveen.kannoju@oracle.com>
 <ZdWrXyQTfF_bMPCA@Laptop-X1>
In-Reply-To: <ZdWrXyQTfF_bMPCA@Laptop-X1>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Av6SvQOdvGp2Tf/N1T7rPp5VvhNSRQIAE2z80vO4n/ulZlPYuFriz2PpsO07?=
 =?us-ascii?Q?mTF+FkGVAF8Rivd7/lZJ3yWAky7wp17xwI0nehrFqrvDMeY7edc8J8vv8oS1?=
 =?us-ascii?Q?rbGRHqtVJOXxIwUXz60ik7m4m3Mz6s/VKD+IZjZhyVL33R4gqHX/pJFLLJCp?=
 =?us-ascii?Q?CUT04KFq9sDlSVrDFzlX9ewiVNJEJR1d4vEp0xvTAFLHBMTJrRoCuWEx6pBL?=
 =?us-ascii?Q?JoomxH1qLha+prVdHiKIimcbB+Md+BQyM5RoS00AglyteXhmOouU4vaP+VxK?=
 =?us-ascii?Q?OKR/7eBpc3zThVvTor6oDs/SSoC/EgJukVtppsg/yPORfytIoM7PHjMjB9DL?=
 =?us-ascii?Q?X9s/OSytD9YegS9zTNK1eJj7OEzL9ECDCoSpiSflNUc46RhFidVgT3Dg+kqn?=
 =?us-ascii?Q?A0IcVX2zGb8QclxPY8FgnPDO5iw3OWTT0GPHL3Jb0xxj+N5ysjaxETVwMNIS?=
 =?us-ascii?Q?LOGcAvyGF11nNVhvOJheoI5jJG7FYiDwwUMHvnKP32+akVronvJLTiF8nZKy?=
 =?us-ascii?Q?siLwj/lSJ+FLcOtbcrSLthWtniuAtAmdAdHntzmcyVF+XpJZuwmjmZQTfB5p?=
 =?us-ascii?Q?EX2mp6XDSnxlPekQRnadCJRdSzgQRdzgC9yTzy5xXMlx77qkC46+IsY2edP8?=
 =?us-ascii?Q?2U7GyjO6L2J0LwMZAiD5cUKEGa16UfsN88ws7tWaT5Ocm/n59kBbNvKWXtnV?=
 =?us-ascii?Q?9JAXp2VAPFbN5EQ0QfXQhOj+adGu5J6jP3JkpVgTV8EHKNkGmJspbXLSA8S+?=
 =?us-ascii?Q?eksOAJtwz2X0grJ04FraM0SJKvVykgd4mugaRVd6WnbtdoNImBQDwh2pgdrQ?=
 =?us-ascii?Q?NuCH8O5hRlDWzBU4Ut+VS1QLqGPm6JAaBxWJBxcKAwtlUVFd2KK6eTioRg93?=
 =?us-ascii?Q?vn8nFKet4e1dx0bi/vg6BRexQ76+7TxGLp9bodSf/a/9X583cgq+RlL1/IQ2?=
 =?us-ascii?Q?oK6FjXG/tIPXh+paHU0ogla8kRnh37z5Wf2fq03ZQNrgp5Opgz9HJGx133oM?=
 =?us-ascii?Q?IlGQvQqLh+sWl8P4f8/rXWu0Nv8kPlugt7XHStfWC9OUFtsayeRJQ+2yoj1B?=
 =?us-ascii?Q?oTECgBndgWBAN/L7u6vo4AXnWPz9uCbWus/RCkD1jTlyCKOMa8J2G9ghXj6h?=
 =?us-ascii?Q?oeiudmqVPFzcl4Jy6W2BwpFqwc7gHH1+9u4zt6uu/96DErD8ZJhYF4QGrQod?=
 =?us-ascii?Q?sgi8X6SZq8GI5dvgxxtENyQmShTDAL1kK9LcuXtdrXj3cxmK33alePIqzyia?=
 =?us-ascii?Q?K2cjRvOfaiNlVu7Cb8rsyTWkv5BGlSYplmmI7sSd5Mx++P3qPGJevQaaugdB?=
 =?us-ascii?Q?i/YKv7OoYk31OppSc1w0RhTf3EATxbdGhXyKa8u6w6RPEa1sLjKOOI+Gytz2?=
 =?us-ascii?Q?P2vjCOuBe3za0zyLad+hbNtPvB/pIJwSh6sZS3Kc8Do8gHqoQv4t6g4K+Va8?=
 =?us-ascii?Q?ItUo7FIUkAO33uUhwcwGiETYbDKUqrRyeeK0oM1urZvbK2LpiX2eRFGtO60e?=
 =?us-ascii?Q?mR5IkcA3bmsSF0X2jDeCqaDDkbYDbotIXNwwXHNCHq9iUAd7uYIzb5+It2VX?=
 =?us-ascii?Q?ki9wVy+g38SgGEqg5SNoMS+sfCwQ/ZTxuMdY33MKixG6uOKSwxqemQMWHynG?=
 =?us-ascii?Q?GA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	RREzJxVwrZ0VTiMeL+mphXoFcXageU9PHIolDfmIidIYG3l7JLlU7/1gl83oMw4CZYP+lmrao+nZQlnONsYz8CzMrcjivttXzi+/5yLbtJMf49hv6Cx70HSYt4KFTw1aE5rPJtZesIGfzIoatAmeMLmZT64bmLnMCYHABWZ7qWPaaEB5Sy6Phs3n1ZTDujmLHe9aIZQ+0Z4JUv7yjdPvogrPYv7ba9qb2JV5YkujPmb4D1k6bHeRuQ5d5KhOCJ9Gc3vySDMB6onnMfpcqRPdTPzjeTuIJ3D1JT0z1WZLWt3AGA31ZjCOTrp2j2E/Sfe4LdTmyGWfX/KupHH9N+GrVLy7UCf0MbhbSJGnT3o0ChQby76D+Xsr94OBYlKo8wxMDjiZcxKKh83G8SCAjj+fBt/WfLsXcf+CP2hWqKK55vYqAEClfxbOXEofcPLuxZnVfhEQN9zAD+zs1uhllwuy0lDsIahPVi9kgRVyo3ePVRXZU/8Sfj/YvOpjUPq4MOgpNQMj+p5/dLljkMqyiKDYu2wkFFgpb12rUcH6n9I800Gn/okgC861jitthMkZCmrpWMzO8n1AW32efC4a89FoeYurm73OLnBfESWDR6lUCh4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB6445.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a05dec8f-1477-45de-ed9f-08dc32b6fb94
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 08:27:46.5475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rSkUDA+Z+ZZXJsAQXw52FhDM3Ysp8wWu1X2H61YqF+cjBMKbVd8dJx4DlrIefvd7NTCh/o+LVG0Vmwk6t4sq16tybazmpxsVl0nkoww1PgI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7924
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402210064
X-Proofpoint-GUID: WUipwa8RhtLTaqBKiiGf2Rv9DmwHE8tq
X-Proofpoint-ORIG-GUID: WUipwa8RhtLTaqBKiiGf2Rv9DmwHE8tq

> -----Original Message-----
> From: Hangbin Liu <liuhangbin@gmail.com>
> Sent: 21 February 2024 01:21 PM
> To: Praveen Kannoju <praveen.kannoju@oracle.com>
> Cc: j.vosburgh@gmail.com; andy@greyhouse.net; davem@davemloft.net; edumaz=
et@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; =
Rajesh Sivaramasubramaniom
> <rajesh.sivaramasubramaniom@oracle.com>; Rama Nichanamatlu <rama.nichanam=
atlu@oracle.com>; Manjunath Patil
> <manjunath.b.patil@oracle.com>
> Subject: Re: [PATCH net-next v5] bonding: rate-limit bonding driver inspe=
ct messages
>=20
> On Wed, Feb 21, 2024 at 10:38:09AM +0530, Praveen Kumar Kannoju wrote:
> > Through the routine bond_mii_monitor(), bonding driver inspects and
> > commits the slave state changes. During the times when slave state
> > change and failure in aqcuiring rtnl lock happen at the same time, the
> > routine
> > bond_mii_monitor() reschedules itself to come around after 1 msec to
> > commit the new state.
> >
> > During this, it executes the routine bond_miimon_inspect() to
> > re-inspect the state chane and prints the corresponding slave state on =
to the console.
> > Hence we do see a message at every 1 msec till the rtnl lock is
> > acquired and state chage is committed.
> >
> > This patch doesn't change how bond functions. It only simply limits
> > this kind of log flood.
> >
> > Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
> > ---
> > v5:
> >   - Redundant indentation addressed.
> > v4: https://lore.kernel.org/all/20240220050437.5623-1-praveen.kannoju@o=
racle.com/
> >   - Rectification in the patch subject and versioning details.
> > v3: https://lore.kernel.org/lkml/20240219133721.4567-1-praveen.kannoju@=
oracle.com/
> >   - Commit message is modified to provide summary of the issue, because=
 of
> >     which rate-limiting the bonding driver messages is needed.
> > v2: https://lore.kernel.org/lkml/20240215172554.4211-1-praveen.kannoju@=
oracle.com/
> >   - Use exising net_ratelimit() instead of introducing new rate-limit
> >     parameter.
> > v1:
> > https://lore.kernel.org/lkml/20240214044245.33170-1-praveen.kannoju@or
> > acle.com/
> > ---
> >  drivers/net/bonding/bond_main.c | 24 +++++++++++++-----------
> >  1 file changed, 13 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/net/bonding/bond_main.c
> > b/drivers/net/bonding/bond_main.c index 4e0600c..c8482cd 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -2609,12 +2609,12 @@ static int bond_miimon_inspect(struct bonding *=
bond)
> >  			bond_propose_link_state(slave, BOND_LINK_FAIL);
> >  			commit++;
> >  			slave->delay =3D bond->params.downdelay;
> > -			if (slave->delay) {
> > +			if (slave->delay && net_ratelimit()) {
> >  				slave_info(bond->dev, slave->dev, "link status down for %sinterfac=
e, disabling it in %d ms\n",
> >  					   (BOND_MODE(bond) =3D=3D
> > -					    BOND_MODE_ACTIVEBACKUP) ?
> > -					    (bond_is_active_slave(slave) ?
> > -					     "active " : "backup ") : "",
> > +					   BOND_MODE_ACTIVEBACKUP) ?
> > +					   (bond_is_active_slave(slave) ?
> > +					   "active " : "backup ") : "",
>=20
> Why these lines changed?
>=20
> Hangbin

Must be a editing mistake from my-end, Hangbin.=20
Addressed it.=20

-
Praveen.