Received-SPF: pass (google.com: domain of linux-kernel+bounces-74376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5ddce9b8-b6c1-09e2-3450-5119d4282067@huaweicloud.com>
Date: Wed, 21 Feb 2024 17:15:20 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v6 0/9] bugfix of MD_CLOSING and clean up md_ioctl()
To: Song Liu <song@kernel.org>, linan666@huaweicloud.com
Cc: mariusz.tkaczyk@linux.intel.com, shli@fb.com, neilb@suse.com,
 linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
 yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
 yangerkun@huawei.com
References: <20240206085511.2841555-1-linan666@huaweicloud.com>
 <CAPhsuW49cOvAK2+0c94sp2T3ZLoNf=P89X1tXoq6VNoJWNbv9A@mail.gmail.com>
From: Li Nan <linan666@huaweicloud.com>
In-Reply-To: <CAPhsuW49cOvAK2+0c94sp2T3ZLoNf=P89X1tXoq6VNoJWNbv9A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/2/13 7:36, Song Liu 写道:
> Hi Li Nan,
> 
> On Tue, Feb 6, 2024 at 1:00 AM <linan666@huaweicloud.com> wrote:
>>
>> From: Li Nan <linan122@huawei.com>
>>
>> Changes in v6:
>>   - in patch 2, return directly.
>>   - in patch 4, return directly in case GET_DISK_INFO and GET_ARRAY_INFO.
>>   - in patch 7, rewrite commit message.
>>   - add patch 8, clean up openers check.
>>
>> Changes in v5:
>>   - add patches 1-4 to clean up md_ioct(), pathc 4 can help us clean up
>>     local variable 'clear_md_closing'.
>>   - in patches 5 and 7, clean up local variable 'clear_md_closing'.
>>
>> By the way, md_ioctl() is not readable now, I wanna to re-write it later
>> to make it only have one 'switch' like other drivers.
> 
> Thanks for the patchset, and sorry for the delay.
> 
> The patchset looks good to me. However, it doesn't apply to md-6.9
> branch. Could you please resend or let me know the base branch/commit
> of the set?
> 
> Thanks,
> Song
> 
> .

Thanks for your review. I will resend it later.

-- 
Thanks,
Nan