Received-SPF: pass (google.com: domain of linux-kernel+bounces-74434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240220-fix-sh-mmcif-v1-1-b9d08a787c1f@linaro.org>
In-Reply-To: <20240220-fix-sh-mmcif-v1-1-b9d08a787c1f@linaro.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 21 Feb 2024 10:43:12 +0100
Message-ID: <CAMuHMdXdatXk4H2M0tr3fiZMGzx9FbuNUvCbhRbT0W2wfMVKdA@mail.gmail.com>
Subject: Re: [PATCH] mmc: sh_mmcif: sg_miter does not need to be atomic
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org, 
	linux-kernel@vger.kernel.org, 
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Linus,

Thanks for your patch!

s/does not need to/must/?

On Tue, Feb 20, 2024 at 11:58=E2=80=AFPM Linus Walleij <linus.walleij@linar=
o.org> wrote:
> All the sglist iterations happen in the *threaded* interrupt handler
> and that context is not atomic, so don't request an atomic
> sglist miter. Using an atomic miter results in "BUG: scheduling while
> atomic" splats.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 27b57277d9ba ("mmc: sh_mmcif: Use sg_miter for PIO")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi Geert, it'd be great if you could test this!

Thanks, that fixes the BUG, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Unfortunately it is not sufficient to make the eMMC work fully.
I will follow up in the original thread...

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds