Received-SPF: pass (google.com: domain of linux-kernel+bounces-74554-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Praveen Kannoju <praveen.kannoju@oracle.com>
To: Simon Horman <horms@kernel.org>
CC: "j.vosburgh@gmail.com" <j.vosburgh@gmail.com>,
        "andy@greyhouse.net"
	<andy@greyhouse.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajesh
 Sivaramasubramaniom <rajesh.sivaramasubramaniom@oracle.com>,
        Rama
 Nichanamatlu <rama.nichanamatlu@oracle.com>,
        Manjunath Patil
	<manjunath.b.patil@oracle.com>
Subject: RE: [PATCH net-next v6] bonding: rate-limit bonding driver inspect
 messages
Thread-Topic: [PATCH net-next v6] bonding: rate-limit bonding driver inspect
 messages
Thread-Index: AQHaZJ/z/dX/Wg+OFkqAMns3Aqcnw7EUmxOAgAABAFA=
Date: Wed, 21 Feb 2024 10:44:10 +0000
Message-ID: 
 <SA1PR10MB6445FD1C1390E0D7186896E78C572@SA1PR10MB6445.namprd10.prod.outlook.com>
References: <20240221082752.4660-1-praveen.kannoju@oracle.com>
 <20240221103853.GD352018@kernel.org>
In-Reply-To: <20240221103853.GD352018@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?wo6heOpgrlUbloT8bQSVvLSzjjRCRApOh+kSgPOF2ZmECfyF4E8B6c14fOXe?=
 =?us-ascii?Q?bD6P72r8FPMF6EchnkCTtEwOPG45VGHzIwOtteDndYQrfgmszj7191yi9r4i?=
 =?us-ascii?Q?HwPJcOaGrZJW6diaclhDftoSV3IvSGD9tK6F04RzuOXWhp+rI6vruvGmLo5H?=
 =?us-ascii?Q?2Ik1SIdxLtxzltG0vBHuDN4yXevagVGoy4LC7IQZ8e0yr0o0QXckseIoH9NZ?=
 =?us-ascii?Q?1FtlF7C6bYYcS4BBM8nKSBTb1iIjcCyZPTNOJ4T/zl8NgWVMveUQOJ1Puu2u?=
 =?us-ascii?Q?9QxGte9g8b+6zLDmjF7whsrxvUce9X95nCqHzPt8QSmP0q/nxLfN+1mJdPmz?=
 =?us-ascii?Q?MiqTnRvSbVFs2ceVw0i5CQLCTSwybbg3HKsTEcVStpeJb9exwtGaJXB5XR6k?=
 =?us-ascii?Q?/SIJY7IzIof6Sk272K3PEAuU4KPT8h4A8KlrUxYrno13bi0wOcgo34QXIGqC?=
 =?us-ascii?Q?lv+x1qt0qTJOes2ILVi+vvS9q9cTEUjyUqC5RTyKiwDl4LqAoC82Q8Wt2+Yb?=
 =?us-ascii?Q?TmmLZt9ZdH1xAAWxxkKUjHJceKCVOmg7rU9c0shsR5EG+4aTxGX0d8hfok5o?=
 =?us-ascii?Q?oRBup0ZQhxf+XHsu07m9TBt09lBBfILQzdqVafEVWds7NZJtrAWdXoOuY9cH?=
 =?us-ascii?Q?47flTCYE1ZRQ3jZQF2JpM2KwVYvKP1vuJUADtHp6CtB8A/WN7qs2c2U+Hl4p?=
 =?us-ascii?Q?AYFqP+Vd9wwvKx4rYpSPYpN1Rz1I0CF+jbE+rtz7+9JSktWZIgNY2HzPSTkh?=
 =?us-ascii?Q?4JzOmmD9JrL5TghXabYS/y1SHolrTQxuiXNHLlC9/33oE4mBnf+qWcoy12WG?=
 =?us-ascii?Q?W/y7X1oDYg46e10py0hATcpj6WeK9cgQ95SrPGqBAj8K7FTrzsivUedDVzom?=
 =?us-ascii?Q?AJ/7h/Z/fjwB9hEFWYO3EVrihQT2mwQdOY1cRvrrMiv2D+uefSpJL4o65Hlp?=
 =?us-ascii?Q?NjO1WDyuskTUBoWG96EZ2L40HCq8kSFGJLy6Y+VZGleeLe1wlLTtT4TDGXV2?=
 =?us-ascii?Q?kppeAC5FIILGqvZm6ATKD/Ka7jCHAchV31ZjVHC9L0CBEqxYngxngwI5ZZBW?=
 =?us-ascii?Q?Js3mS4OJfbERCD3xxiuFkr8vBzaTs4CXkSLp3Sf43O3pdf6ZVZ12KrM7nGmx?=
 =?us-ascii?Q?7/O+c9/2ygf7nVKz1i+//xRTytXrkxo1QXbYQMPdmKYeZEQKnVllI8MTnb3L?=
 =?us-ascii?Q?r3RXeNQ3ArQ07xyyT1FsmlBdCrfDh9FT+btWu/UzsfVhETI5Q/Dt95KVTQbA?=
 =?us-ascii?Q?0EBcY56Zj6WJLeHSEeIM2Oelm8PvoBtKJev8TJvOxKbKFjJkGD9mV/Axokmr?=
 =?us-ascii?Q?SxgOpM/DkI0jimEjJ39f9z17v1KJRh10IFS2EBeGTLdx5kSFe4an0rO05WrV?=
 =?us-ascii?Q?aMuoVv7AXu4bKKUXrd1v0wRlFswBS5WgxU01pq7AEFkvoXuT4WCW+8fhTs0m?=
 =?us-ascii?Q?bYZKU1sEfawTqNJ5zFE2ULZd45WQ+S2ZA8jgmWYUkQW8hmYX0VLgi6ErIPj0?=
 =?us-ascii?Q?o1bINV3uw5LnJfTjcnLghSNGr9nOU1jxUFq1Dep+l8TpNrMvPYrXdn/U9wM/?=
 =?us-ascii?Q?plwr0D/6rmJufOhTLo+S5CPLs3GiSakHGhckp8HrO4EbXJvjHqcb6kWfx5J1?=
 =?us-ascii?Q?Kg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	mM825wEfbCNJOCBWZ1owrHGG4JdMfkMUskJ0eTlpf/Ru1LcVugbxqo5mdpV+ADv+K8yJNG+lot/LkgsR3Dui9jwCenvJk70N1wUHLuqzStbVZ+URBACxjwnsw5kAGNo7Ttx59rFoWrbP4gkkHv9Gd4p1G9xNNkEraf7d7HP+TUaECzN6lStVJ+YsCQUfGE5Y7Sj/x/3kcZS2VVKqaPxJVKq1nRVp3/9BcSe4fmmdYfAe2QVZ1bbQpib61M/jl5IVnlQw6LCwjcEA2l4kpwzUaizZYl9YGNmAZDmIv4FkhKFPEtqB3bH+Pg9C5uXyp4jXjK211Hnd+tMpBGGi4adudH9i0ha+ki8wZPdqWHfABhCdbIVcLCtKUILru+s01R2yLGSCi38xaNk1xXjdpfJVeYahcHSV/dN5wqoQT839vrJwvs4YSMpw5AedRoLhBxgiZwK2ODJp2/pQlTRENKnppaO70gJNq6uKP2tk1hcGkXy3/lzCNXM78A3/z3ysPL7UygRjU6Uxyu7RGD+JkUe1wXv/qO8rMjA2FYVeFTKotCjXW1CJQq22FirTcffVbSzp0w+vSKG7u7hfYblSSpgw8HnYVsZ30hVdGZWBfHJ1FLY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB6445.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd7adae8-b311-4c67-e90c-08dc32ca0995
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 10:44:10.5216
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SydhAKUZG31jCqtMqyxlT0KYcnLOPfdeGVd8Gc+DDSpngdv0/UeJeHQRb2KLmK6CaxTqvvfDNJjjxW773xeLEMROxFbLGC1FLW1KqbIFYh8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5272
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-20_06,2024-02-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402210082
X-Proofpoint-GUID: eLbW7RwgHcBzy_RVYItpjkw2_FzSeGuM
X-Proofpoint-ORIG-GUID: eLbW7RwgHcBzy_RVYItpjkw2_FzSeGuM

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: 21 February 2024 04:09 PM
> To: Praveen Kannoju <praveen.kannoju@oracle.com>
> Cc: j.vosburgh@gmail.com; andy@greyhouse.net; davem@davemloft.net; edumaz=
et@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; =
Rajesh Sivaramasubramaniom
> <rajesh.sivaramasubramaniom@oracle.com>; Rama Nichanamatlu <rama.nichanam=
atlu@oracle.com>; Manjunath Patil
> <manjunath.b.patil@oracle.com>
> Subject: Re: [PATCH net-next v6] bonding: rate-limit bonding driver inspe=
ct messages
>=20
> On Wed, Feb 21, 2024 at 01:57:52PM +0530, Praveen Kumar Kannoju wrote:
> > Through the routine bond_mii_monitor(), bonding driver inspects and
> > commits the slave state changes. During the times when slave state
> > change and failure in aqcuiring rtnl lock happen at the same time, the
> > routine
> > bond_mii_monitor() reschedules itself to come around after 1 msec to
> > commit the new state.
> >
> > During this, it executes the routine bond_miimon_inspect() to
> > re-inspect the state chane and prints the corresponding slave state on =
to the console.
> > Hence we do see a message at every 1 msec till the rtnl lock is
> > acquired and state chage is committed.
> >
> > This patch doesn't change how bond functions. It only simply limits
> > this kind of log flood.
> >
> > Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
> > ---
> > v6:
> >   - Minor space additions addressed.
> > v5: https://lore.kernel.org/all/20240221050809.4372-1-praveen.kannoju@o=
racle.com/
> >   - Redundant indentation addressed.
> > v4: https://lore.kernel.org/all/20240220050437.5623-1-praveen.kannoju@o=
racle.com/
> >   - Rectification in the patch subject and versioning details.
> > v3: https://lore.kernel.org/lkml/20240219133721.4567-1-praveen.kannoju@=
oracle.com/
> >   - Commit message is modified to provide summary of the issue, because=
 of
> >     which rate-limiting the bonding driver messages is needed.
> > v2: https://lore.kernel.org/lkml/20240215172554.4211-1-praveen.kannoju@=
oracle.com/
> >   - Use exising net_ratelimit() instead of introducing new rate-limit
> >     parameter.
> > v1:
> > https://lore.kernel.org/lkml/20240214044245.33170-1-praveen.kannoju@or
> > acle.com/
> > ---
> >  drivers/net/bonding/bond_main.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
>=20
> Hi Praveen,
>=20
> Thanks for addressing my review of v4.
> This version looks good to me.
>=20
> Reviewed-by: Simon Horman <horms@kernel.org>
>=20
> ...

Thank you for the review, Simon, Hangbin and Jay.

-
Praveen.