Received-SPF: pass (google.com: domain of linux-kernel+bounces-74571-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 21 Feb 2024 11:57:22 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: stable@vger.kernel.org, pablo@netfilter.org, kadlec@netfilter.org,
	fw@strlen.de, davem@davemloft.net, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alexey.makhalov@broadcom.com,
	florian.fainelli@broadcom.com, vasavi.sirnapalli@broadcom.com,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v5.4.y] netfilter: nf_tables: fix pointer math issue in
 nft_byteorder_eval()
Message-ID: <2024022115-vixen-brought-6058@gregkh>
References: <1707108293-1004-1-git-send-email-ajay.kaher@broadcom.com>
 <1707108293-1004-2-git-send-email-ajay.kaher@broadcom.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1707108293-1004-2-git-send-email-ajay.kaher@broadcom.com>

On Mon, Feb 05, 2024 at 10:14:53AM +0530, Ajay Kaher wrote:
> From: Dan Carpenter <dan.carpenter@linaro.org>
> 
> commit c301f0981fdd3fd1ffac6836b423c4d7a8e0eb63 upstream.
> 
> The problem is in nft_byteorder_eval() where we are iterating through a
> loop and writing to dst[0], dst[1], dst[2] and so on...  On each
> iteration we are writing 8 bytes.  But dst[] is an array of u32 so each
> element only has space for 4 bytes.  That means that every iteration
> overwrites part of the previous element.
> 
> I spotted this bug while reviewing commit caf3ef7468f7 ("netfilter:
> nf_tables: prevent OOB access in nft_byteorder_eval") which is a related
> issue.  I think that the reason we have not detected this bug in testing
> is that most of time we only write one element.
> 
> Fixes: ce1e7989d989 ("netfilter: nft_byteorder: provide 64bit le/be conversion")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> [Ajay: Modified to apply on v5.4.y]
> Signed-off-by: Ajay Kaher <ajay.kaher@broadcom.com>
> ---

All now queued up, thanks.

greg k-h