Received-SPF: pass (google.com: domain of linux-kernel+bounces-74577-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <44d463e3-91f3-43c6-8c48-41cfb6ba1131@redhat.com>
Date: Wed, 21 Feb 2024 11:58:56 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X
To: Guoyi Zhang <kuoi@bioarchlinux.org>, sre@kernel.org, wens@csie.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240221083425.440108-1-kuoi@bioarchlinux.org>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240221083425.440108-1-kuoi@bioarchlinux.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 2/21/24 09:34, Guoyi Zhang wrote:
> The ROCK Pi X is a single board computer without batteries using the
> AXP288 PMIC where the EFI code does not disable the charger part of 
> the PMIC causing us to report a discharging battery with a continuously
> consumed battery charge to userspace.
> 
> Add it to the deny-list to avoid the bogus battery status reporting.
> 
> Signed-off-by: Guoyi Zhang <kuoi@bioarchlinux.org>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/power/supply/axp288_fuel_gauge.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 3be6f3b10..8f67f5d0d 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -599,6 +599,14 @@ static const struct dmi_system_id axp288_quirks[] = {
>  		},
>  		.driver_data = NULL,
>  	},
> +	{
> +		/* Radxa ROCK Pi X Single Board Computer */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "ROCK Pi X"),
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Radxa"),
> +		},
> +		.driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
> +	},
>  	{
>  		/*
>  		 * Various Ace PC/Meegopad/MinisForum/Wintel Mini-PCs/HDMI-sticks