Received-SPF: pass (google.com: domain of linux-kernel+bounces-74586-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 21 Feb 2024 12:03:07 +0100
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kovalev@altlinux.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, edumazet@google.com, laforge@gnumonks.org,
	davem@davemloft.net, pabeni@redhat.com, nickel@altlinux.org,
	oficerovas@altlinux.org, dutyrok@altlinux.org,
	stable@vger.kernel.org
Subject: Re: [PATCH ver.2] gtp: fix use-after-free and null-ptr-deref in
 gtp_genl_dump_pdp()
Message-ID: <ZdXYa8RqNO4xZxbw@calendula>
References: <20240214162733.34214-1-kovalev@altlinux.org>
 <ZczvJKETNyFE5Glm@calendula>
 <a4463193-fd73-eca3-616b-d75176d947c6@basealt.ru>
 <Zcz0tG9XMqLHMKs+@calendula>
 <1044d472-c733-3901-9df9-41a29b2c9fb4@basealt.ru>
 <Zc5NP/5Eyh8bsbH6@calendula>
 <20240220160434.29bcaf43@kernel.org>
 <ZdXUrV5YwIXnRI8u@calendula>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZdXUrV5YwIXnRI8u@calendula>

On Wed, Feb 21, 2024 at 11:47:12AM +0100, Pablo Neira Ayuso wrote:
> On Tue, Feb 20, 2024 at 04:04:34PM -0800, Jakub Kicinski wrote:
> > On Thu, 15 Feb 2024 18:43:46 +0100 Pablo Neira Ayuso wrote:
> >
> > Pablo is anything expected to change from gtp patch itself?
> > Someone (DaveM?) marked this as Changes Requested but I don't see 
> > a clear ask, other that to follow up with patches to other families.
> 
> Thanks for your follow up.
> 
> It would be good if this patch gets a Fixes: tag. I'd suggest:
> 
> Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
> 
> Meanwhile a v3 is sent, I am going to test it so I can provide a
> Testbed-by: tag for you.

Oh. My bad.

Patch is perfectly fine, it contains the Tested-by: tag already.

Please, apply.

Thanks.