Received-SPF: pass (google.com: domain of linux-kernel+bounces-74610-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a7f9e99b-e2ec-4acf-88d9-5d70de7b7588@intel.com>
Date: Wed, 21 Feb 2024 12:24:22 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] octeontx2-af: Consider the action set by PF
To: Subbaraya Sundeep <sbhatta@marvell.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <sgoutham@marvell.com>, <lcherian@marvell.com>,
	<gakula@marvell.com>, <hkelam@marvell.com>, <naveenm@marvell.com>,
	<horms@kernel.org>
References: <1708347314-21624-1-git-send-email-sbhatta@marvell.com>
Content-Language: en-US
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <1708347314-21624-1-git-send-email-sbhatta@marvell.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkRDUFB5L1ptMkxuTy85bXZGc1pNNG9jUk9QOHRkT00wOXA2YzcvNjRueXRx?=
 =?utf-8?B?cnM5YUphWHZOTjc1Vlk2TWJHMUdWZVBXKzhZVmdHUVpYR2M0b2FqZ3hIUnJC?=
 =?utf-8?B?VW90dTRES1Jvcml3Umd1ZG55MUNFaHV2endneVFncHZ3WHA1ZGtKSnBaRURY?=
 =?utf-8?B?WWtpazRWeUU3VURmYkJWMWdVWGtXc09pTVVTR1IxdE5ST1ZPNkZHbzliSTQ3?=
 =?utf-8?B?R1dmZkdQVGU2YTN3Q3M3K0lOZUFOZGNZMEpsK2lQZE1ac2FJTTdwSG1QeDI2?=
 =?utf-8?B?SFlxdU5abnhnWmFEUFlnOVB5eFBIcTlqMmQzUExyMEU4d0FhYnUvQTJ5SzY0?=
 =?utf-8?B?SkhLdVJuU1lnUGNyZ2pIRlRTR3hPM1VkTkI4aXp2NDBuVytXODFHekVSM1I0?=
 =?utf-8?B?SHpoeEZtMVNOU1BqMXdBazcvdUQ5MUR0K21DRE1pTlcvYjVSY280aFhjQ21v?=
 =?utf-8?B?R3VuUWFnRTM3d2RpblArUGJtcVk4MEkyeFVzM2tUMGdVanJaWlN1ekJ2ME4z?=
 =?utf-8?B?N1VLZVVBc1c2SlZaeEFhM0sxZHRCMElZQk0wazF1K2VFMVN2V0pPN1RVSVdZ?=
 =?utf-8?B?OWdmTmFHSkJTL3hXa1JiZ3loSWpSaU5EZTIyK2JRTFhtQVhuRnFOSFRxd2xB?=
 =?utf-8?B?ZjVaZGdCVjk0d1NqTXc5UFhMU0M3b2xIaHVPbUdLMHF5c1JxU09Qa2xEV1JM?=
 =?utf-8?B?cEMvaGtJb1l4S2FwcU9BcjdWZUtkVXBuSExtbEU1VkxhWkZTSGdNVitxUTgv?=
 =?utf-8?B?eUZoMDBWNjFLRlJJNmpFVFY3TmdIN2NaZnZ2cUpFNkwxdDRUNHBaYzJZeDFt?=
 =?utf-8?B?R3hLS1hjK0YxMXVyc21zeGVwV2tLMmJLVHdPMFVHamFVcU84ajc2ejdRSEpN?=
 =?utf-8?B?NCtjMGtsQzh6ZXEzTHlWYk1LVzRVSnlMNWwyY3JpbW1mRVBRa3EvajZwZnlE?=
 =?utf-8?B?NWJRSkFIcWcza3RzR245UzJtZXpZS01hTjRPNGRpOXZoa0NIRzlvNS9kODhY?=
 =?utf-8?B?bjlKSDFpbVh5a3JqUXFnQkVVVlJhOWxyenJYYzRsL0g5UFNXOUthb1paN1pp?=
 =?utf-8?B?MnE4N2Evb1lBenpnSVhHaVcwWmk1S09HT3VtcHJOcUVnT0NObTlaU2IyK3I0?=
 =?utf-8?B?OUFZMVlrSDIyK0xmMStRZnpLSHpLYnVreDRLenI3OUdZRlNTSmFrb2RMSUJX?=
 =?utf-8?B?K3Q1L1hKSUZEUzNTTlg5dFcvSnVXS0RtN2RJWUJsb3E4amV2QUpXK0UrTk5z?=
 =?utf-8?B?TUUrNkt0eUV3MnZqZXpLcUdPQ2JtdmREbitxbEtGc3puaU0rQ2hCb2p1ZE9Y?=
 =?utf-8?B?SFJRbEljbS9ZWVFONzhDcnJheHZZNnNDdUIvVm5RUzFIOTI5UFlqblFyNktj?=
 =?utf-8?B?ZEI4V0s5b2JqSUJnQ0lFU3o0MVNMVkVJMytFVklqREhyV3g3NE9oZVhUSWJ4?=
 =?utf-8?B?THY1ZGNGV0E0cFRPV3A1dTZsTm94RHovK2YxcFVDV0pvZmVYZEVjSkVGTXBx?=
 =?utf-8?B?TFdRL25ybFhSNUU1LzhCYWRJQzJCVW9KQkZaYXExaUZzYTJHNHd2b29DRnhj?=
 =?utf-8?B?ZEgzNmJNSGhlY0ZYTnU4TVhaOVEreGlhZ2JIbnoxUUYwOFpyYjVCVENGWDQ2?=
 =?utf-8?B?U3BSNGtXNnN3TWxFR2U0eEc0cTc3dE5zNkV3QXBjcnJkWFpxTWQyUjJTQlB4?=
 =?utf-8?B?WjE1bFVNankrUUo4SkYwN0tOaUt3ZDdBVyt5OU9INGpiWnlvUTg4STVwcTdO?=
 =?utf-8?B?MXJnMUhqc0RWNHV4UVJ4WXVFWUFFbGMzSkMxdlYyeHc1N21IOVZHT002NGlm?=
 =?utf-8?B?endPd1pRb0RBMmJsemJxR2FXeEY4Z3d3QnBHWFVIY05KUmM5dEtXUFVha0k5?=
 =?utf-8?B?M3prWkVrYmRuM0E3SGszKzhZRk1uVjBBVkJGNGdSTThnSGUzdUREcldYZCtx?=
 =?utf-8?B?R2NtYk1ZWC81VDAxZGNWejhFRWUzYitYaHVHRS9NTGY3VncvS291RS9vTXVN?=
 =?utf-8?B?eGIvbzNzWnlveWUrclJ4WFZSN1NGL2JrdzF1cGVycFA1YUFaeW8xZ2ZBNXhh?=
 =?utf-8?B?SnZiM3dsRzkvZUk4TjErVDZZZi9yNjRCZWVXOTErd25TUXlCSmh5bUJUOFZJ?=
 =?utf-8?B?SGd5blNMUFJTWUU5aWNCQlc1VUM2U2UwYzlzbXRsdlVBN2U4RHFEU1RqZGY3?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01465829-66e5-4d6e-20b4-08dc32cfab57
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 11:24:29.5287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZOpXCTN0XHHcvrK4rLx4Y70kGrISG04eMG8w0GHq6P+mjpB88diI6f+YFkEkNRvv8KmoYFeP02tPp66r9I5m6JoSO0Uh2hdFaFk4vC5Iw4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6394
X-OriginatorOrg: intel.com

On 2/19/24 13:55, Subbaraya Sundeep wrote:
> AF reserves MCAM entries for each PF, VF present in the
> system and populates the entry with DMAC and action with
> default RSS so that basic packet I/O works. Since PF/VF is
> not aware of the RSS action installed by AF, AF only fixup
> the actions of the rules installed by PF/VF with corresponding
> default RSS action. This worked well for rules installed by
> PF/VF for features like RX VLAN offload and DMAC filters but
> rules involving action like drop/forward to queue are also
> getting modified by AF. Hence fix it by setting the default
> RSS action only if requested by PF/VF.
> 
> Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature")
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> ---
>   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index e5d6156..516adb5 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -415,6 +415,10 @@ static void npc_fixup_vf_rule(struct rvu *rvu, struct npc_mcam *mcam,
>   			return;
>   	}
>   
> +	/* AF modifies given action iff PF/VF has requested for it */
> +	if ((entry->action & 0xFULL) != NIX_RX_ACTION_DEFAULT)

this is a magic constant, even if nice sounding one
and it's equal to NIX_RX_ACTION_DEFAULT BTW, but it's incidental
(perhaps you should have two defines, one for mask, and one for action)

> +		return;
> +
>   	/* copy VF default entry action to the VF mcam entry */
>   	rx_action = npc_get_default_entry_action(rvu, mcam, blkaddr,
>   						 target_func);

Otherwise the patch makes sense