Date: Sun, 30 Dec 2007 15:04:56 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch?] s2ram + P4 + tsc = annoyance
Message-ID: <20071230140456.GJ16946@elte.hu>
References: <1198745736.4235.23.camel@homer.simson.net> <1198779574.4425.50.camel@homer.simson.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1198779574.4425.50.camel@homer.simson.net>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 802
Lines: 20


* Mike Galbraith <efault@gmx.de> wrote:

> Or, reset to pristine prior to testing, though that's more lines to 
> accomplish the same thing.  Either way, or some other way...
> 
> If check_tsc_warp() is called after initial boot, and the TSC has in 
> the meantime been set (BIOS, user, silicon, elves) to a value lower 
> than the last stored/stale value, we blame the TSC.  Reset to pristine 
> condition after every test.

ok, i prefer this fix a bit more. (we dont want to set last_tsc outside 
of the sync_lock - which your initial patch does)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/