Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2334610rdb; Wed, 21 Feb 2024 04:44:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUn+LhN4WO98reKNiy9/DpppJWBkmQkuewukf8KsnX+i0fU/P3Gv7aFit2zJbnLvIV25mGlchCH4/ddMa4Gpt10wmfN/lwZCFzUuApbjg== X-Google-Smtp-Source: AGHT+IEpc7O/SKN5HeYAswHRjkAb5WBFIg/xG2Q0G02RgMKiQuRKMMOUGSKJCH58mPxmZWX/qPjs X-Received: by 2002:a17:902:b788:b0:1db:e089:7474 with SMTP id e8-20020a170902b78800b001dbe0897474mr10293218pls.66.1708519453379; Wed, 21 Feb 2024 04:44:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708519453; cv=pass; d=google.com; s=arc-20160816; b=V+/8iEYOc3q9p4qD81lWg9jLqAUP/+GBBo5XI08M/58LcnyOkDJoBXcyhCGWD9yknA VtneQXS3yvjpr+54YoUCbrUFJnZX/HEZK0UIQVy7cIULHvP2FHH93Q/fLirBoZv50SVr 0D9v2NSCvQ3n5RnBCAkUcNcQSj16oPheHTP6aQcQoX0yqYrTwsxWW4ZEmao/1cfSEKFI 8a7Fp4Lp+jEy+iL86TYk3/2ZrZeLEh+2Mr9Au7Z73N4qc/4fiL3ZpGmelf+8wE1p0gMX IT1dKVNDINhLZwcfg6d236J4GBI0gdd6J8jbC88AoAagHVEjCEeNN7UPTRODpHSomsiv a4PQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature:message-id; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; fh=V87tWXstpd2bW+xNjU9gbGuHXzJ2DwRU4XXGbBdbLXE=; b=dpQHsysYpFtZ60wwkJ3NJGde5EcP12U/N0CYNGcrl64jg+Ls3bgn1J345PhTzeeEaY K/SHgb7Ydgs+lnEGkSSpf8yO8lQPnV20z3jGTea/D1w0pS6Kmyc64OK0wfl403kPWKd3 8F5EieKiUYCnjHRQseFfNSXN7RNNtX5Pv2n1j2LOoyAI7IzzvAqJcDiElNxJyZTtH0fa 97vs6a5273bPMfERzQSUC1glb52qsiSFy7c9ICU6YfTQVUXy5sXpxxi862UzrEmSoh1Z qTJCyjVqnptrG8U/Z7/7W61vd3GuPsToYxlyG2R+5xR4MnzcMg5HLfSX2SCp0WuRCJ/3 nJHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xx4SlMy6; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xx4SlMy6; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=zpKtbHyN; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-74711-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p2-20020a1709027ec200b001da2a3a75d2si7976019plb.393.2024.02.21.04.44.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 04:44:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74711-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xx4SlMy6; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xx4SlMy6; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=zpKtbHyN; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-74711-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Message-ID: <65d5f01d.170a0220.e9c29.f7fdSMTPIN_ADDED_BROKEN@mx.google.com> X-Google-Original-Message-ID: <878r3eyoku.fsf@> Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BCDB0283DD0 for ; Wed, 21 Feb 2024 12:44:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6E8E69943; Wed, 21 Feb 2024 12:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xx4SlMy6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zpKtbHyN"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Xx4SlMy6"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zpKtbHyN" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5834B67E73; Wed, 21 Feb 2024 12:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708519445; cv=none; b=qPRMPrFum8JweabpezVnN2Tu+NMilw2vrr5RRULw0PuPH1Tol+7e6cf+JOW9t9rZMEbWjU3DOOMCJB2mwJjbKAReUSPU9OqHDtuYkuBj602kfaMSnFakuAwKbX2+DpDvsXpujxDkLEV7tbWtxGOC4Twq5YJNiqFjdCqDdx3xm6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708519445; c=relaxed/simple; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=L3P5cUq3hqMZVFhKyiV1TMYPDG7bjEmi5AFAD5VugZUSQyTgGtFAgjrXmugl3TUlRMmMrPIDdgXVqrzpv9dXItxRMr1eW02rlHqUIOXwBi04I0n7bMC1fech9E023caDmwyRcEUJCMnz7MOdzKZdJCNv+EEW+jsxX1t3S9tJzp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xx4SlMy6; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zpKtbHyN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Xx4SlMy6; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zpKtbHyN; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 460011FB66; Wed, 21 Feb 2024 12:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708519442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; b=Xx4SlMy6QSJAp97sysS2MZ+BkFe3PHHO0CBTr9NIVrPbEWm6Tc4tsVUsYFlEOPg9FsDG1D yqXTYzHsREBNsxawxjQP/qv0huii+0iu/tTrTRU+QviUEnDi+Yd11x7bgPblKxTM0rhFvD FQctbtwlb7tk19VwKO8na2o5BSB/UyQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708519442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; b=zpKtbHyNzZPV1VOSBF9quyCut1I54YW0S0qMivDVdrWfTKXTHTjiGyjBkmGQ6QRwssC5f4 wYo7L0AHXnH3gjAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708519442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; b=Xx4SlMy6QSJAp97sysS2MZ+BkFe3PHHO0CBTr9NIVrPbEWm6Tc4tsVUsYFlEOPg9FsDG1D yqXTYzHsREBNsxawxjQP/qv0huii+0iu/tTrTRU+QviUEnDi+Yd11x7bgPblKxTM0rhFvD FQctbtwlb7tk19VwKO8na2o5BSB/UyQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708519442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkgJhFNU0w2euKCzgtnfXaFn6+eWSHDRHzTmuXrUbwU=; b=zpKtbHyNzZPV1VOSBF9quyCut1I54YW0S0qMivDVdrWfTKXTHTjiGyjBkmGQ6QRwssC5f4 wYo7L0AHXnH3gjAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D5C58139D0; Wed, 21 Feb 2024 12:44:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3VHbMhHw1WVdaAAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 12:44:01 +0000 From: Nicolai Stange To: Shresth Prasad Cc: zhangwarden@gmail.com, jikos@kernel.org, joe.lawrence@redhat.com, jpoimboe@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org, mbenes@suse.cz, mpdesouza@suse.com, pmladek@suse.com, shuah@kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH] Fix implicit cast warning in test_klp_state.c In-Reply-To: (Shresth Prasad's message of "Wed, 21 Feb 2024 15:29:39 +0530 (GMT+05:30)") References: Date: Wed, 21 Feb 2024 13:44:01 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Xx4SlMy6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zpKtbHyN X-Spamd-Result: default: False [1.78 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWELVE(0.00)[14]; INVALID_MSGID(1.70)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_CC(0.00)[gmail.com,kernel.org,redhat.com,lists.linuxfoundation.org,vger.kernel.org,suse.cz,suse.com,linuxfoundation.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.11)[65.81%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: 1.78 X-Rspamd-Queue-Id: 460011FB66 X-Spam-Level: * X-Spam-Flag: NO X-Spamd-Bar: + Shresth Prasad writes: > I checked the source code and yes I am on the latest Linux next repo. > > Here's the warning: > /home/shresthp/dev/linux_work/linux_next/tools/testing/selftests/livepatc= h/test_modules/test_klp_state.c:38:24: warning: assignment to =E2=80=98stru= ct klp_state *=E2=80=99 from =E2=80=98int=E2=80=99 makes pointer from integ= er without a cast [-Wint-conversion] > =C2=A0=C2=A0 38 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 logleve= l_state =3D klp_get_state(&patch, CONSOLE_LOGLEVEL_STATE); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 ^ Is the declaration of klp_get_state() visible at that point, i.e. is there perhaps any warning about missing declarations above that? Otherwise C rules would default to assume an 'int' return type. Thanks, Nicolai --=20 SUSE Software Solutions Germany GmbH, Frankenstra=C3=9Fe 146, 90461 N=C3=BC= rnberg, Germany GF: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG N=C3=BCrnberg)