Received-SPF: pass (google.com: domain of linux-kernel+bounces-74724-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 21 Feb 2024 14:49:38 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 1/1] driver core: Move fw_devlink stuff to where it
 belongs
Message-ID: <ZdXxYjYsBQybbilQ@smile.fi.intel.com>
References: <20240220161002.2983334-1-andriy.shevchenko@linux.intel.com>
 <CAGETcx8hzYzjKWPz4ACgS=XrVXqg46QHB4hTpP5bDTY9=WFK+Q@mail.gmail.com>
 <ZdXxNFB8bMMFPoki@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZdXxNFB8bMMFPoki@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Feb 21, 2024 at 02:48:52PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 20, 2024 at 06:08:56PM -0800, Saravana Kannan wrote:
> > On Tue, Feb 20, 2024 at 8:10 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > A few APIs that belong specifically to the fw_devlink APIs
> > > - are exposed to others without need
> > > - prevents device property code to be cleaned up in the future
> > >
> > > Resolve this mess by moving fw_devlink code to where it belongs
> > > and hide from others.

..

> > The rest of the functions here are related to parents and children of
> > a fwnode. So, why is this function considered to be in the wrong
> > place?
> 
> When devlink was added it made a few fields in struct fwnode_handle.
> These fields have no common grounds with device properties. In particular
> struct device pointer is solely for devlinks and shouldn't be used with
> them. Hence this patch. TL;DR: they semantically do _not_ belong to
> the device property APIs.

On top of that for the 4+ years no new users appeared, so exporting them was
a clear mistake. Hence Fixes tags.

-- 
With Best Regards,
Andy Shevchenko