Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2349851rdb; Wed, 21 Feb 2024 05:12:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU56s1O/JtYAkP3VCE6FEV+O+JbS/w7fgUMkV0JjqxN7qL7QsUkX8ZNPUr6irsF5N5NjMVU//UjKye66ZdKv2fB/WgstxrjxMvX0oQISQ== X-Google-Smtp-Source: AGHT+IHajxwR51pirUS3nhfnnGuEOYEfeHcTwInTYc7Apz2bBFXEsJdNiRNoUEs1/GleweTiYAYH X-Received: by 2002:a17:90a:6c47:b0:299:8a32:952d with SMTP id x65-20020a17090a6c4700b002998a32952dmr7691616pjj.10.1708521120127; Wed, 21 Feb 2024 05:12:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708521120; cv=pass; d=google.com; s=arc-20160816; b=TVHjKBKXIAQuhbzCEogmaLMBDVTUfQUVyLhq/eBA7+6cfVZbbP7+ai072+rcGI2gzo dr8XNhutRJjTHRd0LadWgFVqFdphLZktevtbhyPztgaT9D5ycnr/+hSO1MBJeENNgV/V fM5tYcjLBlK7u7Krtbpxvn5qtkFyVJ2ZFr+6GjmQYVCoxBCefLt8Et6hzQSdpzuzkafE 7Pc/8OOrBjuGxQCQMAw2o/41qDh7lxP3J+JifsQ29MqJsOeVhAEF5khRYqorrdFWhYzg RBq7QM2/wwIt5MDizcv6VGsIte1lk809l/3oAqOG6+66EClTGuRtfnCkjGPOCippUsmr Osag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=yvVVrhvjHY4YuhOA+lFM2mTu+paFlyivAKigptrpqHU=; fh=H59Mzz5eOGKASExdor02c17McQWAWLUbEJrqVPnlrQw=; b=jQMVZPKBUx6aW/7BTPywLO60KeJ9BsZgGqDlxZQ1mXjDyeRsDcOP0mt8BJuMZ5ezD0 pKxOjeFyLbmZbwwTJeyAVpZSJMhQvEyP9SJMORs/+gFftstmqUBdHfYOOkcuZ9DV5kyI KQ1Qav2uBRtHi+BwWopBnwZbf7DRU6hMHlqEm0vMXriYMl86a/Jm02J8bW/ZPBEi9xMa nm8LZeQD3fgqHKSxJEPgQamT3UO3YpV7Oh4G4ys7NFnmFlkduqOObCZxRj7RaPLtfsak dTsvarLSgBgVq/h1FimE41kZUYBgV96CgUTxHL2z/lnONY1+Qn4fkdivFG2iz+IAzhhE Q0Cw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="g/GtBXNk"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=prrG8c77; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-74758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a5-20020a17090a740500b00298d4416077si8306231pjg.82.2024.02.21.05.11.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 05:12:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="g/GtBXNk"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=prrG8c77; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-74758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D2A0C2829B0 for ; Wed, 21 Feb 2024 13:11:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4892869D3F; Wed, 21 Feb 2024 13:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="g/GtBXNk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+XYzAtzE"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="prrG8c77"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="iFuUtGVp" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEFE369973 for ; Wed, 21 Feb 2024 13:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521116; cv=none; b=QxrJ6lCKdjBjtHbY/u/yWOuQ/XN6u9QyGtI0bAkQqKCj3EXURCE2AP/STgXifWIXEB2Mz9ntw2qQOF+39a2EZXVZbBmB0nVNhpsm8T8tg0OzM1u/bWENzekZhjPhQFaMYvZxf1un2K5lk+fNH+/ahvEpjqZ+CgLGooEwjPVW+KQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521116; c=relaxed/simple; bh=xMA29PDFG2r2/VIFEVCyCdFC9LE7vNJZ4G5Uz3jhE6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T/xIA9M6jzBaD6AVC2fiKpEWoiklAeKwd0TdA2CNmJv+uK4Xy+YquqHWB6GxUQPKLLBwhgzaJW/QD3DPgxbSaM2C9DB3VcRditpud23cgPbg/4QUy4mJFK2bkWLGtwPe2V2UW/pJ7W4OeFE/uJGySR4nVK8Al8KvaAe8CjXcp9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=g/GtBXNk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=+XYzAtzE; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=prrG8c77; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=iFuUtGVp; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EA40D1FB61; Wed, 21 Feb 2024 13:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708521113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yvVVrhvjHY4YuhOA+lFM2mTu+paFlyivAKigptrpqHU=; b=g/GtBXNkKWP5JrW7cv9laXx5edqXaQQVc48kGrVmc+oKgKb/FOD1ME75+FZf0T3qJFB0m9 aeRxpO22ax9vIJS+cmqL3/JjP4dWCWmTHg1iMXVP0P0rNqr+zgKTXLLFzvJFB5vN3lohzk J1SJwRI0gt4KyXrqnOq5kRzWvMCYkS4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708521113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yvVVrhvjHY4YuhOA+lFM2mTu+paFlyivAKigptrpqHU=; b=+XYzAtzEB6TecJShy6AA4PgOG0qGC++CpIICYBBAOadcAMcHcVguaJN+bm7rWLAQKeloiw L4EPw3JeJAOk8eBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708521112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yvVVrhvjHY4YuhOA+lFM2mTu+paFlyivAKigptrpqHU=; b=prrG8c77QgQvuZlRsBK9Lap62Z5RYC0HEenOAOTscDU2ZkMirsBXK5i5f2v398BSY4ucDT hD9+jQL5OOBy04bgCrN8qS0Dv6o6ZpGJBOOnTSpDp608N8TgErNHEcUSM3XhkuRh2kqwoN rVgCqGFdiQfQRgzHaQKyyQ6iL6wEp+E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708521112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yvVVrhvjHY4YuhOA+lFM2mTu+paFlyivAKigptrpqHU=; b=iFuUtGVp8jTIMrqcERYrWQR1yhziFCqCAi9pcDC+GGaLYElAlXvtytMx5A8uicsMEpg/iM CH4ssaTE3XMc7FCQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id D729B13A25; Wed, 21 Feb 2024 13:11:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id oRwXM5j21WVSOgAAn2gu4w (envelope-from ); Wed, 21 Feb 2024 13:11:52 +0000 Date: Wed, 21 Feb 2024 14:11:51 +0100 From: Daniel Wagner To: James Smart Cc: Keith Busch , Christoph Hellwig , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvmet-fc: move RCU read lock to nvmet_fc_assoc_exists Message-ID: References: <20240212102940.11137-1-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212102940.11137-1-dwagner@suse.de> Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-1.23 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.63)[92.67%] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -1.23 On Mon, Feb 12, 2024 at 11:29:40AM +0100, Daniel Wagner wrote: > The RCU lock is only needed for the lookup loop and not for > list_ad_tail_rcu call. Thus move it down the call chain into > nvmet_fc_assoc_exists. > > While at it also fix the name typo of the function. > > Signed-off-by: Daniel Wagner ping