Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2354057rdb; Wed, 21 Feb 2024 05:19:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVP6j0CR2jxJJM7Zv/mEYmCFty6McDeDOyzfL9eenDUyILMFvv/YqY0qH9/NsjuZJwVZv8VWBGKvEoAHpPx/hjCOcKL+3MVzKtkbNbqWQ== X-Google-Smtp-Source: AGHT+IG2bgUVzresBnNXL1P1RQF2KZxcepWJMz2cc0BLuvPgANf6C7GIn6rmIoXDMT+7r5r+7EIO X-Received: by 2002:a67:f498:0:b0:470:5792:cf86 with SMTP id o24-20020a67f498000000b004705792cf86mr5620556vsn.0.1708521571194; Wed, 21 Feb 2024 05:19:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708521571; cv=pass; d=google.com; s=arc-20160816; b=e8mgyzjjczxN3Ee+W2g9ZOubd47vwYAdXhjYtA8oGNYMlZLlaeVjiYCKLcTryFA6aj ppRAXcG1sLzqAxLee9aOWsYy5wiOgb8Jfy0zKJLMcQFBpUkS2SLBhGPadRDqsE38AgRN ee2L/avZKr+NpMx+Ak8iqGAj4d8ZR/CIg7cwRv9PcbWd+bBabQD/leobNPfJB2kDeV5v MtFG6adoC4HNylD688rhlbzx/zudadgIR2Vm+ZDJrT20a9tzL+xEwD84d1z0+FhHKB7r +00U7RFYYewh08QWD4oJ73+Q+jTtp9G2v+AzAJDAYpM2qcFA6F+9Q8e0U5gGLJxpXiMj i8EQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Z1S2KOzHiWZdc6EMCFLkKLCqiX/8caKNdzG63AOEvMU=; fh=wAYgqnQS54Oo8uQF470ay4krhDSysFGgPROrAyjhF08=; b=Algw8s7mIMGNS3RjkFq2cRY5E9PHLwegsI6P2dKHFmL/5hrTa+olFa97rvtuHxfaiT agQZ5h7zI06r3eUBEgSZjC+RQc7c/uk8e49SHoGA19JgG3IwnGx3j+H9ceUXaVCqs3Zm 7ZT8Z/+EH/iirkK3nhqxbcQyw08OxrK6AzRUT85R3ZclIxBWn7qzuchCW5i5iHdTEFFB ZW4HM3/SoIq/JE1ruUCqlVTxrqL0ZbXRJ21i4MsjiUNUNHL5NLv0m9xI1sXler9eXguJ vYkCFPtj5eTXqCX2L0CSrTtFQww/rHdMP2EA/g86L61GNsWH84xFWV1zyDrNbV6xoSFr grYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hzTsbrU2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-74769-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id hz9-20020a0561024a8900b0046d1d56441dsi1617395vsb.135.2024.02.21.05.19.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 05:19:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74769-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hzTsbrU2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-74769-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E605D1C2301E for ; Wed, 21 Feb 2024 13:19:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C5017762F; Wed, 21 Feb 2024 13:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hzTsbrU2" Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDA9669DF6 for ; Wed, 21 Feb 2024 13:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521561; cv=none; b=dV26WeOftg8AJ7uSVqLISPj8ASidWiQU0jVzc22VgoaA/10p+cVZy2p++3S8flMH8iRPmvWUixACR3GxMMxpw1SLhFHVXNmOPRr251cNv0pntmyArQS1Fe4601w3VJPZlm3uijYn4I5lSpd8NJCR4QoUf5QwxEUgXDLIbuR0r1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521561; c=relaxed/simple; bh=v7sh1t2tO3VL3q82JxTbVWXUuuW6ywKJik5QNS7wZCI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pLl8vIQj0SEL2WGbqNW0KuIeJMv/rATvLP8+Afl42Z6D6mDaJ2z3GCnogbjJLwCTGYjADasdZFtqy3SNsUGCFrVVJ8NDgaB5aKGCzbh7MId1QXc5sWNtotU0JPqTvL5HOSqiYuihOIEkcE6Ij1Suq3Z+c21tVepe2Fxv34XOss0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hzTsbrU2; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33d28468666so490053f8f.0 for ; Wed, 21 Feb 2024 05:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708521558; x=1709126358; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z1S2KOzHiWZdc6EMCFLkKLCqiX/8caKNdzG63AOEvMU=; b=hzTsbrU2bq8I5z9x6tdxgKRQX19yea/2FkVfBoYAUFshrOeXDrQgKEhtfFsyVNFqKn YIPrid4ExsV/EoO4qV4PUANNxaF/DhYMNQsuQmT4Z22zfzK727qvLn7OuQ4EoARw2bnT XP5KXS7ZX5P9tH76EwVNpegs0u8kIoRfhveJb4vEStjxdjct9iE/gYItDRxT7Oo3ZhuX 8jA9eWjTNa5L4fgF320SazlEdE83/rCCptMSCxOVAC0C7DDgH5oieF/T9FuhcE/bWv85 pMpdhtuXGGsFTxPRNxIUhEdBiim4o0RFY9MFFz1VQexSRlKom+Rm8Y6MzZUV2p2KgxPC nuKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708521558; x=1709126358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z1S2KOzHiWZdc6EMCFLkKLCqiX/8caKNdzG63AOEvMU=; b=fj7i7VbYN7L44yRfkVOffYrzmh0fw0sV4lszTXtt73XwI8ozLftoD0m8X3iFtBakNm p6kguBBkfy/EbjMJYNvU/lRb9EjGn7NyEpRzVmj5xPPwAejFS71tS9H8fRfOXycnRAvy SOPSkSbkWh8Qo1vW6aZAZqeLGDezB28mjqo0CV1C7hcWtYQWLkd+p9l7FIdtx6TU686O iQhtmRoEB9V6o83m/BBpkdp0OfrkqKNe3webmbIne/oNQhd9ZCnQL2ITkBdkBvhybwwM OMT87m22lIG/Qp7p6vyl1ovXBGwCLjCLI1exEGtwvOGOFpX4QlXpQtSI4lxSXFQnV5o+ p3Sg== X-Forwarded-Encrypted: i=1; AJvYcCUT+kM7Wz9HMOw0ZjKaVTjQ7ZSqcjhqJL+FsD092fRRU4jQ6SDTSRjpykUI9zpjsjBAYs+7uRi0r0br4nRMBHNr+6U7BumUcErE8yxM X-Gm-Message-State: AOJu0YyI0NfKlcRUSaYzmJMKYdpqrXE5MJbsGsv/W8fXzMkY38fzNCTt OjL8vNx/uxJhxsLYLJNzB+YmQBvhncIBM4RbjjT5hbyx5hZniWqrtkZJklfcebk= X-Received: by 2002:adf:f0d0:0:b0:33d:174e:4813 with SMTP id x16-20020adff0d0000000b0033d174e4813mr10817748wro.23.1708521558177; Wed, 21 Feb 2024 05:19:18 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id f7-20020a5d5687000000b0033ce727e728sm16683728wrv.94.2024.02.21.05.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 05:19:17 -0800 (PST) Date: Wed, 21 Feb 2024 16:19:14 +0300 From: Dan Carpenter To: Colin Ian King Cc: "Rafael J . Wysocki" , Zhang Rui , Len Brown , linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ACPI: thermal_lib: Add missing checks for errors in return code ret Message-ID: <68571997-c33a-49f8-b922-4b102e5b682b@moroto.mountain> References: <20240221123936.3421462-1-colin.i.king@gmail.com> <4b78456b-071f-46c0-bb47-919b493cab79@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b78456b-071f-46c0-bb47-919b493cab79@moroto.mountain> Btw, in real life, in 2024, the compiler is going to automatically initialize "temp_decik" to zero. So we could just do: - int temp_decik; + int temp_decik = 0; That would silence the warning without affecting anything else at all. regards, dan carpenter