Received-SPF: pass (google.com: domain of linux-kernel+bounces-74801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ca7d78f6cffc49eba7bb44134c85e94279f1ce95.camel@gmail.com>
Subject: Re: [PATCH] rtc: max31335: fix interrupt status reg
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>, Alexandre Belloni
	 <alexandre.belloni@bootlin.com>, Guenter Roeck <linux@roeck-us.net>, 
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 21 Feb 2024 14:30:03 +0100
In-Reply-To: <20240219091616.24480-1-antoniu.miclaus@analog.com>
References: <20240219091616.24480-1-antoniu.miclaus@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-02-19 at 11:16 +0200, Antoniu Miclaus wrote:
> Fix the register value comparison in the `max31335_volatile_reg`
> function for the interrupt status register.
>=20
> MAX31335_STATUS1 macro definition corresponds to the actual
> interrupt status register.
>=20
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/rtc/rtc-max31335.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 402fda8fd548..a2441e5c2c74 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev,=
 unsigned
> int reg)
> =C2=A0		return true;
> =C2=A0
> =C2=A0	/* interrupt status register */
> -	if (reg =3D=3D MAX31335_INT_EN1_A1IE)
> +	if (reg =3D=3D MAX31335_STATUS1)
> =C2=A0		return true;
> =C2=A0
> =C2=A0	/* temperature registers */