Date: Sun, 30 Dec 2007 15:51:15 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: clear IO_APIC before enabing apic error
	vector. v2
Message-ID: <20071230145115.GR16946@elte.hu>
References: <200712291952.20455.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200712291952.20455.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 32


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> please check if you can replace the one in the x86-mm
> 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76
> 
> the updated one avoid one link warning.

please send delta patches instead - so that we can review the changes.

> this is the updated verison that take enable_IO_APIC as extra call for 
> setup_local_APIC to avoid linking warning.

hm, what link warning did you get? Perhaps the following __cpuinit:

> -void __cpuinit setup_local_APIC (void)

does not mix well with an __init call:

> +void __init enable_IO_APIC(void)

and you hack it around by using a function pointer. Nasty and still 
buggy. The proper solution would be to mark enable_IO_APIC as __cpuinit 
too (or something like that).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/