Received-SPF: pass (google.com: domain of linux-kernel+bounces-74928-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/4] Change BPF_TEST_RUN use the system page
 pool for live XDP frames
In-Reply-To: <20240220210342.40267-1-toke@redhat.com>
References: <20240220210342.40267-1-toke@redhat.com>
Date: Wed, 21 Feb 2024 15:45:19 +0100
Message-ID: <87v86hzxj4.fsf@toke.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com> writes:

> Now that we have a system-wide page pool, we can use that for the live
> frame mode of BPF_TEST_RUN (used by the XDP traffic generator), and
> avoid the cost of creating a separate page pool instance for each
> syscall invocation. See the individual patches for more details.
>
> This series targets net-next because it depends on this series of
> Lorenzo's, that adds a global system page pool:
>
> https://lore.kernel.org/r/cover.1707729884.git.lorenzo@kernel.org
>
> Changelog:
> v2:
>  - Change the cookie that marks the page for recycling to be a 128-bit
>    value (Paolo)

Alright>  - Add a patch that removes the init_callback parameter from page
>    pool (Olek)
>  - Carry forward review tags from v1
>
> Toke H=C3=B8iland-J=C3=B8rgensen (4):
>   net: Register system page pool as an XDP memory model
>   bpf: test_run: Use system page pool for XDP live frame mode
>   bpf: test_run: Fix cacheline alignment of live XDP frame data
>     structures
>   page pool: Remove init_callback parameter
>
>  include/linux/netdevice.h     |   1 +
>  include/net/page_pool/types.h |   4 -
>  net/bpf/test_run.c            | 143 +++++++++++++++++-----------------
>  net/core/dev.c                |  13 +++-
>  net/core/page_pool.c          |   4 -
>  5 files changed, 86 insertions(+), 79 deletions(-)
>
> --=20
> 2.43.0