Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2424467rdb; Wed, 21 Feb 2024 07:19:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXyjAjwOq7jJnye2Tl+6CfdJ/fi23vWBG9Rcox7itEEX6erySzhiDNg2jT4Cg8pV2vSZxPBnqXlAWTreeS9bYM/S/DWV944PwR6doD3XQ== X-Google-Smtp-Source: AGHT+IGpF/kFBlhS4lF+eIwrpEp5UvqViRfKwwXu2s5q9Tzmtniohzo8GTi080raxvb34f/AxUUN X-Received: by 2002:a05:6870:968a:b0:21e:57e6:bdeb with SMTP id o10-20020a056870968a00b0021e57e6bdebmr20451692oaq.13.1708528745804; Wed, 21 Feb 2024 07:19:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708528745; cv=pass; d=google.com; s=arc-20160816; b=MUnRs2nP2HuhSLE6NZ0qXX/QldEIhtKMoLsOffxQHyWDhnCAJ+/Wbc6Qi8j7uioZyk EcxajHL7jNuEIq/R9iJeEEiqq9qPo7XHW3K6LBVf6RZxyuE8tluK8AtToAURfDMuzqB4 ByVtbmNhwrDFZKlI9DX0YLrCKz941Ozx3ciB8dHJLk+cZuGyxlJhydi7k/+VoonjSPP3 yxwIz8/Q3jGKPiUH6+D15wzBxUE0PViUjBsRQ+NT3U1aIP/KTCflA1W5g4D9slgWcX+u lQ5yvMW+hXXkDEL5v4u2Tvne6sp1mlfAxZdj7D9XkXwJ/MZosMf9qv57dP7BXWiaSjte Gy/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=sPMSiwVCiPeIGwx/AAt1khtpUMTfnKFjzlJJot8Dxks=; fh=8Bp01QvYKM+JeCaaV54ox2cFhqixOACaQRqIqNYyD28=; b=KhBVjYLJcFZCx5n8M+F+rMa2zGZLt3O5xMxA6xQy6KClzpLRngiuj2XPDeHf1LJA1y /TtPv/vvGInp7wrOd7CvpBplfasWpCQbDeAkcgHK0SU+fXcLajK7YJIgAIMeK6DHVr92 31Cska0f+NenJgWX/U/CFIZmqGnOCKYsXOEEH/IAZAtTSfSLJgDYgI8PosMES7LjVbhE TCxRp22kffKXWFSsCLxTkiZ3GAINmbO++2mu49pKZYw84fFOb8g1gEerjDR3TpOfhKqF cRYoYjR1Y1ZHmcbSjBOSPmMtqdXhjXhNApNAAMv36wLnJf9VPQBfNW3FUr1ynLk6FRou RTdQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DxjO3qNZ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-74984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s196-20020a6377cd000000b005dc423d758dsi8115092pgc.116.2024.02.21.07.19.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 07:19:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DxjO3qNZ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-74984-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 445D7282C30 for ; Wed, 21 Feb 2024 15:19:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A16580607; Wed, 21 Feb 2024 15:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DxjO3qNZ" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76C58002D for ; Wed, 21 Feb 2024 15:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708528740; cv=none; b=f6ZFp+1ChOUWFzry+z+ROyKr96KmzzO83QBCk70VEcJzLwUs+pwLX9rer2CX3uzyqm5IfYPtGRggOwg+UyfuDGYMe8CH8cmu2vdurhL2kqVQZBzcUhcygIEbz9OdeIypQUdrHwfhDrAwuqiV1/mAO7fSZ2nDYvVcC4YHdJEwdjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708528740; c=relaxed/simple; bh=SVN2brY5secpiGQcR6r7qO2NSkX9Sg3+pNiSRYMfNl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oScmDqdsG8tcyIJ7uHoFWZkZUkL963/MvzBcrLmXyhtKMVhvzGvrWj8Q+0AL4YxOQLj+RYBorAIheGrjFzqN5ysCKeW3+UxqjDQJCiUIxkdbz/aN3CaTNIgRLH/JdotVH842jarOQ8yDzAOT4C62lSltxQJchRc1RBuOI4dJV+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=DxjO3qNZ; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sPMSiwVCiPeIGwx/AAt1khtpUMTfnKFjzlJJot8Dxks=; b=DxjO3qNZEsRbv9bgH6zJr6Xx+4 bRW+lGgb37aeyfZERuZo1Xp9XVx+BCF5kiMRHCZ7vDWRnTLA/DAcJFIi1P/PJs6Ov6plCIKPDWtw6 OQDmLj8AF9of5cbrY6w+LomPvDeg9TaAhJmaUJ/OB5+Px7I46r4HBvZNyQmMZueK/m7umIrLU2Xen mis/x4Xwbyplo9dcBLAI9zvx7u0CBKB66Ly7OCnI45CH8iK00YhzFubeVSgzTIVlI46l9aef/aiDJ ujG6ClwOLOL35GoFduW9v97NNAF8aWQ1khOVcPYbV7X44w4DkdHyG+V916au3M2ouTgBfDjdKUqLd vcBzLP5w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcoN6-00000001Rci-3s9K; Wed, 21 Feb 2024 15:18:56 +0000 Date: Wed, 21 Feb 2024 07:18:56 -0800 From: Luis Chamberlain To: Mukesh Ojha Cc: russ.weight@linux.dev, gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware_loader: Suppress warning on FW_OPT_NO_WARN flag Message-ID: References: <20240219163954.7719-1-quic_mojha@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240219163954.7719-1-quic_mojha@quicinc.com> Sender: Luis Chamberlain On Mon, Feb 19, 2024 at 10:09:54PM +0530, Mukesh Ojha wrote: > Some of the warnings are still being printed even if FW_OPT_NO_WARN > is passed for some of the function e.g., firmware_request_nowarn(). > Fix it by adding a check for FW_OPT_NO_WARN before printing the warning. > > Signed-off-by: Mukesh Ojha Reviewed-by: Luis Chamberlain Luis