Received-SPF: pass (google.com: domain of linux-kernel+bounces-74988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 21 Feb 2024 11:19:23 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
	alex.williamson@redhat.com, robin.murphy@arm.com,
	eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
	chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, zhenzhong.duan@intel.com,
	joao.m.martins@oracle.com
Subject: Re: [PATCH rc 3/8] iommu/vt-d: Add missing iotlb flush for parent
 domain
Message-ID: <20240221151923.GU13330@nvidia.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-4-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208082307.15759-4-yi.l.liu@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/rgIpN7P0XxjfAInPjoSJwjaN/0T3yUxX/Ea2w8X/oSUvcZ1FEUquMW6cZcM?=
 =?us-ascii?Q?HYeCQ4mpf8Jvq1U9cmTs/uftz3LhO5MYfTed+p6tvI0VCGZoCoFPE93aJBQ5?=
 =?us-ascii?Q?+nF7GwqPo148oE5SKPPpiqK3hG4dstiLMuyDNz9sCWHQo9cyAgsMOi/VoZNp?=
 =?us-ascii?Q?f4+5fPqRmGqJMafcFH04f0fjPICDCjE2xF83J+Jo98kNuVwH37xGZz6rFvoW?=
 =?us-ascii?Q?KD87G65Y/vbPF16yq68uyCE7fmg6PttudK0QBUPKOkDrXuHiHxftHQE35l11?=
 =?us-ascii?Q?fgnQs8FX9scLkLrOWRQ262k3CHqK03LXnoxCc90T6Kp30Lkglhif9FW1m+gY?=
 =?us-ascii?Q?3S/6ymEojujMAmcySnbLs2c/c7hRHUl53RgcewVbxJ5IsmJG4b6xoSFpRsJn?=
 =?us-ascii?Q?y0hABZ4qcChJiKr6y6xHdxV6sj3A3BtqmP3dgYGH7Oplheh4Muyx+T7HWwQu?=
 =?us-ascii?Q?uoT16groX7aYJFfSPkMHyPU9/I5auzacDDjmqGMQpgCKFacynu/YvWPiKw7k?=
 =?us-ascii?Q?CDz+ZlwQKeyqjMXZ1V348LQjlZnK/TsXoi3xHIlS1aD+UrBjVdWJ6SRSses0?=
 =?us-ascii?Q?8s/SS5dLXV6R20DzofSIxZl0Y1BUUQ42VLjxATpBFPXt1X3aXDxWC6MEhcoj?=
 =?us-ascii?Q?nmrix0kOJz3YlDoc3aWLwDdzsYq1YBw7fELjaJ7ywnp6qG6N061FMA0ioQPe?=
 =?us-ascii?Q?JkG2NH2bKbxXUk73RwxFUctwjWooH0KVNbnGqZ58ffH6IPOHUGHbyxyq6HGI?=
 =?us-ascii?Q?1iejQMrdKozklmbd4UqfLcmpusQayvuJ+VLFSdmPXHgHhkpHlNEHC6HjSwFw?=
 =?us-ascii?Q?Ig9Je39Uw08GI2yGo0wvnpE4IHUJT5NSkDoLFeAcrnkW/47OG+9uwXcRvYUN?=
 =?us-ascii?Q?D72jc8qlG0q1tPtwfdhp3jXq4P72qrGnHP++w9smZ3rEfZmThnkiFMj5o6zm?=
 =?us-ascii?Q?3nbqhJuRzcnqkb27CzSxFKuCVRkVMRyIrjVeXo09G6rCm/zbrO5pYLvC9HyL?=
 =?us-ascii?Q?xMX6NhqDW5doel0a+Ndya/RhEaa2yjcIBqqBmhfFqVM00OxHM2VazW1MmSAS?=
 =?us-ascii?Q?3YKCmSjTSzPNtWBXyGC/ZMYAcVO0lT47q2CEU39sbsgsXgLW2eizLri9FcyG?=
 =?us-ascii?Q?qvw/Soy6eLn+oJjwqywFW4vPK9++j7IyEHAHH2qjhQtad/c6dBdSF6R3shgL?=
 =?us-ascii?Q?DjIItl7UyF0JfQYkNAsU7IsCJmMLM2dVwT1mUWIHqFGUobFws++H8EOwh4bu?=
 =?us-ascii?Q?vV0BCrgP9lsasM6VtlzueArd8KdEUwjsh1hbmp8o54dK9GPV5FGmeNnBFl2v?=
 =?us-ascii?Q?tTDsPy96FnMNAP9kJdzjijlHk+24daxs2SxYD347ehgam950fYyp684UWTDG?=
 =?us-ascii?Q?rvGvN2bQiLKnR2dBnbzt06/TTZ15bRkmMDmzUYJblZeZ67ztb7FnOvoDI3T/?=
 =?us-ascii?Q?3hWvZNIa+PbmV1ucYSz5bLC65kfFz/sA6dQ4VmoguKsojEjbt4PemMQhrR/G?=
 =?us-ascii?Q?d25q+LJ9skJLJMzarH13+MUdqSSJc+SvjCR2X+1FXDfSG8o8W73JjTTJ/xoN?=
 =?us-ascii?Q?g59YX7vr4ZSDvpfE1TcJWGK3/NTY0uKWvsasLppX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f860cb4-23b4-452d-82ee-08dc32f07c6b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 15:19:24.2154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 110qp9czq1osFlwZB1qts24y/sEk3WE1cjS9Aoiabzjt0ulCn9Uu6OkPtw/QzmfJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7496

On Thu, Feb 08, 2024 at 12:23:02AM -0800, Yi Liu wrote:
> If a domain is used as the parent in nested translation its mappings might
> be cached using DID of the nested domain. But the existing code ignores
> this fact to only invalidate the iotlb entries tagged by the domain's own
> DID.

> Loop the s1_domains list, if any, to invalidate all iotlb entries related
> to the target s2 address range. According to VT-d spec there is no need for
> software to explicitly flush the affected s1 cache. It's implicitly done by
> HW when s2 cache is invalidated.

I had to look this up to understand what it means.. The HW caches
per-DID and if you invalidate the DID's S2 then the HW flushes the S1
as well within that DID only.

It doesn't mean that the S2 is globally shared across all the nesting
translations (like ARM does), and you still have to iterate over every
nesting DID.

In light of that this design seems to have gone a bit off..

A domain should have a list of places that need invalidation,
specifically a list of DIDs and ATCs that need an invalidation to be
issued.

Instead we now somehow have 4 different lists in the domain the
invalidation code iterates over?

So I would think this:

struct dmar_domain {
	struct xarray iommu_array;	/* Attached IOMMU array */
	struct list_head devices;	/* all devices' list */
	struct list_head dev_pasids;	/* all attached pasids */
	struct list_head s1_domains;

Would make sense to be collapsed into one logical list of attached
devices:

struct intel_iommu_domain_attachment {
   unsigned int did;
   ioasid_t pasid;
   struct device_domain_info *info;
   list_head item;
};

When you attach a S1/S2 nest you allocate two of the above structs and
one is linked on the S1 and one is linked on the S2..

Jason