Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2433233rdb; Wed, 21 Feb 2024 07:33:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV6zw8MosNDw+m1z8j3z4mLRqU5tvkHFOmemII1d8a/vAwqUQ/T8w7czZEtJL0eppb7lQaLvzsltvoRtzQf6vyZTVAwP/4849UUZybebw== X-Google-Smtp-Source: AGHT+IERTLUvgWmkUCGhywc7qSrx6PY7LtJlP8AGgzgjNGxeDBtTOVbRyMvr0DSSs9g1HB7oaMqr X-Received: by 2002:a17:906:57ca:b0:a3f:ce6:bf00 with SMTP id u10-20020a17090657ca00b00a3f0ce6bf00mr3531176ejr.15.1708529612653; Wed, 21 Feb 2024 07:33:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708529612; cv=pass; d=google.com; s=arc-20160816; b=yUcxIBlTYcH3irn2faojcijjZyZ2s89eddHeKfLBHF4/R7hHBGzvwyEQQYNbPW0Ztd 53NCL4l7HzmxkeTcZK+L7Ea0uWcZ+eCWlbgyDftmiD4S5FTWMmYVgwQhJ+zLelbNAHjK Hg4Bjbz/HqhUPIbAAONVku8X1yewMlTE5ZZSMTasT2u9mLlnFGkyshy0dImQqeLHC2sD 0MiHQmNXhcY0qhG2+SOSp5048GDkl+81OGkZxNhbqAUCfZ3jCJGSfEQU7aRqCUpMpjYw WUonlaPxN2DeX7dW7p6mvVKFXtFIZ08k4sWFjTt4lQMnZuf0ZgKC8hORdeapbU92RFxy 8d+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=w572enQ4xpWhayQ/F0N1LHe6r3PVf/xSYftmveFsb7Y=; fh=+dc78TsYrpPPawhnTR4J+LV9qMv+T3k8SIUm7RMCBDk=; b=OOIaOo0o2HBKd8bKU/jHTfCeg+U5NjLMT4bJFkUBReiUEP9zT/OEhcg/tZ74lRMTJb oCR8N+F9OH1h/TMwVwIiSGJYVSPW47JdanthBR1S+Wkqb0P7hUKA+slWMgR7AL7KJBHm bbYrHcsHBCO/kGxKe9XBott7Nk5ORFUGPB+IZ4wR9NaqJ089ts6aYiUdkfM6WmkPlyJq LKclRZBKz/D1hHIRhWWC05vrlCG/aWAyoGQJx2nL/QhUkyhtiZx6FvJuRon9Iyebc+/0 ahFVSye4g62IEqUuR6uK3HDK0aB7yg8ZHoSw7yR1kYtq6oaVmuKiCVLl+bqVjK9zfiqT 3UNA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sBL9BzIO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75001-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z23-20020a1709060f1700b00a3dfb1b81fdsi4531817eji.1043.2024.02.21.07.33.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 07:33:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sBL9BzIO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75001-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6591A1F25433 for ; Wed, 21 Feb 2024 15:33:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0958C811E3; Wed, 21 Feb 2024 15:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sBL9BzIO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EA37FBBD for ; Wed, 21 Feb 2024 15:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708529577; cv=none; b=ud6nGHrAyTVIjJF4Wq2HxXcdg2MVMF6Op2ZgrjzRgw1vt8dtJd6C2m0qG5p+bnvwHjH42x10kUapgMyVXKLhSkR948SnG5GEk80NQ9Mi/7QPju2oV3IN4iZm7wrFMl6A24PJUY3a21wkuJ/VQ7UWzaTmmQjaDL3EB7QDdZpeEfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708529577; c=relaxed/simple; bh=SZ5oXc5KsO4JyGV5JCH+VaWP1R79qJcpalEIfQ+AjNk=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=utXcwBJmxhU1hDT3MDaEJUo8p813zgTO5kTjE+TFtL5KYvpM/f276jwJKcM921xVbnSJzjFlmMati8xAUQxXLJnt1D57574JG+BUHNOlItTpf2/V0Uwb+HGl8uecpemnOwzYgoWy85gVg9qjK+p7vJ+uOW/Z8p6Z7sGiSEwPY/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sBL9BzIO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6712EC43394; Wed, 21 Feb 2024 15:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708529576; bh=SZ5oXc5KsO4JyGV5JCH+VaWP1R79qJcpalEIfQ+AjNk=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=sBL9BzIOkKacSqSZcSHOox2ACQDM8p2/p1RdDEA/ZrgxJLV+aM0KMVfq/nnkbZXqI CPpo1V/PzcD7/oq8KpvD9nM4sNN1BAButWpZiKiZcvPHqBz94C6/ulHUW7YMUJY1dY n/SieglbeUsT7PQOYcOG+L84Ar0I+RbMO4lpjMDPfrwbCMqc5vzn/RrF9A6oyOZwBa It9cNKgBUUAwc9sidhRyc+ebQXfiSGeiIaoaH9a+lKGcdQ5hRp4X3UTVmCxwG5Ldiu dBrUVBGW/xoi8murfEvIwe+DJnXKHQT3whSuFpQbC4jPGQgi62nlPBgeggrCozt5ey H/UbGnd2E0vJQ== From: Robert Foss To: Thomas Zimmermann , Hans Verkuil , Neil Armstrong , Andrzej Hajda , Maxime Ripard , Archit Taneja , David Airlie , Daniel Vetter , Laurent Pinchart , Jonas Karlman , Maarten Lankhorst , Alvin Šipraga , Jernej Skrabec Cc: linux-kernel@vger.kernel.org, Alvin Šipraga , dri-devel@lists.freedesktop.org, Mads Bligaard Nielsen In-Reply-To: <20240219-adv7511-cec-irq-crash-fix-v2-1-245e53c4b96f@bang-olufsen.dk> References: <20240219-adv7511-cec-irq-crash-fix-v2-1-245e53c4b96f@bang-olufsen.dk> Subject: Re: [PATCH v2] drm/bridge: adv7511: fix crash on irq during probe Message-Id: <170852957313.2711855.7326941848429368841.b4-ty@kernel.org> Date: Wed, 21 Feb 2024 16:32:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.1 On Mon, 19 Feb 2024 21:21:47 +0100, Alvin Šipraga wrote: > From: Mads Bligaard Nielsen > > Moved IRQ registration down to end of adv7511_probe(). > > If an IRQ already is pending during adv7511_probe > (before adv7511_cec_init) then cec_received_msg_ts > could crash using uninitialized data: > > [...] Applied, thanks! [1/1] drm/bridge: adv7511: fix crash on irq during probe https://cgit.freedesktop.org/drm/drm-misc/commit/?id=aeedaee5ef54 Rob