Received-SPF: pass (google.com: domain of linux-kernel+bounces-75002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 21 Feb 2024 10:33:10 -0500
From: Frank Li <Frank.li@nxp.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: bhelgaas@google.com, cassel@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org,
	hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
	kw@linux.com, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v11 07/14] dt-bindings: imx6q-pcie: Clean up
 irrationality clocks check
Message-ID: <ZdYXtmJgTQ63jq+C@lizhi-Precision-Tower-5810>
References: <20240220161924.3871774-1-Frank.Li@nxp.com>
 <20240220161924.3871774-8-Frank.Li@nxp.com>
 <ZdXVN17SogJG1RgZ@lpieralisi>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdXVN17SogJG1RgZ@lpieralisi>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?01F6XAH0wvX7H5Y9Gewq3+845LDFenZ/A7ZVf3DLEEyXIxjFxRuKmaIZ7H8+?=
 =?us-ascii?Q?DGjbLMNfo4vh5LBUPTNucOxBIR2VWvatIDBntsB6uNnMFQQH5Lh5ed4o0gxc?=
 =?us-ascii?Q?7WESfR9fxE9cfv5AOYJ5n0uS6nJBYkW472oMgGTtd97HK9utg0TAwOOUpeW0?=
 =?us-ascii?Q?wKkbdAgQfR1aZUswAGSZ/sQNEP8LWJlijQeP8zxxKH2mj6WK67o7jSuhSQOg?=
 =?us-ascii?Q?itOuASXJta6cPtgm+CnJGYnUlwPm2zdyaONc5Y4Ea8lIXvYYDy5iiYr4Ef08?=
 =?us-ascii?Q?IVJEGiH7Dx8jdNg2DcIRwr6vtXzTnF4i56usDZJp5Wi1bS302ppm72WIBxdR?=
 =?us-ascii?Q?EMY6flds7MevQjW7aHaW+yG+vcmBpWPkPx+DAQ9QHnQWB5AAAFMsAhZCzdkr?=
 =?us-ascii?Q?meZuS2f7nYe4C75Ok6LDO0lyfIJF4c8A7Ldt4DxKIDAewBSdaTJ5XkdJSiYc?=
 =?us-ascii?Q?d66YPGh25+mwGq3UCzjPuPq8BhZSuyusc2nAx4r3HKDrvanF4Av9LExJyhpq?=
 =?us-ascii?Q?agP+5w38GCR1s0Grn5QD5B/ZKjB3POWVST1jx8CHDHftJjkchEIwZ1Q8ewLX?=
 =?us-ascii?Q?t6h/ZFYXgKRN7mBAh3GU1z2Q+t6Z2LX/I22Z/WG9JE1Z+hkVcGJr7XujjUVb?=
 =?us-ascii?Q?O+vSAYGwMgUoR+8Zv+Cd/z7SHGII7YiUSc3NJ1DCc7D0kouehooWmzaFwrBI?=
 =?us-ascii?Q?HaRtEkkC7D1Htt4cJwi7LknqBxwYNQL0Tobmt4rseYMXjaqkEjaFlcZmYpVB?=
 =?us-ascii?Q?DnGRANo9RxRZfNU//5shJQ8Sh42iK74Eks1hHqRrIhpk3qGU9vT9HbInLGu8?=
 =?us-ascii?Q?woXv3RPn75fPB10i2lru8q3tjzowsfgbJDkbJ0VktL2NhKGr8eEAmqXFF+73?=
 =?us-ascii?Q?9A1nEul60wSTCbZqmGV6RrUpxhdByRp6Ney5KSJg3ljayBbB20wWyvmMuzKc?=
 =?us-ascii?Q?PGlG3hYyRGYsPyQey6UcOjNp442hfapua09htjgNOH71Qykg8r2Wy1sv1OFh?=
 =?us-ascii?Q?fSpvzt17rfPZj8pIBoueB8Rs6rCmlhVbFfZi6F1pE/G+lBJK/qY9EfKUUn1I?=
 =?us-ascii?Q?nuyevQh2EG9XcEHVd35ysIGm9RuLVSSaon89YTDRuVZEzvgFlOu79rAnOPz7?=
 =?us-ascii?Q?tx8L2uTeXuuauwGk5W2sKG42uithcfb8KpS6dxnIkCQgVGtHxiXYzBUn1Wdq?=
 =?us-ascii?Q?cUDE8rHGfyaBMe0nmVO5DgAhclo/w6Y5IGmeBO79YrP7jWbdHVbmn+yg85NV?=
 =?us-ascii?Q?Pvrlig9jzOmydT6eR58C6+0LJRVFN788qTo7Ko09XZgwyMsTw4Ecxlas18SA?=
 =?us-ascii?Q?DPodIHona6pvOMKyYqyqN/xyrk7qoT5GrAXeogu3masOuDF0b2D86ulcfkA2?=
 =?us-ascii?Q?tiafiCRRswCRGynKy41gTUu7a4Dcve8WrUQbe2dP4DvvZuG5m9RUI7ETRyIW?=
 =?us-ascii?Q?CVDWu1/vL0MtFRbZJDFbU2FeBhbBBylvOyjq4URP0AEJ2qbW5N0vjPAWUSP/?=
 =?us-ascii?Q?1rmi/zC82h5Q0ZdVUiRzZXkSXBLc7d+Y4836C3+rzD62q86bVDtoUMcal6dT?=
 =?us-ascii?Q?IatKc9bbY7mkZjoeOBm6SugPeNJz+vl+grzcCLHF?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a721eb4-ee1f-44ad-ce5a-08dc32f26f60
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 15:33:21.3149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OzwDL/4CrUoRwaA7g9XC3oXqmMGWH6X3UpScno0xCI9zRHXt52KfLZ+7AvCy2c8yc9QCqKh+YG+ZXYMomWumQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8187

On Wed, Feb 21, 2024 at 11:49:27AM +0100, Lorenzo Pieralisi wrote:
> Irrationality ? I think you mean "duplicate" or "redundant" ?

I initially emphasized the negation logic code (*not*) below. I may have
used the wrong term.

I am okay simple said
"Clean up redundant clocks check"

Frank 

> 
> Lorenzo
> 
> On Tue, Feb 20, 2024 at 11:19:17AM -0500, Frank Li wrote:
> > The bindings referencing this file already define these constraints for
> > each of the variants, so the if not: then: is redundant.
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v7 to v8
> >     - add Manivannan Sadhasiva's Ack tag
> >     Change from v6 to v7
> >     - rewrite git commit message by using simple words
> >     Change from v5 to v6
> >     - rewrite git commit message and explain why remove it safely.
> >     - Add Rob's Ack
> >     Change from v1 to v4
> >     - new patch at v4
> > 
> >  .../bindings/pci/fsl,imx6q-pcie-common.yaml      | 16 ----------------
> >  1 file changed, 16 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > index d91b639ae7ae7..0c50487a3866d 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> > @@ -150,22 +150,6 @@ allOf:
> >              - {}
> >              - const: pcie_phy
> >              - const: pcie_aux
> > -  - if:
> > -      properties:
> > -        compatible:
> > -          not:
> > -            contains:
> > -              enum:
> > -                - fsl,imx6sx-pcie
> > -                - fsl,imx8mq-pcie
> > -                - fsl,imx6sx-pcie-ep
> > -                - fsl,imx8mq-pcie-ep
> > -    then:
> > -      properties:
> > -        clocks:
> > -          maxItems: 3
> > -        clock-names:
> > -          maxItems: 3
> >  
> >    - if:
> >        properties:
> > -- 
> > 2.34.1
> >