Received-SPF: pass (google.com: domain of linux-kernel+bounces-75026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
cc: andy@greyhouse.net, davem@davemloft.net, edumazet@google.com,
    kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
    linux-kernel@vger.kernel.org, rajesh.sivaramasubramaniom@oracle.com,
    rama.nichanamatlu@oracle.com, manjunath.b.patil@oracle.com
Subject: Re: [PATCH net-next v6] bonding: rate-limit bonding driver inspect messages
In-reply-to: <20240221082752.4660-1-praveen.kannoju@oracle.com>
References: <20240221082752.4660-1-praveen.kannoju@oracle.com>
Comments: In-reply-to Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
   message dated "Wed, 21 Feb 2024 13:57:52 +0530."
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32545.1708530576.1@famine>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 21 Feb 2024 07:49:36 -0800
Message-ID: <32546.1708530576@famine>

Praveen Kumar Kannoju <praveen.kannoju@oracle.com> wrote:

>Through the routine bond_mii_monitor(), bonding driver inspects and commi=
ts
>the slave state changes. During the times when slave state change and
>failure in aqcuiring rtnl lock happen at the same time, the routine
>bond_mii_monitor() reschedules itself to come around after 1 msec to comm=
it
>the new state.
>
>During this, it executes the routine bond_miimon_inspect() to re-inspect
>the state chane and prints the corresponding slave state on to the consol=
e.
>Hence we do see a message at every 1 msec till the rtnl lock is acquired
>and state chage is committed.
>
>This patch doesn't change how bond functions. It only simply limits this
>kind of log flood.
>
>Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>


>---
>v6: =

>  - Minor space additions addressed. =

>v5: https://lore.kernel.org/all/20240221050809.4372-1-praveen.kannoju@ora=
cle.com/
>  - Redundant indentation addressed.
>v4: https://lore.kernel.org/all/20240220050437.5623-1-praveen.kannoju@ora=
cle.com/
>  - Rectification in the patch subject and versioning details.
>v3: https://lore.kernel.org/lkml/20240219133721.4567-1-praveen.kannoju@or=
acle.com/
>  - Commit message is modified to provide summary of the issue, because o=
f
>    which rate-limiting the bonding driver messages is needed.
>v2: https://lore.kernel.org/lkml/20240215172554.4211-1-praveen.kannoju@or=
acle.com/
>  - Use exising net_ratelimit() instead of introducing new rate-limit
>    parameter.
>v1: https://lore.kernel.org/lkml/20240214044245.33170-1-praveen.kannoju@o=
racle.com/
>---
> drivers/net/bonding/bond_main.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_m=
ain.c
>index 4e0600c..51fdb79 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -2609,7 +2609,7 @@ static int bond_miimon_inspect(struct bonding *bond=
)
> 			bond_propose_link_state(slave, BOND_LINK_FAIL);
> 			commit++;
> 			slave->delay =3D bond->params.downdelay;
>-			if (slave->delay) {
>+			if (slave->delay && net_ratelimit()) {
> 				slave_info(bond->dev, slave->dev, "link status down for %sinterface,=
 disabling it in %d ms\n",
> 					   (BOND_MODE(bond) =3D=3D
> 					    BOND_MODE_ACTIVEBACKUP) ?
>@@ -2623,9 +2623,10 @@ static int bond_miimon_inspect(struct bonding *bon=
d)
> 				/* recovered before downdelay expired */
> 				bond_propose_link_state(slave, BOND_LINK_UP);
> 				slave->last_link_up =3D jiffies;
>-				slave_info(bond->dev, slave->dev, "link status up again after %d ms\=
n",
>-					   (bond->params.downdelay - slave->delay) *
>-					   bond->params.miimon);
>+				if (net_ratelimit())
>+					slave_info(bond->dev, slave->dev, "link status up again after %d ms=
\n",
>+						   (bond->params.downdelay - slave->delay) *
>+						   bond->params.miimon);
> 				commit++;
> 				continue;
> 			}
>@@ -2647,7 +2648,7 @@ static int bond_miimon_inspect(struct bonding *bond=
)
> 			commit++;
> 			slave->delay =3D bond->params.updelay;
> =

>-			if (slave->delay) {
>+			if (slave->delay && net_ratelimit()) {
> 				slave_info(bond->dev, slave->dev, "link status up, enabling it in %d=
 ms\n",
> 					   ignore_updelay ? 0 :
> 					   bond->params.updelay *
>@@ -2657,9 +2658,10 @@ static int bond_miimon_inspect(struct bonding *bon=
d)
> 		case BOND_LINK_BACK:
> 			if (!link_state) {
> 				bond_propose_link_state(slave, BOND_LINK_DOWN);
>-				slave_info(bond->dev, slave->dev, "link status down again after %d m=
s\n",
>-					   (bond->params.updelay - slave->delay) *
>-					   bond->params.miimon);
>+				if (net_ratelimit())
>+					slave_info(bond->dev, slave->dev, "link status down again after %d =
ms\n",
>+						   (bond->params.updelay - slave->delay) *
>+						   bond->params.miimon);
> 				commit++;
> 				continue;
> 			}
>-- =

>1.8.3.1
>
>